From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org, Justin Terry <juterry@microsoft.com>
Cc: "Fam Zheng" <fam@euphon.net>, "Thomas Huth" <thuth@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Stefan Weil" <sw@weilnetz.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Ilias Maratos" <i.maratos@gmail.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: [PATCH v2 1/3] target/i386: Fix broken build with WHPX enabled
Date: Fri, 20 Sep 2019 13:33:27 +0200 [thread overview]
Message-ID: <20190920113329.16787-2-philmd@redhat.com> (raw)
In-Reply-To: <20190920113329.16787-1-philmd@redhat.com>
The WHPX build is broken since commit 12e9493df92 which removed the
"hw/boards.h" where MachineState is declared:
$ ./configure \
--enable-hax --enable-whpx
$ make x86_64-softmmu/all
[...]
CC x86_64-softmmu/target/i386/whpx-all.o
target/i386/whpx-all.c: In function 'whpx_accel_init':
target/i386/whpx-all.c:1378:25: error: dereferencing pointer to
incomplete type 'MachineState' {aka 'struct MachineState'}
whpx->mem_quota = ms->ram_size;
^~
make[1]: *** [rules.mak:69: target/i386/whpx-all.o] Error 1
CC x86_64-softmmu/trace/generated-helpers.o
make[1]: Target 'all' not remade because of errors.
make: *** [Makefile:471: x86_64-softmmu/all] Error 2
Restore this header, partially reverting commit 12e9493df92.
Fixes: 12e9493df92
Reported-by: Ilias Maratos <i.maratos@gmail.com>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
target/i386/whpx-all.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/i386/whpx-all.c b/target/i386/whpx-all.c
index 0c15241ae4..def0c28480 100644
--- a/target/i386/whpx-all.c
+++ b/target/i386/whpx-all.c
@@ -18,6 +18,7 @@
#include "sysemu/cpus.h"
#include "sysemu/runstate.h"
#include "qemu/main-loop.h"
+#include "hw/boards.h"
#include "qemu/error-report.h"
#include "qapi/error.h"
#include "migration/blocker.h"
--
2.20.1
next prev parent reply other threads:[~2019-09-20 11:37 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 11:33 [PATCH v2 0/3] testing: Build WHPX enabled binaries Philippe Mathieu-Daudé
2019-09-20 11:33 ` Philippe Mathieu-Daudé [this message]
2019-09-20 11:37 ` [PATCH v2 1/3] target/i386: Fix broken build with WHPX enabled Paolo Bonzini
2019-09-20 11:33 ` [PATCH v2 2/3] tests/docker: Add fedora-win10sdk-cross image Philippe Mathieu-Daudé
2019-09-20 11:33 ` [PATCH v2 3/3] .shippable.yml: Build WHPX enabled binaries Philippe Mathieu-Daudé
2019-09-20 15:17 ` [PATCH v2 0/3] testing: " Philippe Mathieu-Daudé
2019-09-20 16:53 ` Justin Terry (VM)
2020-05-20 10:26 ` Philippe Mathieu-Daudé
2020-05-20 10:26 ` [Bug 1879672] " Philippe Mathieu-Daudé
2020-07-31 8:33 ` Philippe Mathieu-Daudé
2020-07-31 8:33 ` [Bug 1879672] " Philippe Mathieu-Daudé
2020-07-31 23:31 ` [EXTERNAL] " Sunil Muthuswamy
2020-08-03 10:51 ` Philippe Mathieu-Daudé
2020-08-03 10:51 ` [Bug 1879672] " Philippe Mathieu-Daudé
2020-08-03 11:28 ` Stefan Weil
2020-08-03 20:25 ` Stefan Weil
2020-08-04 6:43 ` Thomas Huth
2020-08-04 6:55 ` Stefan Weil
2020-08-04 7:23 ` Philippe Mathieu-Daudé
2020-08-04 7:23 ` [Bug 1879672] " Philippe Mathieu-Daudé
2020-08-04 7:42 ` Stefan Weil
2020-08-04 7:52 ` Philippe Mathieu-Daudé
2020-08-04 7:52 ` [Bug 1879672] " Philippe Mathieu-Daudé
2020-08-04 8:10 ` Thomas Huth
2020-08-04 9:23 ` Daniel P. Berrangé
2020-08-04 9:23 ` [Bug 1879672] " Daniel Berrange
2020-08-18 21:20 ` [EXTERNAL] " Sunil Muthuswamy
2020-08-19 3:36 ` Philippe Mathieu-Daudé
2020-08-19 3:36 ` [Bug 1879672] " Philippe Mathieu-Daudé
2019-09-21 6:34 ` no-reply
-- strict thread matches above, loose matches on Subject: below --
2020-05-20 10:14 [Bug 1879672] [NEW] QEMU installer with WHPX support Philippe Mathieu-Daudé
2020-05-20 10:25 ` [Bug 1879672] " Daniel Berrange
2020-05-20 12:30 ` Stefan Weil
2020-06-08 7:18 ` Philippe Mathieu-Daudé
2020-11-04 20:01 ` John Snow
2020-11-04 23:12 ` Philippe Mathieu-Daudé
2020-11-04 23:12 ` Philippe Mathieu-Daudé
2021-05-09 15:38 ` Philippe Mathieu-Daudé
2021-05-09 18:33 ` Stefan Weil
2021-05-27 7:45 ` Philippe Mathieu-Daudé
2020-02-18 20:38 [PATCH] WHPX: Assigning maintainer for Windows Hypervisor Platform Sunil Muthuswamy
2020-02-18 20:51 ` Justin Terry (SF)
2020-02-19 8:31 ` Philippe Mathieu-Daudé
2020-02-19 15:50 ` [EXTERNAL] " Justin Terry (SF)
2020-02-21 7:54 ` Stefan Weil
2020-02-24 19:43 ` Sunil Muthuswamy
2020-05-20 10:29 ` Philippe Mathieu-Daudé
2020-05-20 10:29 ` [Bug 1879672] " Philippe Mathieu-Daudé
2020-05-19 21:59 ` Sunil Muthuswamy
2020-05-20 10:29 ` Philippe Mathieu-Daudé
2020-05-20 10:29 ` [Bug 1879672] " Philippe Mathieu-Daudé
2020-02-21 17:15 ` Paolo Bonzini
2019-11-07 19:48 [PATCH v2] WHPX: support for xcr0 Sunil Muthuswamy
2019-11-07 20:05 ` Stefan Weil
2019-11-07 22:52 ` Sunil Muthuswamy
2020-05-20 10:27 ` Philippe Mathieu-Daudé
2020-05-20 10:27 ` [Bug 1879672] " Philippe Mathieu-Daudé
2019-11-12 18:52 ` Sunil Muthuswamy
2019-11-13 14:56 ` Paolo Bonzini
2022-04-28 6:31 ` Paolo Bonzini
2019-09-19 10:59 [Qemu-devel] [PATCH 0/2] testing: Build WHPX enabled binaries Philippe Mathieu-Daudé
2019-09-19 10:59 ` [Qemu-devel] [PATCH 1/2] tests/docker: Add fedora-win10sdk-cross image Philippe Mathieu-Daudé
2019-09-19 11:28 ` Alex Bennée
2019-09-19 11:35 ` Philippe Mathieu-Daudé
2019-09-19 10:59 ` [Qemu-devel] [PATCH 2/2] .shippable.yml: Build WHPX enabled binaries Philippe Mathieu-Daudé
2019-09-19 11:02 ` Philippe Mathieu-Daudé
2019-09-19 11:09 ` [Qemu-devel] [PATCH 0/2] testing: " Thomas Huth
2019-09-19 11:21 ` Philippe Mathieu-Daudé
2019-09-19 11:18 ` Stefan Weil
2019-09-19 11:26 ` Philippe Mathieu-Daudé
2020-05-20 10:25 ` Philippe Mathieu-Daudé
2020-05-20 10:25 ` [Bug 1879672] " Philippe Mathieu-Daudé
2019-09-19 11:41 ` [Qemu-devel] " Daniel P. Berrangé
2019-09-19 11:54 ` Philippe Mathieu-Daudé
2019-09-19 13:25 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920113329.16787-2-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=i.maratos@gmail.com \
--cc=juterry@microsoft.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).