From: Wei Yang <richardw.yang@linux.intel.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
rth@twiddle.net, Wei Yang <richardw.yang@linux.intel.com>,
qemu-devel@nongnu.org, quintela@redhat.com
Subject: Re: [Qemu-devel] [PATCH] migration: check length directly to make sure the range is aligned
Date: Tue, 1 Oct 2019 15:54:35 +0800 [thread overview]
Message-ID: <20191001075435.GA1425@richard> (raw)
In-Reply-To: <20190719180651.GM3000@work-vm>
On Fri, Jul 19, 2019 at 07:06:51PM +0100, Dr. David Alan Gilbert wrote:
>* Paolo Bonzini (pbonzini@redhat.com) wrote:
>> On 19/07/19 19:54, Dr. David Alan Gilbert wrote:
>> >> - if ((uintptr_t)host_endaddr & (rb->page_size - 1)) {
>> >> - error_report("ram_block_discard_range: Unaligned end address: %p",
>> >> - host_endaddr);
>> >> + if (length & (rb->page_size - 1)) {
>> >> + error_report("ram_block_discard_range: Unaligned length: %lx",
>> >> + length);
>> > Yes, I *think* this is safe, we'll need to watch out for any warnings;
>>
>> Do you mean compiler or QEMU warning?
>
>No, I mean lots of these error reports being printed out in some common
>case.
>
>Dave
>
> The patch is safe since there's an
Dave,
Any further comment for this patch? or What should I do next?
>>
>> if ((uintptr_t)host_startaddr & (rb->page_size - 1)) {
>> error_report("ram_block_discard_range: Unaligned start address: %p",
>> host_startaddr);
>> goto err;
>> }
>>
>> just before this context.
>>
>> Paolo
>--
>Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2019-10-01 7:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-12 3:27 [Qemu-devel] [PATCH] migration: check length directly to make sure the range is aligned Wei Yang
2019-07-19 17:54 ` Dr. David Alan Gilbert
2019-07-19 18:03 ` Paolo Bonzini
2019-07-19 18:06 ` Dr. David Alan Gilbert
2019-10-01 7:54 ` Wei Yang [this message]
2019-10-28 1:10 ` Wei Yang
2019-10-29 7:04 ` Dr. David Alan Gilbert
2019-10-29 8:21 ` Wei Yang
2019-11-11 23:19 ` Paolo Bonzini
2019-08-19 2:26 ` Wei Yang
2019-09-13 23:58 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001075435.GA1425@richard \
--to=richardw.yang@linux.intel.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).