From: Peter Krempa <pkrempa@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [PATCH v2 1/2] qapi: Add feature flags to commands in qapi introspection
Date: Tue, 1 Oct 2019 16:17:56 +0200 [thread overview]
Message-ID: <20191001141756.GA6129@angien.pipo.sk> (raw)
In-Reply-To: <87r23x55pm.fsf@dusky.pond.sub.org>
On Tue, Oct 01, 2019 at 08:40:21 +0200, Markus Armbruster wrote:
> Peter Krempa <pkrempa@redhat.com> writes:
>
> > Similarly to features for struct types introduce the feature flags also
> > for commands. This will allow notifying management layers of fixes and
> > compatible changes in the behaviour of a command which may not be
> > detectable any other way.
> >
> > The changes were heavily inspired by commit 6a8c0b51025.
> >
> > Signed-off-by: Peter Krempa <pkrempa@redhat.com>
>
> +1 on adding features to commands.
>
> Patch conflicts with the technical debt payback work I posted before and
> after this series, although not nearly as badly as I expected. It'll
> conflict some more with the parts I haven't flushed. The funny bit: I
> went on that rampage in preparation of QAPI language extensions
> including "features everywhere, not just structs".
>
> I'll look into how to best fit your work into mine.
Thanks. I have patches ready which depend on this to enable blockdev so
please let me know if the design changes somehow.
next prev parent reply other threads:[~2019-10-01 14:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 14:26 [PATCH v2 0/2] qapi: Add detection for the 'savevm' fix for blockdev Peter Krempa
2019-09-20 14:26 ` [PATCH v2 1/2] qapi: Add feature flags to commands in qapi introspection Peter Krempa
2019-10-01 6:40 ` Markus Armbruster
2019-10-01 14:17 ` Peter Krempa [this message]
2019-10-01 20:01 ` Markus Armbruster
2019-10-02 6:15 ` Markus Armbruster
2019-09-20 14:26 ` [PATCH v2 2/2] qapi: Allow introspecting fix for savevm's cooperation with blockdev Peter Krempa
2019-10-01 19:34 ` Markus Armbruster
2019-10-01 21:07 ` Eric Blake
2019-10-02 11:57 ` Markus Armbruster
2019-10-10 15:07 ` Kevin Wolf
2019-10-11 6:08 ` Markus Armbruster
2019-10-11 9:00 ` Kevin Wolf
2019-10-11 11:10 ` Markus Armbruster
2019-09-30 13:04 ` [PATCH v2 0/2] qapi: Add detection for the 'savevm' fix for blockdev Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001141756.GA6129@angien.pipo.sk \
--to=pkrempa@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).