From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B8D6C4360C for ; Fri, 4 Oct 2019 11:58:40 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F68A20862 for ; Fri, 4 Oct 2019 11:58:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F68A20862 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGMEJ-00058w-4B for qemu-devel@archiver.kernel.org; Fri, 04 Oct 2019 07:58:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52504) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGLpU-0000Se-Vv for qemu-devel@nongnu.org; Fri, 04 Oct 2019 07:33:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGLpT-0000tt-UZ for qemu-devel@nongnu.org; Fri, 04 Oct 2019 07:33:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39516) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iGLpT-0000tl-P4; Fri, 04 Oct 2019 07:32:59 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D37D98A1CA3; Fri, 4 Oct 2019 11:32:58 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 95E9A1001B30; Fri, 4 Oct 2019 11:32:51 +0000 (UTC) Date: Fri, 4 Oct 2019 13:32:51 +0200 From: Igor Mammedov To: Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= Subject: Re: [PATCH 01/11] hw/acpi/piix4: Convert reset handler to DeviceReset Message-ID: <20191004133251.1ca7791c@redhat.com> In-Reply-To: <20190926151733.25349-2-philmd@redhat.com> References: <20190926151733.25349-1-philmd@redhat.com> <20190926151733.25349-2-philmd@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Fri, 04 Oct 2019 11:32:59 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Damien Hedde , Peter Maydell , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Markus Armbruster Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 26 Sep 2019 17:17:23 +0200 Philippe Mathieu-Daud=C3=A9 wrote: > Convert the reset handler into a proper Device reset method. >=20 > Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Igor Mammedov > --- > hw/acpi/piix4.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c > index 5742c3df87..4e079b39bd 100644 > --- a/hw/acpi/piix4.c > +++ b/hw/acpi/piix4.c > @@ -27,7 +27,6 @@ > #include "hw/pci/pci.h" > #include "hw/qdev-properties.h" > #include "hw/acpi/acpi.h" > -#include "sysemu/reset.h" > #include "sysemu/runstate.h" > #include "sysemu/sysemu.h" > #include "qapi/error.h" > @@ -344,9 +343,9 @@ static const VMStateDescription vmstate_acpi =3D { > } > }; > =20 > -static void piix4_reset(void *opaque) > +static void piix4_pm_reset(DeviceState *dev) > { > - PIIX4PMState *s =3D opaque; > + PIIX4PMState *s =3D PIIX4_PM(dev); > PCIDevice *d =3D PCI_DEVICE(s); > uint8_t *pci_conf =3D d->config; > =20 > @@ -542,7 +541,6 @@ static void piix4_pm_realize(PCIDevice *dev, Error **= errp) > =20 > s->machine_ready.notify =3D piix4_pm_machine_ready; > qemu_add_machine_init_done_notifier(&s->machine_ready); > - qemu_register_reset(piix4_reset, s); > =20 > piix4_acpi_system_hot_add_init(pci_address_space_io(dev), > pci_get_bus(dev), s); > @@ -692,6 +690,7 @@ static void piix4_pm_class_init(ObjectClass *klass, v= oid *data) > k->device_id =3D PCI_DEVICE_ID_INTEL_82371AB_3; > k->revision =3D 0x03; > k->class_id =3D PCI_CLASS_BRIDGE_OTHER; > + dc->reset =3D piix4_pm_reset; > dc->desc =3D "PM"; > dc->vmsd =3D &vmstate_acpi; > dc->props =3D piix4_pm_properties;