From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 470FEC47404 for ; Sat, 5 Oct 2019 15:52:04 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 12D532133F for ; Sat, 5 Oct 2019 15:52:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GPCTy0gw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 12D532133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57524 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGmLj-000405-9T for qemu-devel@archiver.kernel.org; Sat, 05 Oct 2019 11:52:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46596) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iGmHo-0008KJ-Pv for qemu-devel@nongnu.org; Sat, 05 Oct 2019 11:48:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iGmHn-0007zT-IW for qemu-devel@nongnu.org; Sat, 05 Oct 2019 11:48:00 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:53529) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iGmHn-0007z2-C6; Sat, 05 Oct 2019 11:47:59 -0400 Received: by mail-wm1-x341.google.com with SMTP id i16so8509789wmd.3; Sat, 05 Oct 2019 08:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dTLpadbDkv5ZbECq3hhQLZXW2FlV9PLUwUKPlrgWr+I=; b=GPCTy0gw951EGOqZEvDUJw2NKt1hzuZWalF45US8vgcteH99p39RsYLLuR8wGh+uyS 25fdx10MGXMJVzoBr+wUJ5MyH9UtIEf33mDVy+LN6gpr2UJzm/6Mj3fayYj6rCtGWl7x 0r8qkK6wlWGW6dFY8UREkdaKT/Q8mXeIy2lDLGEUxcrkwMaiz492hV+IGsJpQ4kZWNDA /IEgooFRoQSmzXC6lBYDYqjy2ff6s981VaY+ZcSN7CnhfBgVGs5o+UqSwPp30OjUFIt5 ttrZz6lAsIkI5HKGkIeqAnJY920bUnRc4y8eH+GEbxJv/FUn9sbEXCngWrRsBuGu6+19 RRqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=dTLpadbDkv5ZbECq3hhQLZXW2FlV9PLUwUKPlrgWr+I=; b=X+Cg/nYg+MsicUo+PSS8wpT4LHEYrSZtSRZCW3FZbJUklMdKNqR4o1Q46r6x1N6WK9 WznMEXmyGOoUYtfZ0u5KFq8OrrRV9ecHR9/om1zFI9mNmlVbvIS+ShIzDEi9ZbcV2MX+ fTQ2+RrYtMuzRZxtrT+3WdOTEl7Q3lvUJxXeA6NKeaKngq4oZtK58ggFPBBpd/jtxzWH dhhg/RmyhyXrXq95i4SMNIOi8xt0/jR0cBpRNOH8FapK000tmqA+BT1Cu4nKk+Hp8i9G K1+fllT3OI/vbKnsoz4EG0IkFQS3Q2pQUztn7eQJk/OH7QdICEoD1mWDJ1+BCOhHLjue zF+A== X-Gm-Message-State: APjAAAVu/jZ/zwc+eG2EWU+DUXWj5hwoJ4W7JH5zTO87S8fYY4/N8CiD BOIH30vooSi67yZc/+QcdqBfzPSX+Hg= X-Google-Smtp-Source: APXvYqzIEHJ/hg5ePThlp3SzPvMweoStrrxOCdkcpTRsFG8gKWh3Duxft2nsK4KX11CaN69emW+kYQ== X-Received: by 2002:a1c:a8d8:: with SMTP id r207mr14153461wme.135.1570290478218; Sat, 05 Oct 2019 08:47:58 -0700 (PDT) Received: from localhost.localdomain (46.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.46]) by smtp.gmail.com with ESMTPSA id o22sm24542294wra.96.2019.10.05.08.47.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 05 Oct 2019 08:47:57 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 4/5] hw/arm/exynos4210: Use the Samsung s3c SDHCI controller Date: Sat, 5 Oct 2019 17:47:47 +0200 Message-Id: <20191005154748.21718-5-f4bug@amsat.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191005154748.21718-1-f4bug@amsat.org> References: <20191005154748.21718-1-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Basse?= , Peter Maydell , Eduardo Habkost , Evgeny Voevodin , Bartlomiej Zolnierkiewicz , Igor Mitsyanko , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Krzysztof Kozlowski , Jean-Christophe Dubois , qemu-arm@nongnu.org, Dmitry Solodkiy , Cleber Rosa , Maksim Kozlov , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Guenter Roeck Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" The Exynos SoC has specific SDHCI registers. Use the s3c SDHCI model which handle these specific registers. This silents the following "SDHC ... not implemented" warnings so we can focus on the important registers missing: $ qemu-system-arm ... -d unimp \ -append "... root=/dev/mmcblk0 rootfstype=ext4 rw rootwait" \ -drive file=linux-build-test/rootfs/arm/rootfs-armv5.ext2,if=sd,format=raw [...] [ 25.744858] sdhci: Secure Digital Host Controller Interface driver [ 25.745862] sdhci: Copyright(c) Pierre Ossman [ 25.783188] s3c-sdhci 12530000.sdhci: clock source 2: mmc_busclk.2 (12000000 Hz) SDHC rd_4b @0x80 not implemented SDHC wr_4b @0x80 <- 0x00000020 not implemented SDHC wr_4b @0x8c <- 0x00030000 not implemented SDHC rd_4b @0x80 not implemented SDHC wr_4b @0x80 <- 0xc0004100 not implemented SDHC wr_4b @0x84 <- 0x80808080 not implemented [ 26.013318] mmc0: SDHCI controller on samsung-hsmmc [12530000.sdhci] using ADMA [ 26.032318] Synopsys Designware Multimedia Card Interface Driver [ 42.024885] Waiting for root device /dev/mmcblk0... Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/exynos4210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/exynos4210.c b/hw/arm/exynos4210.c index a9f8a5c868..77fbe1baab 100644 --- a/hw/arm/exynos4210.c +++ b/hw/arm/exynos4210.c @@ -405,7 +405,7 @@ static void exynos4210_realize(DeviceState *socdev, Error **errp) * public datasheet which is very similar (implementing * MMC Specification Version 4.0 being the only difference noted) */ - dev = qdev_create(NULL, TYPE_SYSBUS_SDHCI); + dev = qdev_create(NULL, TYPE_S3C_SDHCI); qdev_prop_set_uint64(dev, "capareg", EXYNOS4210_SDHCI_CAPABILITIES); qdev_init_nofail(dev); -- 2.20.1