From: Greg Kurz <groug@kaod.org>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, peterx@redhat.com, quintela@redhat.com
Subject: Re: [PATCH] migration: Don't try and recover return path in non-postcopy
Date: Mon, 7 Oct 2019 12:38:55 +0200 [thread overview]
Message-ID: <20191007123855.5f596f50@bahia.lan> (raw)
In-Reply-To: <20191007103507.31308-1-dgilbert@redhat.com>
On Mon, 7 Oct 2019 11:35:07 +0100
"Dr. David Alan Gilbert (git)" <dgilbert@redhat.com> wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> In normal precopy we can't do reconnection recovery - but we also
> don't need to, since you can just rerun migration.
> At the moment if the 'return-path' capability is on, we use
> the return path in precopy to give a postiive 'OK' to the end
s/postiive/positive
> of migration; however if migration fails then we fall into
> the postcopy recovery path and hang. This fixes it by only
> running the return path in the postcopy case.
>
> Reported-by: Greg Kurz <groug@kaod.org>
> Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
Thanks !
Tested-by: Greg Kurz <groug@kaod.org>
> migration/migration.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/migration/migration.c b/migration/migration.c
> index 5f7e4d15e9..d5d9b31bb7 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -2481,7 +2481,7 @@ retry:
> out:
> res = qemu_file_get_error(rp);
> if (res) {
> - if (res == -EIO) {
> + if (res == -EIO && migration_in_postcopy()) {
> /*
> * Maybe there is something we can do: it looks like a
> * network down issue, and we pause for a recovery.
next prev parent reply other threads:[~2019-10-07 10:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 10:35 [PATCH] migration: Don't try and recover return path in non-postcopy Dr. David Alan Gilbert (git)
2019-10-07 10:38 ` Greg Kurz [this message]
2019-10-08 14:14 ` Peter Xu
2019-10-11 13:26 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191007123855.5f596f50@bahia.lan \
--to=groug@kaod.org \
--cc=dgilbert@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).