From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF81CC4360C for ; Tue, 8 Oct 2019 22:01:19 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B403B21721 for ; Tue, 8 Oct 2019 22:01:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B403B21721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37606 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHxXi-0004qE-No for qemu-devel@archiver.kernel.org; Tue, 08 Oct 2019 18:01:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51772) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iHxVe-0003WF-F9 for qemu-devel@nongnu.org; Tue, 08 Oct 2019 17:59:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iHxVd-0003wB-Bd for qemu-devel@nongnu.org; Tue, 08 Oct 2019 17:59:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33916) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iHxVa-0003ue-GA; Tue, 08 Oct 2019 17:59:06 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 793C888382D; Tue, 8 Oct 2019 21:59:05 +0000 (UTC) Received: from localhost.localdomain (ovpn-122-151.rdu2.redhat.com [10.10.122.151]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B08A86012A; Tue, 8 Oct 2019 21:58:59 +0000 (UTC) Date: Tue, 8 Oct 2019 17:58:57 -0400 From: Cleber Rosa To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH 2/5] hw/sd/sdhci: Add a comment to distinct the i.MX eSDHC functions Message-ID: <20191008215857.GB11091@localhost.localdomain> References: <20191005154748.21718-1-f4bug@amsat.org> <20191005154748.21718-3-f4bug@amsat.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20191005154748.21718-3-f4bug@amsat.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.69]); Tue, 08 Oct 2019 21:59:05 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?iso-8859-1?Q?Fr=E9d=E9ric?= Basse , Peter Maydell , Eduardo Habkost , Evgeny Voevodin , Bartlomiej Zolnierkiewicz , Igor Mitsyanko , qemu-devel@nongnu.org, Krzysztof Kozlowski , Jean-Christophe Dubois , qemu-arm@nongnu.org, Dmitry Solodkiy , Maksim Kozlov , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Guenter Roeck Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sat, Oct 05, 2019 at 05:47:45PM +0200, Philippe Mathieu-Daud=E9 wrote: > This file keeps the various QDev blocks separated by comments. >=20 > Signed-off-by: Philippe Mathieu-Daud=E9 > --- > hw/sd/sdhci.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c > index e08ec3e398..82ec5c1b4a 100644 > --- a/hw/sd/sdhci.c > +++ b/hw/sd/sdhci.c > @@ -1532,6 +1532,8 @@ static const TypeInfo sdhci_bus_info =3D { > .class_init =3D sdhci_bus_class_init, > }; > =20 > +/* --- qdev i.MX eSDHC --- */ > + > static uint64_t usdhc_read(void *opaque, hwaddr offset, unsigned size) > { > SDHCIState *s =3D SYSBUS_SDHCI(opaque); > @@ -1734,7 +1736,6 @@ usdhc_write(void *opaque, hwaddr offset, uint64_t= val, unsigned size) > } > } > =20 > - > static const MemoryRegionOps usdhc_mmio_ops =3D { > .read =3D usdhc_read, > .write =3D usdhc_write, > --=20 > 2.20.1 >=20 >=20 Reviewed-by: Cleber Rosa