From: David Gibson <david@gibson.dropbear.id.au>
To: Igor Mammedov <imammedo@redhat.com>
Cc: deller@gmx.de, mark.cave-ayland@ilande.co.uk,
qemu-devel@nongnu.org, qemu-ppc@nongnu.org, hpoussin@reactos.org,
atar4qemu@gmail.com, rth@twiddle.net
Subject: Re: [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory()
Date: Wed, 9 Oct 2019 23:02:11 +1100 [thread overview]
Message-ID: <20191009120211.GI5035@umbus.fritz.box> (raw)
In-Reply-To: <20191009131921.6423f00d@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1205 bytes --]
On Wed, Oct 09, 2019 at 01:19:21PM +0200, Igor Mammedov wrote:
> On Wed, 9 Oct 2019 12:21:06 +1100
> David Gibson <david@gibson.dropbear.id.au> wrote:
>
> > On Tue, Oct 08, 2019 at 07:33:17AM -0400, Igor Mammedov wrote:
> > > rs6000mc_realize() violates memory_region_allocate_system_memory() contract
> > > by calling it multiple times which could break -mem-path. Replace it with
> > > plain memory_region_init_ram() instead.
> > >
> > > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >
> > Acked-by: David Gibson <david@gibson.dropbear.id.au>
> >
> > Or would you like me to merge this through my tree?
>
>
> (since it doesn't belong to a particular tree, I'd need find
> some to take in in)
>
> Since you volunteered :),
> please merge this series via your tree.
Uhhh.. I was offering to take this patch, not the whole series. I'm
not real comfortable taking the others, since they don't involve ppc
code, nor are they prereqs for or motivated by any ppc change.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-09 21:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 11:33 [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory() Igor Mammedov
2019-10-08 11:33 ` [PATCH 1/3] sparc64: use memory_region_allocate_system_memory() only for '-m' specified RAM Igor Mammedov
2019-10-08 12:09 ` Philippe Mathieu-Daudé
2019-10-08 13:55 ` Igor Mammedov
2019-10-08 11:33 ` [PATCH 2/3] ppc: rs6000_mc: drop usage of memory_region_allocate_system_memory() Igor Mammedov
2019-10-08 12:24 ` Philippe Mathieu-Daudé
2019-10-09 1:21 ` David Gibson
2019-10-09 11:19 ` Igor Mammedov
2019-10-09 12:02 ` David Gibson [this message]
2019-10-08 11:33 ` [PATCH 3/3] hppa: drop usage of memory_region_allocate_system_memory() for ROM Igor Mammedov
2019-10-08 12:30 ` Philippe Mathieu-Daudé
2019-10-20 21:49 ` Philippe Mathieu-Daudé
2019-10-08 12:41 ` [PATCH 0/3] eliminate remaining places that abuse memory_region_allocate_system_memory() Philippe Mathieu-Daudé
2019-10-08 13:52 ` Igor Mammedov
2019-10-10 17:35 ` Igor Mammedov
2019-10-11 15:23 ` Igor Mammedov
2019-10-20 14:38 ` Philippe Mathieu-Daudé
2019-10-22 22:09 ` Eduardo Habkost
2019-10-21 8:59 ` Philippe Mathieu-Daudé
2019-10-21 9:18 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009120211.GI5035@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=atar4qemu@gmail.com \
--cc=deller@gmx.de \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).