From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3503ECE58C for ; Wed, 9 Oct 2019 17:57:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6E11206C0 for ; Wed, 9 Oct 2019 17:57:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6E11206C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53402 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIGDc-000094-KF for qemu-devel@archiver.kernel.org; Wed, 09 Oct 2019 13:57:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58178) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iI9TN-0003vt-Vd for qemu-devel@nongnu.org; Wed, 09 Oct 2019 06:45:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iI9TL-0006Pe-Pm for qemu-devel@nongnu.org; Wed, 09 Oct 2019 06:45:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51520) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iI9TL-0006PK-Ju; Wed, 09 Oct 2019 06:45:35 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8B77510DCC95; Wed, 9 Oct 2019 10:45:34 +0000 (UTC) Received: from gondolin (ovpn-117-191.ams2.redhat.com [10.36.117.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5A58F60A9F; Wed, 9 Oct 2019 10:45:29 +0000 (UTC) Date: Wed, 9 Oct 2019 12:45:27 +0200 From: Cornelia Huck To: David Hildenbrand Subject: Re: [PATCH v4 6/7] s390x/mmu: DAT table definition overhaul Message-ID: <20191009124527.490a18f7.cohuck@redhat.com> In-Reply-To: <20191004105102.15821-7-david@redhat.com> References: <20191004105102.15821-1-david@redhat.com> <20191004105102.15821-7-david@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.64]); Wed, 09 Oct 2019 10:45:34 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , Janosch Frank , Richard Henderson , qemu-devel@nongnu.org, Halil Pasic , Christian Borntraeger , qemu-s390x@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 4 Oct 2019 12:51:01 +0200 David Hildenbrand wrote: > Let's use consitent names for the region/section/page table entries and Can you still fixup s/consitent/consistent/ before picking up? :) > for the macros to extract relevant parts from virtual address. Make them > match the definitions in the PoP - e.g., how the relevant bits are actually > called. > > Introduce defines for all bits declared in the PoP. This will come in > handy in follow-up patches. > > Add a note where additional information about s390x and the used > definitions can be found. > > Acked-by: Richard Henderson > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 78 +++++++++++++++++++++++++++++---------- > target/s390x/mem_helper.c | 12 +++--- > target/s390x/mmu_helper.c | 37 ++++++++++--------- > 3 files changed, 84 insertions(+), 43 deletions(-)