From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, vsementsov@virtuozzo.com,
qemu-block@nongnu.org, mlevitsk@redhat.com
Subject: [PATCH v2 0/2] Better NBD string length handling
Date: Thu, 10 Oct 2019 16:00:16 -0500 [thread overview]
Message-ID: <20191010210018.22000-1-eblake@redhat.com> (raw)
Patch 1 is a revised version after Maxim's comments - it moves the
length checks earlier into the system (for cleaner error messages
as soon as possible) and adds asserts at the later points that
are now guaranteed by the earlier checks. It also covers more
string handling, both in the client and in the server, by
ensuring that outgoing strings are properly constrained and
incoming strings are checked for validity before blind use.
Patch 2 is a new patch, written to make testing of description
strings in patch 1 easier.
Eric Blake (2):
nbd: Don't send oversize strings
nbd: Allow description when creating NBD blockdev
qapi/block.json | 8 +++++---
include/block/nbd.h | 1 +
block/nbd.c | 9 +++++++++
blockdev-nbd.c | 14 +++++++++++++-
monitor/hmp-cmds.c | 4 ++--
nbd/client.c | 16 +++++++++++++---
nbd/server.c | 14 ++++++++++++--
qemu-nbd.c | 9 +++++++++
tests/qemu-iotests/223 | 2 +-
tests/qemu-iotests/223.out | 1 +
10 files changed, 66 insertions(+), 12 deletions(-)
--
2.21.0
next reply other threads:[~2019-10-10 21:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 21:00 Eric Blake [this message]
2019-10-10 21:00 ` [PATCH v2 1/2] nbd: Don't send oversize strings Eric Blake
2019-10-11 7:32 ` Vladimir Sementsov-Ogievskiy
2019-10-15 15:07 ` Eric Blake
2019-10-15 16:16 ` Vladimir Sementsov-Ogievskiy
2019-11-04 17:41 ` Maxim Levitsky
2019-11-13 15:47 ` Eric Blake
2019-10-10 21:00 ` [PATCH v2 2/2] nbd: Allow description when creating NBD blockdev Eric Blake
2019-10-11 7:41 ` Vladimir Sementsov-Ogievskiy
2019-11-04 17:53 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010210018.22000-1-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).