From: Kevin Wolf <kwolf@redhat.com>
To: Cleber Rosa <crosa@redhat.com>
Cc: qemu-block@nongnu.org, qemu-trivial@nongnu.org,
Michael Tokarev <mjt@tls.msk.ru>,
Laurent Vivier <laurent@vivier.eu>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [PATCH v2 2/4] qemu-iotests: remove forceful execution success from library files
Date: Fri, 11 Oct 2019 13:25:30 +0200 [thread overview]
Message-ID: <20191011112530.GE5158@localhost.localdomain> (raw)
In-Reply-To: <20191009194740.8079-3-crosa@redhat.com>
Am 09.10.2019 um 21:47 hat Cleber Rosa geschrieben:
> Should not be necessary on files that are not executed standalone.
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
Looks fine for common.filter and common.rc, nobody ever checks their
return value.
common.config is included like this:
if ! . "$source_iotests/common.config"
then
_init_error "failed to source common.config"
fi
So as long as we keep this, don't we want to make sure that it returns
success?
Of course, we never really want to return an error from common.config,
so instead of keeping the final 'true' statement, we might consider
changing its inclusion to not check for errors. The case that
potentially changes is when common.config doesn't exist or isn't
readable, but this isn't supposed to ever happen anyway.
Kevin
next prev parent reply other threads:[~2019-10-11 11:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 19:47 [PATCH v2 0/4] iotests: trivial cleanups Cleber Rosa
2019-10-09 19:47 ` [PATCH v2 1/4] qemu-iotests: remove bash shebang from library files Cleber Rosa
2019-10-09 19:51 ` Eric Blake
2019-10-09 20:54 ` Cleber Rosa
2019-10-11 9:36 ` Kevin Wolf
2019-10-11 11:27 ` Nir Soffer
2019-10-11 20:05 ` Cleber Rosa
2019-10-11 20:30 ` Kevin Wolf
2019-10-09 19:47 ` [PATCH v2 2/4] qemu-iotests: remove forceful execution success " Cleber Rosa
2019-10-11 11:25 ` Kevin Wolf [this message]
2019-10-09 19:47 ` [PATCH v2 3/4] qemu-iotests: 044: pass is actually a noop, so remove it Cleber Rosa
2019-10-10 11:27 ` Philippe Mathieu-Daudé
2019-10-11 11:26 ` Kevin Wolf
2019-10-09 19:47 ` [PATCH v2 4/4] qemu-iotests: 044: remove inaccurate docstring class description Cleber Rosa
2019-10-11 11:27 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011112530.GE5158@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=crosa@redhat.com \
--cc=laurent@vivier.eu \
--cc=mjt@tls.msk.ru \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).