From: David Gibson <david@gibson.dropbear.id.au>
To: Wei Yang <richardw.yang@linux.intel.com>
Cc: fam@euphon.net, mst@redhat.com, mark.cave-ayland@ilande.co.uk,
qemu-devel@nongnu.org, kraxel@redhat.com, den@openvz.org,
qemu-block@nongnu.org, quintela@redhat.com, armbru@redhat.com,
pasic@linux.ibm.com, borntraeger@de.ibm.com,
marcandre.lureau@redhat.com, ehabkost@redhat.com, sw@weilnetz.de,
dgilbert@redhat.com, yuval.shaia@oracle.com,
alex.williamson@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, rth@twiddle.net, kwolf@redhat.com,
cohuck@redhat.com, qemu-s390x@nongnu.org, mreitz@redhat.com,
qemu-ppc@nongnu.org, imammedo@redhat.com
Subject: Re: [PATCH 2/2] core: replace getpagesize() with qemu_real_host_page_size
Date: Sun, 13 Oct 2019 20:28:41 +1100 [thread overview]
Message-ID: <20191013092841.GG4080@umbus.fritz.box> (raw)
In-Reply-To: <20191013021145.16011-3-richardw.yang@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 940 bytes --]
On Sun, Oct 13, 2019 at 10:11:45AM +0800, Wei Yang wrote:
> There are three page size in qemu:
>
> real host page size
> host page size
> target page size
>
> All of them have dedicate variable to represent. For the last two, we
> use the same form in the whole qemu project, while for the first one we
> use two forms: qemu_real_host_page_size and getpagesize().
>
> qemu_real_host_page_size is defined to be a replacement of
> getpagesize(), so let it serve the role.
>
> [Note] Not fully tested for some arch or device.
>
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Although the chances of someone messing this up again are almost 100%.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-10-13 9:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-13 2:11 [PATCH 0/2] cleanup on page size Wei Yang
2019-10-13 2:11 ` [PATCH 1/2] cpu: use ROUND_UP() to define xxx_PAGE_ALIGN Wei Yang
2019-10-13 6:34 ` Michael S. Tsirkin
2019-10-13 9:27 ` David Gibson
2019-10-13 15:56 ` Richard Henderson
2019-10-13 23:36 ` David Gibson
2019-10-14 1:01 ` Wei Yang
2019-10-14 2:38 ` Richard Henderson
2019-10-14 3:19 ` Wei Yang
2019-10-14 16:25 ` Juan Quintela
2019-10-13 2:11 ` [PATCH 2/2] core: replace getpagesize() with qemu_real_host_page_size Wei Yang
2019-10-13 6:35 ` Michael S. Tsirkin
2019-10-13 9:28 ` David Gibson [this message]
2019-10-16 1:25 ` Wei Yang
2019-10-13 16:03 ` Richard Henderson
2019-10-14 9:15 ` Dr. David Alan Gilbert
2019-10-14 21:36 ` Wei Yang
2019-10-14 23:12 ` Richard Henderson
2019-10-15 11:45 ` Yuval Shaia
2019-10-16 1:07 ` Wei Yang
2019-10-23 9:19 ` Paolo Bonzini
2019-10-13 6:36 ` [PATCH 0/2] cleanup on page size Michael S. Tsirkin
2019-10-14 21:59 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191013092841.GG4080@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=alex.williamson@redhat.com \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=imammedo@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=richardw.yang@linux.intel.com \
--cc=rth@twiddle.net \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).