* [PULL 0/1] Block patches
@ 2019-10-14 8:52 Stefan Hajnoczi
2019-10-14 8:52 ` [PULL 1/1] test-bdrv-drain: fix iothread_join() hang Stefan Hajnoczi
2019-10-15 11:00 ` [PULL 0/1] Block patches Peter Maydell
0 siblings, 2 replies; 39+ messages in thread
From: Stefan Hajnoczi @ 2019-10-14 8:52 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, qemu-block, Michael S. Tsirkin,
Max Reitz, Stefan Hajnoczi, Kevin Wolf
The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 69de48445a0d6169f1e2a6c5bfab994e1c810e33:
test-bdrv-drain: fix iothread_join() hang (2019-10-14 09:48:01 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Stefan Hajnoczi (1):
test-bdrv-drain: fix iothread_join() hang
tests/iothread.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 1/1] test-bdrv-drain: fix iothread_join() hang
2019-10-14 8:52 [PULL 0/1] Block patches Stefan Hajnoczi
@ 2019-10-14 8:52 ` Stefan Hajnoczi
2019-10-14 11:11 ` Paolo Bonzini
2019-10-15 11:00 ` [PULL 0/1] Block patches Peter Maydell
1 sibling, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2019-10-14 8:52 UTC (permalink / raw)
To: qemu-devel
Cc: Fam Zheng, Peter Maydell, qemu-block, Michael S. Tsirkin,
Dr . David Alan Gilbert, Max Reitz, Stefan Hajnoczi,
Paolo Bonzini, Kevin Wolf
tests/test-bdrv-drain can hang in tests/iothread.c:iothread_run():
while (!atomic_read(&iothread->stopping)) {
aio_poll(iothread->ctx, true);
}
The iothread_join() function works as follows:
void iothread_join(IOThread *iothread)
{
iothread->stopping = true;
aio_notify(iothread->ctx);
qemu_thread_join(&iothread->thread);
If iothread_run() checks iothread->stopping before the iothread_join()
thread sets stopping to true, then aio_notify() may be optimized away
and iothread_run() hangs forever in aio_poll().
The correct way to change iothread->stopping is from a BH that executes
within iothread_run(). This ensures that iothread->stopping is checked
after we set it to true.
This was already fixed for ./iothread.c (note this is a different source
file!) by commit 2362a28ea11c145e1a13ae79342d76dc118a72a6 ("iothread:
fix iothread_stop() race condition"), but not for tests/iothread.c.
Fixes: 0c330a734b51c177ab8488932ac3b0c4d63a718a
("aio: introduce aio_co_schedule and aio_co_wake")
Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20191003100103.331-1-stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/iothread.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/iothread.c b/tests/iothread.c
index 777d9eea46..13c9fdcd8d 100644
--- a/tests/iothread.c
+++ b/tests/iothread.c
@@ -55,10 +55,16 @@ static void *iothread_run(void *opaque)
return NULL;
}
-void iothread_join(IOThread *iothread)
+static void iothread_stop_bh(void *opaque)
{
+ IOThread *iothread = opaque;
+
iothread->stopping = true;
- aio_notify(iothread->ctx);
+}
+
+void iothread_join(IOThread *iothread)
+{
+ aio_bh_schedule_oneshot(iothread->ctx, iothread_stop_bh, iothread);
qemu_thread_join(&iothread->thread);
qemu_cond_destroy(&iothread->init_done_cond);
qemu_mutex_destroy(&iothread->init_done_lock);
--
2.21.0
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [PULL 1/1] test-bdrv-drain: fix iothread_join() hang
2019-10-14 8:52 ` [PULL 1/1] test-bdrv-drain: fix iothread_join() hang Stefan Hajnoczi
@ 2019-10-14 11:11 ` Paolo Bonzini
2019-10-15 8:50 ` Stefan Hajnoczi
0 siblings, 1 reply; 39+ messages in thread
From: Paolo Bonzini @ 2019-10-14 11:11 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Fam Zheng, Peter Maydell, qemu-block, Michael S. Tsirkin,
Dr . David Alan Gilbert, Max Reitz, Kevin Wolf
On 14/10/19 10:52, Stefan Hajnoczi wrote:
> tests/test-bdrv-drain can hang in tests/iothread.c:iothread_run():
>
> while (!atomic_read(&iothread->stopping)) {
> aio_poll(iothread->ctx, true);
> }
>
> The iothread_join() function works as follows:
>
> void iothread_join(IOThread *iothread)
> {
> iothread->stopping = true;
> aio_notify(iothread->ctx);
> qemu_thread_join(&iothread->thread);
>
> If iothread_run() checks iothread->stopping before the iothread_join()
> thread sets stopping to true, then aio_notify() may be optimized away
> and iothread_run() hangs forever in aio_poll().
>
> The correct way to change iothread->stopping is from a BH that executes
> within iothread_run(). This ensures that iothread->stopping is checked
> after we set it to true.
>
> This was already fixed for ./iothread.c (note this is a different source
> file!) by commit 2362a28ea11c145e1a13ae79342d76dc118a72a6 ("iothread:
> fix iothread_stop() race condition"), but not for tests/iothread.c.
Aha, I did have some kind of dejavu when sending the patch I have just
sent; let's see if this also fixes the test-aio-multithread assertion
failure.
Note that with this change the atomic read of iothread->stopping can go
away; I can send a separate patch later.
Paolo
> Fixes: 0c330a734b51c177ab8488932ac3b0c4d63a718a
> ("aio: introduce aio_co_schedule and aio_co_wake")
> Reported-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
> Message-Id: <20191003100103.331-1-stefanha@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> tests/iothread.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/iothread.c b/tests/iothread.c
> index 777d9eea46..13c9fdcd8d 100644
> --- a/tests/iothread.c
> +++ b/tests/iothread.c
> @@ -55,10 +55,16 @@ static void *iothread_run(void *opaque)
> return NULL;
> }
>
> -void iothread_join(IOThread *iothread)
> +static void iothread_stop_bh(void *opaque)
> {
> + IOThread *iothread = opaque;
> +
> iothread->stopping = true;
> - aio_notify(iothread->ctx);
> +}
> +
> +void iothread_join(IOThread *iothread)
> +{
> + aio_bh_schedule_oneshot(iothread->ctx, iothread_stop_bh, iothread);
> qemu_thread_join(&iothread->thread);
> qemu_cond_destroy(&iothread->init_done_cond);
> qemu_mutex_destroy(&iothread->init_done_lock);
>
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PULL 1/1] test-bdrv-drain: fix iothread_join() hang
2019-10-14 11:11 ` Paolo Bonzini
@ 2019-10-15 8:50 ` Stefan Hajnoczi
0 siblings, 0 replies; 39+ messages in thread
From: Stefan Hajnoczi @ 2019-10-15 8:50 UTC (permalink / raw)
To: Paolo Bonzini
Cc: Fam Zheng, Peter Maydell, qemu-block, Michael S. Tsirkin,
qemu-devel, Max Reitz, Kevin Wolf, Dr . David Alan Gilbert
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
On Mon, Oct 14, 2019 at 01:11:41PM +0200, Paolo Bonzini wrote:
> On 14/10/19 10:52, Stefan Hajnoczi wrote:
> > tests/test-bdrv-drain can hang in tests/iothread.c:iothread_run():
> >
> > while (!atomic_read(&iothread->stopping)) {
> > aio_poll(iothread->ctx, true);
> > }
> >
> > The iothread_join() function works as follows:
> >
> > void iothread_join(IOThread *iothread)
> > {
> > iothread->stopping = true;
> > aio_notify(iothread->ctx);
> > qemu_thread_join(&iothread->thread);
> >
> > If iothread_run() checks iothread->stopping before the iothread_join()
> > thread sets stopping to true, then aio_notify() may be optimized away
> > and iothread_run() hangs forever in aio_poll().
> >
> > The correct way to change iothread->stopping is from a BH that executes
> > within iothread_run(). This ensures that iothread->stopping is checked
> > after we set it to true.
> >
> > This was already fixed for ./iothread.c (note this is a different source
> > file!) by commit 2362a28ea11c145e1a13ae79342d76dc118a72a6 ("iothread:
> > fix iothread_stop() race condition"), but not for tests/iothread.c.
>
> Aha, I did have some kind of dejavu when sending the patch I have just
> sent; let's see if this also fixes the test-aio-multithread assertion
> failure.
>
> Note that with this change the atomic read of iothread->stopping can go
> away; I can send a separate patch later.
Yes, I thought about the atomic_read() later as well.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2019-10-14 8:52 [PULL 0/1] Block patches Stefan Hajnoczi
2019-10-14 8:52 ` [PULL 1/1] test-bdrv-drain: fix iothread_join() hang Stefan Hajnoczi
@ 2019-10-15 11:00 ` Peter Maydell
1 sibling, 0 replies; 39+ messages in thread
From: Peter Maydell @ 2019-10-15 11:00 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, Qemu-block, Michael S. Tsirkin,
QEMU Developers, Max Reitz
On Mon, 14 Oct 2019 at 09:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 98b2e3c9ab3abfe476a2b02f8f51813edb90e72d:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging (2019-10-08 16:08:35 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 69de48445a0d6169f1e2a6c5bfab994e1c810e33:
>
> test-bdrv-drain: fix iothread_join() hang (2019-10-14 09:48:01 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> test-bdrv-drain: fix iothread_join() hang
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2020-01-14 9:30 Stefan Hajnoczi
2020-01-14 16:00 ` Peter Maydell
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2020-01-14 9:30 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, Stefan Hajnoczi, qemu-block, Max Reitz
The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 2558cb8dd4150512bc8ae6d505cdcd10d0cc46bb:
linux-aio: increasing MAX_EVENTS to a larger hardcoded value (2020-01-13 16:41:45 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Wangyong (1):
linux-aio: increasing MAX_EVENTS to a larger hardcoded value
block/linux-aio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.24.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2020-01-14 9:30 Stefan Hajnoczi
@ 2020-01-14 16:00 ` Peter Maydell
0 siblings, 0 replies; 39+ messages in thread
From: Peter Maydell @ 2020-01-14 16:00 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Kevin Wolf, QEMU Developers, Qemu-block, Max Reitz
On Tue, 14 Jan 2020 at 09:31, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit dc65a5bdc9fa543690a775b50d4ffbeb22c56d6d:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-5.0-20200108' into staging (2020-01-10 16:15:04 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 2558cb8dd4150512bc8ae6d505cdcd10d0cc46bb:
>
> linux-aio: increasing MAX_EVENTS to a larger hardcoded value (2020-01-13 16:41:45 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Wangyong (1):
> linux-aio: increasing MAX_EVENTS to a larger hardcoded value
>
> block/linux-aio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2020-03-17 15:18 Stefan Hajnoczi
2020-03-17 18:32 ` Peter Maydell
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2020-03-17 15:18 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Fam Zheng, qemu-block, Peter Maydell, Max Reitz,
Stefan Hajnoczi
The following changes since commit 61c265f0660ee476985808c8aa7915617c44fd53:
Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200313a' into staging (2020-03-13 10:33:04 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 4ab78b19189a81038e744728ed949d09aa477550:
block/io: fix bdrv_co_do_copy_on_readv (2020-03-16 11:46:11 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Vladimir Sementsov-Ogievskiy (1):
block/io: fix bdrv_co_do_copy_on_readv
block/io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.24.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2020-03-17 15:18 Stefan Hajnoczi
@ 2020-03-17 18:32 ` Peter Maydell
0 siblings, 0 replies; 39+ messages in thread
From: Peter Maydell @ 2020-03-17 18:32 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Fam Zheng, QEMU Developers, Qemu-block, Max Reitz
On Tue, 17 Mar 2020 at 15:18, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 61c265f0660ee476985808c8aa7915617c44fd53:
>
> Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20200313a' into staging (2020-03-13 10:33:04 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 4ab78b19189a81038e744728ed949d09aa477550:
>
> block/io: fix bdrv_co_do_copy_on_readv (2020-03-16 11:46:11 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2021-01-04 14:23 Stefan Hajnoczi
2021-01-04 17:17 ` Peter Maydell
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-01-04 14:23 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: Stefan Hajnoczi, qemu-block
The following changes since commit 41192db338588051f21501abc13743e62b0a5605:
Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 593621f36b716eb091c4ec791db72dd4461789da:
readline: Fix possible array index out of bounds in readline_hist_add() (2021-01-04 11:13:39 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Alex Chen (1):
readline: Fix possible array index out of bounds in
readline_hist_add()
util/readline.c | 3 +++
1 file changed, 3 insertions(+)
--
2.29.2
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PULL 0/1] Block patches
2021-01-04 14:23 Stefan Hajnoczi
@ 2021-01-04 17:17 ` Peter Maydell
0 siblings, 0 replies; 39+ messages in thread
From: Peter Maydell @ 2021-01-04 17:17 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: QEMU Developers, Qemu-block
On Mon, 4 Jan 2021 at 14:23, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 41192db338588051f21501abc13743e62b0a5605:
>
> Merge remote-tracking branch 'remotes/ehabkost-gl/tags/machine-next-pull-request' into staging (2021-01-01 22:57:15 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 593621f36b716eb091c4ec791db72dd4461789da:
>
> readline: Fix possible array index out of bounds in readline_hist_add() (2021-01-04 11:13:39 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2021-03-15 9:51 Stefan Hajnoczi
2021-03-15 22:01 ` Peter Maydell
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-03-15 9:51 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: Kevin Wolf, Eduardo Habkost, qemu-block, Michael S. Tsirkin,
Max Reitz, Stefan Hajnoczi
The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
request' into staging (2021-03-14 17:47:49 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to fb0b154c801e3447e505de420195fb7038695941:
virtio-blk: Respect discard granularity (2021-03-15 09:48:53 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Akihiko Odaki (1):
virtio-blk: Respect discard granularity
include/hw/virtio/virtio-blk.h | 1 +
hw/block/virtio-blk.c | 8 +++++++-
hw/core/machine.c | 1 +
3 files changed, 9 insertions(+), 1 deletion(-)
--=20
2.29.2
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-03-15 9:51 Stefan Hajnoczi
@ 2021-03-15 22:01 ` Peter Maydell
0 siblings, 0 replies; 39+ messages in thread
From: Peter Maydell @ 2021-03-15 22:01 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Eduardo Habkost, Qemu-block, Michael S. Tsirkin,
QEMU Developers, Max Reitz
On Mon, 15 Mar 2021 at 09:51, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 6157b0e19721aadb4c7fdcfe57b2924af6144b14:
>
> Merge remote-tracking branch 'remotes/vivier2/tags/linux-user-for-6.0-pull-=
> request' into staging (2021-03-14 17:47:49 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to fb0b154c801e3447e505de420195fb7038695941:
>
> virtio-blk: Respect discard granularity (2021-03-15 09:48:53 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2021-10-21 17:41 Stefan Hajnoczi
2021-10-21 22:08 ` Richard Henderson
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-10-21 17:41 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, Stefan Hajnoczi, qemu-block
The following changes since commit afc9fcde55296b83f659de9da3cdf044812a6eeb:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-10-20 06:10:51 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 4b2b3d2653f255ef4259a7689af1956536565901:
coroutine: resize pool periodically instead of limiting size (2021-10-21 18:40:07 +0100)
----------------------------------------------------------------
Pull request
Performance optimization when guest applications submit a lot of parallel I/O.
This has also been found to improve clang SafeStack performance.
----------------------------------------------------------------
Stefan Hajnoczi (1):
coroutine: resize pool periodically instead of limiting size
include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++
include/qemu/coroutine.h | 7 ++++
iothread.c | 6 +++
util/coroutine-pool-timer.c | 35 ++++++++++++++++
util/main-loop.c | 5 +++
util/qemu-coroutine.c | 64 ++++++++++++++++-------------
util/meson.build | 1 +
7 files changed, 125 insertions(+), 29 deletions(-)
create mode 100644 include/qemu/coroutine-pool-timer.h
create mode 100644 util/coroutine-pool-timer.c
--
2.31.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-10-21 17:41 Stefan Hajnoczi
@ 2021-10-21 22:08 ` Richard Henderson
2021-10-25 10:10 ` Stefan Hajnoczi
0 siblings, 1 reply; 39+ messages in thread
From: Richard Henderson @ 2021-10-21 22:08 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, qemu-block
On 10/21/21 10:41 AM, Stefan Hajnoczi wrote:
> The following changes since commit afc9fcde55296b83f659de9da3cdf044812a6eeb:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-10-20 06:10:51 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 4b2b3d2653f255ef4259a7689af1956536565901:
>
> coroutine: resize pool periodically instead of limiting size (2021-10-21 18:40:07 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> Performance optimization when guest applications submit a lot of parallel I/O.
> This has also been found to improve clang SafeStack performance.
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> coroutine: resize pool periodically instead of limiting size
>
> include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++
> include/qemu/coroutine.h | 7 ++++
> iothread.c | 6 +++
> util/coroutine-pool-timer.c | 35 ++++++++++++++++
> util/main-loop.c | 5 +++
> util/qemu-coroutine.c | 64 ++++++++++++++++-------------
> util/meson.build | 1 +
> 7 files changed, 125 insertions(+), 29 deletions(-)
> create mode 100644 include/qemu/coroutine-pool-timer.h
> create mode 100644 util/coroutine-pool-timer.c
This is causing
(001/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg: INTERRUPTED:
Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal status:
ERROR\n{'name': '001-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg',
'logdir': '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
(900.15 s)
(002/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm: INTERRUPTED:
Test interrupted by SIGTERM\nRunner error occurred: Timeout reached\nOriginal status:
ERROR\n{'name': '002-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm',
'logdir': '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
(900.23 s)
I initially though this was just gitlab, but it reliably happens on my local machine as well.
r~
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [PULL 0/1] Block patches
2021-10-21 22:08 ` Richard Henderson
@ 2021-10-25 10:10 ` Stefan Hajnoczi
0 siblings, 0 replies; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-10-25 10:10 UTC (permalink / raw)
To: Richard Henderson
Cc: Kevin Wolf, Peter Maydell, qemu-devel, qemu-block, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 2854 bytes --]
On Thu, Oct 21, 2021 at 03:08:56PM -0700, Richard Henderson wrote:
> On 10/21/21 10:41 AM, Stefan Hajnoczi wrote:
> > The following changes since commit afc9fcde55296b83f659de9da3cdf044812a6eeb:
> >
> > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2021-10-20 06:10:51 -0700)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to 4b2b3d2653f255ef4259a7689af1956536565901:
> >
> > coroutine: resize pool periodically instead of limiting size (2021-10-21 18:40:07 +0100)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > Performance optimization when guest applications submit a lot of parallel I/O.
> > This has also been found to improve clang SafeStack performance.
> >
> > ----------------------------------------------------------------
> >
> > Stefan Hajnoczi (1):
> > coroutine: resize pool periodically instead of limiting size
> >
> > include/qemu/coroutine-pool-timer.h | 36 ++++++++++++++++
> > include/qemu/coroutine.h | 7 ++++
> > iothread.c | 6 +++
> > util/coroutine-pool-timer.c | 35 ++++++++++++++++
> > util/main-loop.c | 5 +++
> > util/qemu-coroutine.c | 64 ++++++++++++++++-------------
> > util/meson.build | 1 +
> > 7 files changed, 125 insertions(+), 29 deletions(-)
> > create mode 100644 include/qemu/coroutine-pool-timer.h
> > create mode 100644 util/coroutine-pool-timer.c
>
> This is causing
>
> (001/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg:
> INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout
> reached\nOriginal status: ERROR\n{'name':
> '001-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_tcg',
> 'logdir':
> '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
> (900.15 s)
> (002/170) tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm:
> INTERRUPTED: Test interrupted by SIGTERM\nRunner error occurred: Timeout
> reached\nOriginal status: ERROR\n{'name':
> '002-tests/acceptance/boot_linux.py:BootLinuxX8664.test_pc_i440fx_kvm',
> 'logdir':
> '/home/richard.henderson/qemu/bld/tests/results/job-2021-10-21T20.58-ae0f6...
> (900.23 s)
>
> I initially though this was just gitlab, but it reliably happens on my local machine as well.
Thanks, the coroutine pool timer commit in this pull request is broken.
Coroutines are created in one thread and then destroyed in another, so
the thread-local book keeping that assumed coroutines live in a single
thread was getting out of sync.
I will drop this pull request for now.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2021-12-06 15:27 Stefan Hajnoczi
2021-12-06 21:16 ` Richard Henderson
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-12-06 15:27 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, Hanna Reitz, Stefan Hajnoczi, qemu-block
The following changes since commit 99fc08366b06282614daeda989d2fde6ab8a707f:
Merge tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu into staging (2021-12-03 05:26:40 -0800)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 5b807181c27a940a3a7ad1f221a2e76a132cbdc0:
virtio-blk: Fix clean up of host notifiers for single MR transaction. (2021-12-06 14:21:14 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Mark Mielke (1):
virtio-blk: Fix clean up of host notifiers for single MR transaction.
hw/block/dataplane/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.33.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-06 15:27 Stefan Hajnoczi
@ 2021-12-06 21:16 ` Richard Henderson
0 siblings, 0 replies; 39+ messages in thread
From: Richard Henderson @ 2021-12-06 21:16 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell, qemu-devel
Cc: Kevin Wolf, Paolo Bonzini, Hanna Reitz, qemu-block
On 12/6/21 7:27 AM, Stefan Hajnoczi wrote:
> The following changes since commit 99fc08366b06282614daeda989d2fde6ab8a707f:
>
> Merge tag 'seabios-20211203-pull-request' of git://git.kraxel.org/qemu into staging (2021-12-03 05:26:40 -0800)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 5b807181c27a940a3a7ad1f221a2e76a132cbdc0:
>
> virtio-blk: Fix clean up of host notifiers for single MR transaction. (2021-12-06 14:21:14 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Mark Mielke (1):
> virtio-blk: Fix clean up of host notifiers for single MR transaction.
>
> hw/block/dataplane/virtio-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2021-12-09 15:21 Stefan Hajnoczi
2021-12-09 15:46 ` Peter Maydell
2021-12-14 22:31 ` Richard Henderson
0 siblings, 2 replies; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-12-09 15:21 UTC (permalink / raw)
To: qemu-devel, Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, Hanna Reitz, Stefan Hajnoczi,
Paolo Bonzini, Philippe Mathieu-Daudé
The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
----------------------------------------------------------------
Pull request
An infinite loop fix for the userspace NVMe driver.
----------------------------------------------------------------
Stefan Hajnoczi (1):
block/nvme: fix infinite loop in nvme_free_req_queue_cb()
block/nvme.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
--
2.33.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 15:21 Stefan Hajnoczi
@ 2021-12-09 15:46 ` Peter Maydell
2021-12-09 16:34 ` Stefan Hajnoczi
2021-12-14 22:31 ` Richard Henderson
1 sibling, 1 reply; 39+ messages in thread
From: Peter Maydell @ 2021-12-09 15:46 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, qemu-block, Richard Henderson, qemu-devel,
Hanna Reitz, Paolo Bonzini, Philippe Mathieu-Daudé
On Thu, 9 Dec 2021 at 15:21, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
>
> Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
>
> block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> An infinite loop fix for the userspace NVMe driver.
>
> ----------------------------------------------------------------
I'm not running the release cycle this time around, but: it's
already rc4, pull requests by this point need a clear justification
in the cover letter for why they're really release critical.
-- PMM
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 15:46 ` Peter Maydell
@ 2021-12-09 16:34 ` Stefan Hajnoczi
2021-12-09 16:53 ` Richard Henderson
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-12-09 16:34 UTC (permalink / raw)
To: Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, Richard Henderson, qemu-devel,
Hanna Reitz, Paolo Bonzini, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]
On Thu, Dec 09, 2021 at 03:46:29PM +0000, Peter Maydell wrote:
> On Thu, 9 Dec 2021 at 15:21, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
> >
> > Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
> >
> > are available in the Git repository at:
> >
> > https://gitlab.com/stefanha/qemu.git tags/block-pull-request
> >
> > for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
> >
> > block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
> >
> > ----------------------------------------------------------------
> > Pull request
> >
> > An infinite loop fix for the userspace NVMe driver.
> >
> > ----------------------------------------------------------------
>
> I'm not running the release cycle this time around, but: it's
> already rc4, pull requests by this point need a clear justification
> in the cover letter for why they're really release critical.
It's late, this isn't a show-stopper (block/nvme.c is not widely used).
Let's leave it for the next release cycle and -stable.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 16:34 ` Stefan Hajnoczi
@ 2021-12-09 16:53 ` Richard Henderson
2021-12-13 9:33 ` Stefan Hajnoczi
0 siblings, 1 reply; 39+ messages in thread
From: Richard Henderson @ 2021-12-09 16:53 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, qemu-devel, Hanna Reitz,
Paolo Bonzini, Philippe Mathieu-Daudé
On 12/9/21 8:34 AM, Stefan Hajnoczi wrote:
>> I'm not running the release cycle this time around, but: it's
>> already rc4, pull requests by this point need a clear justification
>> in the cover letter for why they're really release critical.
>
> It's late, this isn't a show-stopper (block/nvme.c is not widely used).
> Let's leave it for the next release cycle and -stable.
Good.
Unless you want to re-issue with Cc: qemu-stable included in the patch, this can be the
first PR of the next devel cycle, since it's already here. :-)
r~
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 16:53 ` Richard Henderson
@ 2021-12-13 9:33 ` Stefan Hajnoczi
0 siblings, 0 replies; 39+ messages in thread
From: Stefan Hajnoczi @ 2021-12-13 9:33 UTC (permalink / raw)
To: Richard Henderson
Cc: Fam Zheng, Peter Maydell, qemu-block, qemu-devel, Hanna Reitz,
Kevin Wolf, Paolo Bonzini, Philippe Mathieu-Daudé
[-- Attachment #1: Type: text/plain, Size: 755 bytes --]
On Thu, Dec 09, 2021 at 08:53:25AM -0800, Richard Henderson wrote:
> On 12/9/21 8:34 AM, Stefan Hajnoczi wrote:
> > > I'm not running the release cycle this time around, but: it's
> > > already rc4, pull requests by this point need a clear justification
> > > in the cover letter for why they're really release critical.
> >
> > It's late, this isn't a show-stopper (block/nvme.c is not widely used).
> > Let's leave it for the next release cycle and -stable.
>
> Good.
>
> Unless you want to re-issue with Cc: qemu-stable included in the patch, this
> can be the first PR of the next devel cycle, since it's already here. :-)
Thank you! qemu-stable can merge it separately. I won't add a Cc: tag to
the commit description.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2021-12-09 15:21 Stefan Hajnoczi
2021-12-09 15:46 ` Peter Maydell
@ 2021-12-14 22:31 ` Richard Henderson
1 sibling, 0 replies; 39+ messages in thread
From: Richard Henderson @ 2021-12-14 22:31 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel, Peter Maydell
Cc: Fam Zheng, Kevin Wolf, qemu-block, Hanna Reitz, Paolo Bonzini,
Philippe Mathieu-Daudé
On 12/9/21 7:21 AM, Stefan Hajnoczi wrote:
> The following changes since commit a3607def89f9cd68c1b994e1030527df33aa91d0:
>
> Update version for v6.2.0-rc4 release (2021-12-07 17:51:38 -0800)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to cf4fbc3030c974fff726756a7ceef8386cdf500b:
>
> block/nvme: fix infinite loop in nvme_free_req_queue_cb() (2021-12-09 09:19:49 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> An infinite loop fix for the userspace NVMe driver.
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> block/nvme: fix infinite loop in nvme_free_req_queue_cb()
>
> block/nvme.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions
Applied, as the beginning of the 7.0 development tree.
r~
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2022-05-25 12:49 Stefan Hajnoczi
2022-05-25 18:35 ` Richard Henderson
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2022-05-25 12:49 UTC (permalink / raw)
To: qemu-devel
Cc: Dr. David Alan Gilbert, Richard Henderson, Stefan Hajnoczi,
virtio-fs, qemu-block
The following changes since commit 0cac736e73723850a99e5142e35d14d8f8efb232:
Merge tag 'pull-riscv-to-apply-20220525' of github.com:alistair23/qemu into staging (2022-05-24 15:55:12 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 29320530cf6684646b3a642fdbb5bc77ee8039de:
docs: Correct the default thread-pool-size (2022-05-25 11:01:38 +0100)
----------------------------------------------------------------
Pull request
A small documentation fix.
----------------------------------------------------------------
Liu Yiding (1):
docs: Correct the default thread-pool-size
docs/tools/virtiofsd.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.36.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2022-05-25 12:49 Stefan Hajnoczi
@ 2022-05-25 18:35 ` Richard Henderson
0 siblings, 0 replies; 39+ messages in thread
From: Richard Henderson @ 2022-05-25 18:35 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel; +Cc: Dr. David Alan Gilbert, virtio-fs, qemu-block
On 5/25/22 05:49, Stefan Hajnoczi wrote:
> The following changes since commit 0cac736e73723850a99e5142e35d14d8f8efb232:
>
> Merge tag 'pull-riscv-to-apply-20220525' of github.com:alistair23/qemu into staging (2022-05-24 15:55:12 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 29320530cf6684646b3a642fdbb5bc77ee8039de:
>
> docs: Correct the default thread-pool-size (2022-05-25 11:01:38 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> A small documentation fix.
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate.
r~
>
> ----------------------------------------------------------------
>
> Liu Yiding (1):
> docs: Correct the default thread-pool-size
>
> docs/tools/virtiofsd.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2022-09-22 17:14 Stefan Hajnoczi
2022-09-27 15:04 ` Stefan Hajnoczi
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2022-09-22 17:14 UTC (permalink / raw)
To: qemu-devel; +Cc: Stefan Hajnoczi, qemu-block, Dr. David Alan Gilbert, virtio-fs
The following changes since commit 6338c30111d596d955e6bc933a82184a0b910c43:
Merge tag 'm68k-for-7.2-pull-request' of https://github.com/vivier/qemu-m68k into staging (2022-09-21 13:12:36 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to f16d15c9276bd8f501f861c39cbd4adc812d0c1d:
virtiofsd: use g_date_time_get_microsecond to get subsecond (2022-09-22 13:13:47 -0400)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Yusuke Okada (1):
virtiofsd: use g_date_time_get_microsecond to get subsecond
tools/virtiofsd/passthrough_ll.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
--
2.37.3
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2023-07-04 15:29 Stefan Hajnoczi
2023-07-06 6:04 ` Richard Henderson
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2023-07-04 15:29 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Stefan Hajnoczi, Hanna Reitz, qemu-block, Richard Henderson
The following changes since commit d145c0da22cde391d8c6672d33146ce306e8bf75:
Merge tag 'pull-tcg-20230701' of https://gitlab.com/rth7680/qemu into staging (2023-07-01 08:55:37 +0200)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to c21eae1ccc782440f320accb6f90c66cb8f45ee9:
block/blkio: fix module_block.py parsing (2023-07-04 17:28:25 +0200)
----------------------------------------------------------------
Pull request
Fix --enable-modules with the blkio block driver.
----------------------------------------------------------------
Stefan Hajnoczi (1):
block/blkio: fix module_block.py parsing
block/blkio.c | 108 ++++++++++++++++++++++++++------------------------
1 file changed, 56 insertions(+), 52 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2023-07-04 15:29 Stefan Hajnoczi
@ 2023-07-06 6:04 ` Richard Henderson
0 siblings, 0 replies; 39+ messages in thread
From: Richard Henderson @ 2023-07-06 6:04 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, Hanna Reitz, qemu-block, Richard Henderson
On 7/4/23 16:29, Stefan Hajnoczi wrote:
> The following changes since commit d145c0da22cde391d8c6672d33146ce306e8bf75:
>
> Merge tag 'pull-tcg-20230701' ofhttps://gitlab.com/rth7680/qemu into staging (2023-07-01 08:55:37 +0200)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to c21eae1ccc782440f320accb6f90c66cb8f45ee9:
>
> block/blkio: fix module_block.py parsing (2023-07-04 17:28:25 +0200)
>
> ----------------------------------------------------------------
> Pull request
>
> Fix --enable-modules with the blkio block driver.
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.
r~
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2023-07-12 19:36 Stefan Hajnoczi
2023-07-14 6:35 ` Richard Henderson
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2023-07-12 19:36 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, qemu-block, Hanna Reitz, Stefan Hajnoczi, Richard Henderson
The following changes since commit 887cba855bb6ff4775256f7968409281350b568c:
configure: Fix cross-building for RISCV host (v5) (2023-07-11 17:56:09 +0100)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 75dcb4d790bbe5327169fd72b185960ca58e2fa6:
virtio-blk: fix host notifier issues during dataplane start/stop (2023-07-12 15:20:32 -0400)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Stefan Hajnoczi (1):
virtio-blk: fix host notifier issues during dataplane start/stop
hw/block/dataplane/virtio-blk.c | 67 +++++++++++++++++++--------------
1 file changed, 38 insertions(+), 29 deletions(-)
--
2.40.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2023-07-12 19:36 Stefan Hajnoczi
@ 2023-07-14 6:35 ` Richard Henderson
0 siblings, 0 replies; 39+ messages in thread
From: Richard Henderson @ 2023-07-14 6:35 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, qemu-block, Hanna Reitz, Richard Henderson
On 7/12/23 20:36, Stefan Hajnoczi wrote:
> The following changes since commit 887cba855bb6ff4775256f7968409281350b568c:
>
> configure: Fix cross-building for RISCV host (v5) (2023-07-11 17:56:09 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 75dcb4d790bbe5327169fd72b185960ca58e2fa6:
>
> virtio-blk: fix host notifier issues during dataplane start/stop (2023-07-12 15:20:32 -0400)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> virtio-blk: fix host notifier issues during dataplane start/stop
>
> hw/block/dataplane/virtio-blk.c | 67 +++++++++++++++++++--------------
> 1 file changed, 38 insertions(+), 29 deletions(-)
>
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.
r~
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2023-10-04 13:53 Stefan Hajnoczi
2023-10-04 18:33 ` Stefan Hajnoczi
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2023-10-04 13:53 UTC (permalink / raw)
To: qemu-devel
Cc: Stefan Hajnoczi, Thomas Huth, Daniel P. Berrangé,
qemu-block, Philippe Mathieu-Daudé,
Marc-André Lureau, Kevin Wolf, Paolo Bonzini
The following changes since commit da1034094d375afe9e3d8ec8980550ea0f06f7e0:
Merge tag 'for-upstream' of https://gitlab.com/bonzini/qemu into staging (2023-10-03 07:43:44 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 9afa888ce0f816d0f2cfc95eebe4f49244c518af:
osdep: set _FORTIFY_SOURCE=2 when optimization is enabled (2023-10-04 09:52:06 -0400)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Daniel P. Berrangé (1):
osdep: set _FORTIFY_SOURCE=2 when optimization is enabled
meson.build | 10 ----------
include/qemu/osdep.h | 4 ++++
util/coroutine-sigaltstack.c | 4 ++--
util/coroutine-ucontext.c | 4 ++--
4 files changed, 8 insertions(+), 14 deletions(-)
--
2.41.0
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2023-10-04 13:53 Stefan Hajnoczi
@ 2023-10-04 18:33 ` Stefan Hajnoczi
0 siblings, 0 replies; 39+ messages in thread
From: Stefan Hajnoczi @ 2023-10-04 18:33 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Stefan Hajnoczi, Thomas Huth, Daniel P. Berrangé,
qemu-block, Philippe Mathieu-Daudé,
Marc-André Lureau, Kevin Wolf, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 115 bytes --]
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2023-10-16 19:40 Stefan Hajnoczi
0 siblings, 0 replies; 39+ messages in thread
From: Stefan Hajnoczi @ 2023-10-16 19:40 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Michael S. Tsirkin, qemu-block, Stefan Hajnoczi, Hanna Reitz
The following changes since commit 63011373ad22c794a013da69663c03f1297a5c56:
Merge tag 'pull-riscv-to-apply-20231012-1' of https://github.com/alistair23/qemu into staging (2023-10-12 10:24:44 -0400)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 071d6d107db2e26dde9bb15457c74956c88ec5b4:
virtio-blk: don't start dataplane during the stop of dataplane (2023-10-16 15:39:13 -0400)
----------------------------------------------------------------
Pull request
Contains a virtio-blk IOThread fix.
----------------------------------------------------------------
hujian (1):
virtio-blk: don't start dataplane during the stop of dataplane
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.41.0
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2024-02-06 15:31 Stefan Hajnoczi
2024-02-07 22:19 ` Kevin Wolf
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2024-02-06 15:31 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Kevin Wolf, Stefan Hajnoczi, Michael S. Tsirkin,
Hanna Reitz, qemu-block
The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 1d52cc0ac27761e296b14655c2f5b2649ee69491:
virtio-blk: avoid using ioeventfd state in irqfd conditional (2024-02-06 10:22:18 -0500)
----------------------------------------------------------------
Pull request
A bug fix for in-flight I/O during ioeventfd shutdown.
----------------------------------------------------------------
Stefan Hajnoczi (1):
virtio-blk: avoid using ioeventfd state in irqfd conditional
hw/block/virtio-blk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.43.0
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2024-02-06 15:31 Stefan Hajnoczi
@ 2024-02-07 22:19 ` Kevin Wolf
0 siblings, 0 replies; 39+ messages in thread
From: Kevin Wolf @ 2024-02-07 22:19 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Peter Maydell, Michael S. Tsirkin, Hanna Reitz, qemu-block
Am 06.02.2024 um 16:31 hat Stefan Hajnoczi geschrieben:
> The following changes since commit 39a6e4f87e7b75a45b08d6dc8b8b7c2954c87440:
>
> Merge tag 'pull-qapi-2024-02-03' of https://repo.or.cz/qemu/armbru into staging (2024-02-03 13:31:58 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 1d52cc0ac27761e296b14655c2f5b2649ee69491:
>
> virtio-blk: avoid using ioeventfd state in irqfd conditional (2024-02-06 10:22:18 -0500)
>
> ----------------------------------------------------------------
> Pull request
>
> A bug fix for in-flight I/O during ioeventfd shutdown.
>
> ----------------------------------------------------------------
>
> Stefan Hajnoczi (1):
> virtio-blk: avoid using ioeventfd state in irqfd conditional
I noticed that this patch is also in the pull request I sent, so I
guess if mine goes through, you don't have to process this one
separately.
Kevin
^ permalink raw reply [flat|nested] 39+ messages in thread
* [PULL 0/1] Block patches
@ 2024-03-19 15:09 Stefan Hajnoczi
2024-03-19 19:11 ` Peter Maydell
0 siblings, 1 reply; 39+ messages in thread
From: Stefan Hajnoczi @ 2024-03-19 15:09 UTC (permalink / raw)
To: qemu-devel
Cc: Michael S. Tsirkin, qemu-block, Kevin Wolf, Stefan Hajnoczi,
Peter Maydell, Hanna Reitz
The following changes since commit ddc27d2ad9361a81c2b3800d14143bf420dae172:
Merge tag 'pull-request-2024-03-18' of https://gitlab.com/thuth/qemu into staging (2024-03-19 10:25:25 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 86a637e48104ae74d8be53bed6441ce32be33433:
coroutine: cap per-thread local pool size (2024-03-19 10:49:31 -0400)
----------------------------------------------------------------
Pull request
This fix solves the "failed to set up stack guard page" error that has been
reported on Linux hosts where the QEMU coroutine pool exceeds the
vm.max_map_count limit.
----------------------------------------------------------------
Stefan Hajnoczi (1):
coroutine: cap per-thread local pool size
util/qemu-coroutine.c | 282 +++++++++++++++++++++++++++++++++---------
1 file changed, 223 insertions(+), 59 deletions(-)
--
2.44.0
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [PULL 0/1] Block patches
2024-03-19 15:09 Stefan Hajnoczi
@ 2024-03-19 19:11 ` Peter Maydell
0 siblings, 0 replies; 39+ messages in thread
From: Peter Maydell @ 2024-03-19 19:11 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Michael S. Tsirkin, qemu-block, Kevin Wolf, Hanna Reitz
On Tue, 19 Mar 2024 at 15:09, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit ddc27d2ad9361a81c2b3800d14143bf420dae172:
>
> Merge tag 'pull-request-2024-03-18' of https://gitlab.com/thuth/qemu into staging (2024-03-19 10:25:25 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 86a637e48104ae74d8be53bed6441ce32be33433:
>
> coroutine: cap per-thread local pool size (2024-03-19 10:49:31 -0400)
>
> ----------------------------------------------------------------
> Pull request
>
> This fix solves the "failed to set up stack guard page" error that has been
> reported on Linux hosts where the QEMU coroutine pool exceeds the
> vm.max_map_count limit.
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 39+ messages in thread
end of thread, other threads:[~2024-03-19 19:12 UTC | newest]
Thread overview: 39+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-14 8:52 [PULL 0/1] Block patches Stefan Hajnoczi
2019-10-14 8:52 ` [PULL 1/1] test-bdrv-drain: fix iothread_join() hang Stefan Hajnoczi
2019-10-14 11:11 ` Paolo Bonzini
2019-10-15 8:50 ` Stefan Hajnoczi
2019-10-15 11:00 ` [PULL 0/1] Block patches Peter Maydell
2020-01-14 9:30 Stefan Hajnoczi
2020-01-14 16:00 ` Peter Maydell
2020-03-17 15:18 Stefan Hajnoczi
2020-03-17 18:32 ` Peter Maydell
2021-01-04 14:23 Stefan Hajnoczi
2021-01-04 17:17 ` Peter Maydell
2021-03-15 9:51 Stefan Hajnoczi
2021-03-15 22:01 ` Peter Maydell
2021-10-21 17:41 Stefan Hajnoczi
2021-10-21 22:08 ` Richard Henderson
2021-10-25 10:10 ` Stefan Hajnoczi
2021-12-06 15:27 Stefan Hajnoczi
2021-12-06 21:16 ` Richard Henderson
2021-12-09 15:21 Stefan Hajnoczi
2021-12-09 15:46 ` Peter Maydell
2021-12-09 16:34 ` Stefan Hajnoczi
2021-12-09 16:53 ` Richard Henderson
2021-12-13 9:33 ` Stefan Hajnoczi
2021-12-14 22:31 ` Richard Henderson
2022-05-25 12:49 Stefan Hajnoczi
2022-05-25 18:35 ` Richard Henderson
2022-09-22 17:14 Stefan Hajnoczi
2022-09-27 15:04 ` Stefan Hajnoczi
2023-07-04 15:29 Stefan Hajnoczi
2023-07-06 6:04 ` Richard Henderson
2023-07-12 19:36 Stefan Hajnoczi
2023-07-14 6:35 ` Richard Henderson
2023-10-04 13:53 Stefan Hajnoczi
2023-10-04 18:33 ` Stefan Hajnoczi
2023-10-16 19:40 Stefan Hajnoczi
2024-02-06 15:31 Stefan Hajnoczi
2024-02-07 22:19 ` Kevin Wolf
2024-03-19 15:09 Stefan Hajnoczi
2024-03-19 19:11 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).