From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Paul Durrant" <paul@xen.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aleksandar Markovic" <amarkovic@wavecomp.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
xen-devel@lists.xenproject.org,
"Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Richard Henderson" <rth@twiddle.net>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Eduardo Habkost" <ehabkost@redhat.com>
Subject: [PATCH v2 13/20] hw/pci-host/piix: Extract piix3_create()
Date: Fri, 18 Oct 2019 15:47:47 +0200 [thread overview]
Message-ID: <20191018134754.16362-14-philmd@redhat.com> (raw)
In-Reply-To: <20191018134754.16362-1-philmd@redhat.com>
Extract the PIIX3 creation code from the i440fx_init() function.
Reviewed-by: Aleksandar Markovic <amarkovic@wavecomp.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
hw/pci-host/piix.c | 51 ++++++++++++++++++++++++++++------------------
1 file changed, 31 insertions(+), 20 deletions(-)
diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c
index 2f4cbcbfe9..3292703de7 100644
--- a/hw/pci-host/piix.c
+++ b/hw/pci-host/piix.c
@@ -331,6 +331,36 @@ static void i440fx_realize(PCIDevice *dev, Error **errp)
}
}
+static PIIX3State *piix3_create(PCIBus *pci_bus, ISABus **isa_bus)
+{
+ PIIX3State *piix3;
+ PCIDevice *pci_dev;
+
+ /*
+ * Xen supports additional interrupt routes from the PCI devices to
+ * the IOAPIC: the four pins of each PCI device on the bus are also
+ * connected to the IOAPIC directly.
+ * These additional routes can be discovered through ACPI.
+ */
+ if (xen_enabled()) {
+ pci_dev = pci_create_simple_multifunction(pci_bus, -1, true,
+ TYPE_PIIX3_XEN_DEVICE);
+ piix3 = PIIX3_PCI_DEVICE(pci_dev);
+ pci_bus_irqs(pci_bus, xen_piix3_set_irq, xen_pci_slot_get_pirq,
+ piix3, XEN_PIIX_NUM_PIRQS);
+ } else {
+ pci_dev = pci_create_simple_multifunction(pci_bus, -1, true,
+ TYPE_PIIX3_DEVICE);
+ piix3 = PIIX3_PCI_DEVICE(pci_dev);
+ pci_bus_irqs(pci_bus, piix3_set_irq, pci_slot_get_pirq,
+ piix3, PIIX_NUM_PIRQS);
+ pci_bus_set_route_irq_fn(pci_bus, piix3_route_intx_pin_to_irq);
+ }
+ *isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0"));
+
+ return piix3;
+}
+
PCIBus *i440fx_init(const char *host_type, const char *pci_type,
PCII440FXState **pi440fx_state,
int *piix3_devfn,
@@ -400,27 +430,8 @@ PCIBus *i440fx_init(const char *host_type, const char *pci_type,
PAM_EXPAN_SIZE);
}
- /* Xen supports additional interrupt routes from the PCI devices to
- * the IOAPIC: the four pins of each PCI device on the bus are also
- * connected to the IOAPIC directly.
- * These additional routes can be discovered through ACPI. */
- if (xen_enabled()) {
- PCIDevice *pci_dev = pci_create_simple_multifunction(b,
- -1, true, TYPE_PIIX3_XEN_DEVICE);
- piix3 = PIIX3_PCI_DEVICE(pci_dev);
- pci_bus_irqs(b, xen_piix3_set_irq, xen_pci_slot_get_pirq,
- piix3, XEN_PIIX_NUM_PIRQS);
- } else {
- PCIDevice *pci_dev = pci_create_simple_multifunction(b,
- -1, true, TYPE_PIIX3_DEVICE);
- piix3 = PIIX3_PCI_DEVICE(pci_dev);
- pci_bus_irqs(b, piix3_set_irq, pci_slot_get_pirq, piix3,
- PIIX_NUM_PIRQS);
- pci_bus_set_route_irq_fn(b, piix3_route_intx_pin_to_irq);
- }
+ piix3 = piix3_create(b, isa_bus);
piix3->pic = pic;
- *isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0"));
-
*piix3_devfn = piix3->dev.devfn;
ram_size = ram_size / 8 / 1024 / 1024;
--
2.21.0
next prev parent reply other threads:[~2019-10-18 14:07 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 13:47 [PATCH v2 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 01/20] MAINTAINERS: Keep PIIX4 South Bridge separate from PC Chipsets Philippe Mathieu-Daudé
2019-10-21 0:54 ` Li Qiang
2019-10-18 13:47 ` [PATCH v2 02/20] piix4: Add the Reset Control Register Philippe Mathieu-Daudé
2019-10-21 1:25 ` Li Qiang
2019-10-21 8:37 ` Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet Philippe Mathieu-Daudé
2019-10-21 14:59 ` Li Qiang
2019-10-26 14:29 ` Philippe Mathieu-Daudé
2019-10-22 8:44 ` Esteban Bosse
2019-10-22 9:35 ` Philippe Mathieu-Daudé
2019-10-23 18:53 ` Esteban Bosse
2019-10-22 8:48 ` Esteban Bosse
2019-10-22 9:24 ` Philippe Mathieu-Daudé
2019-10-22 9:42 ` Peter Maydell
2019-10-23 18:52 ` Esteban Bosse
2019-10-22 9:53 ` Aleksandar Markovic
2019-10-22 10:09 ` Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()" Philippe Mathieu-Daudé
2019-10-21 15:18 ` Li Qiang
2019-10-22 8:50 ` Esteban Bosse
2019-10-18 13:47 ` [PATCH v2 05/20] piix4: Rename PIIX4 object to piix4-isa Philippe Mathieu-Daudé
2019-10-21 15:19 ` Li Qiang
2019-10-22 8:57 ` Esteban Bosse
2019-10-18 13:47 ` [PATCH v2 06/20] piix4: Add a i8257 DMA Controller as specified in datasheet Philippe Mathieu-Daudé
2019-10-21 15:25 ` Li Qiang
2019-10-21 15:56 ` Philippe Mathieu-Daudé
2019-10-22 9:01 ` Esteban Bosse
2019-10-18 13:47 ` [PATCH v2 07/20] piix4: Add a i8254 PIT " Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 08/20] piix4: Add a MC146818 RTC " Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 09/20] hw/mips/mips_malta: Create IDE hard drive array dynamically Philippe Mathieu-Daudé
2019-10-21 15:28 ` Li Qiang
2019-10-18 13:47 ` [PATCH v2 10/20] hw/mips/mips_malta: Extract the PIIX4 creation code as piix4_create() Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 11/20] hw/isa/piix4: Move piix4_create() to hw/isa/piix4.c Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 12/20] hw/i386: Remove obsolete LoadStateHandler::load_state_old handlers Philippe Mathieu-Daudé
2019-10-18 13:47 ` Philippe Mathieu-Daudé [this message]
2019-10-22 9:33 ` [PATCH v2 13/20] hw/pci-host/piix: Extract piix3_create() Esteban Bosse
2019-10-18 13:47 ` [PATCH v2 14/20] hw/pci-host/piix: Move RCR_IOPORT register definition Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 15/20] hw/pci-host/piix: Define and use the PIIX IRQ Route Control Registers Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 16/20] hw/pci-host/piix: Move i440FX declarations to hw/pci-host/i440fx.h Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues Philippe Mathieu-Daudé
2019-10-22 9:39 ` Esteban Bosse
2019-10-18 13:47 ` [PATCH v2 18/20] hw/pci-host/piix: Extract PIIX3 functions to hw/isa/piix3.c Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 19/20] hw/pci-host: Rename incorrectly named 'piix' as 'i440fx' Philippe Mathieu-Daudé
2019-10-18 13:47 ` [PATCH v2 20/20] hw/pci-host/i440fx: Remove the last PIIX3 traces Philippe Mathieu-Daudé
2019-10-18 17:04 ` Aleksandar Markovic
2019-10-19 15:22 ` Philippe Mathieu-Daudé
2019-10-19 10:50 ` [PATCH v2 00/20] hw/i386/pc: Split PIIX3 southbridge from i440FX northbridge no-reply
2019-10-19 15:15 ` Aleksandar Markovic
2019-10-24 19:55 ` Aleksandar Markovic
2019-10-25 10:51 ` Aleksandar Markovic
2019-10-26 14:39 ` Philippe Mathieu-Daudé
2019-10-26 15:17 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018134754.16362-14-philmd@redhat.com \
--to=philmd@redhat.com \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=amarkovic@wavecomp.com \
--cc=anthony.perard@citrix.com \
--cc=aurelien@aurel32.net \
--cc=ehabkost@redhat.com \
--cc=hpoussin@reactos.org \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).