From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, slp@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [PATCH v3 06/16] libqos: add missing virtio-9p feature negotiation
Date: Sat, 19 Oct 2019 07:38:00 +0100 [thread overview]
Message-ID: <20191019063810.6944-7-stefanha@redhat.com> (raw)
In-Reply-To: <20191019063810.6944-1-stefanha@redhat.com>
VIRTIO Device Initialization requires feature negotiation. The libqos
virtio-9p driver lacks feature negotiation and is therefore
non-compliant.
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
tests/libqos/virtio-9p.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/tests/libqos/virtio-9p.c b/tests/libqos/virtio-9p.c
index 8c9efce3e1..77dbfb62ad 100644
--- a/tests/libqos/virtio-9p.c
+++ b/tests/libqos/virtio-9p.c
@@ -32,6 +32,12 @@ static void virtio_9p_cleanup(QVirtio9P *interface)
static void virtio_9p_setup(QVirtio9P *interface)
{
+ uint64_t features;
+
+ features = qvirtio_get_features(interface->vdev);
+ features &= ~(QVIRTIO_F_BAD_FEATURE | (1ull << VIRTIO_RING_F_EVENT_IDX));
+ qvirtio_set_features(interface->vdev, features);
+
interface->vq = qvirtqueue_setup(interface->vdev, alloc, 0);
qvirtio_set_driver_ok(interface->vdev);
}
--
2.21.0
next prev parent reply other threads:[~2019-10-19 6:44 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 6:37 [PATCH v3 00/16] libqos: add VIRTIO PCI 1.0 support Stefan Hajnoczi
2019-10-19 6:37 ` [PATCH v3 01/16] tests/virtio-blk-test: read config space after feature negotiation Stefan Hajnoczi
2019-10-21 9:12 ` Thomas Huth
2019-10-19 6:37 ` [PATCH v3 02/16] libqos: read QVIRTIO_MMIO_VERSION register Stefan Hajnoczi
2019-10-21 9:13 ` Thomas Huth
2019-10-19 6:37 ` [PATCH v3 03/16] libqos: extend feature bits to 64-bit Stefan Hajnoczi
2019-10-21 9:21 ` Thomas Huth
2019-10-21 12:57 ` Philippe Mathieu-Daudé
2019-10-19 6:37 ` [PATCH v3 04/16] virtio-scsi-test: add missing feature negotiation Stefan Hajnoczi
2019-10-21 12:08 ` Thomas Huth
2019-10-22 15:38 ` Stefan Hajnoczi
2019-10-19 6:37 ` [PATCH v3 05/16] tests/virtio-blk-test: set up virtqueue after " Stefan Hajnoczi
2019-10-21 12:11 ` Thomas Huth
2019-10-19 6:38 ` Stefan Hajnoczi [this message]
2019-10-21 12:14 ` [PATCH v3 06/16] libqos: add missing virtio-9p " Thomas Huth
2019-10-19 6:38 ` [PATCH v3 07/16] libqos: enforce Device Initialization order Stefan Hajnoczi
2019-10-21 12:15 ` Thomas Huth
2019-10-22 15:48 ` Stefan Hajnoczi
2019-10-22 18:48 ` Thomas Huth
2019-10-23 8:33 ` Stefan Hajnoczi
2019-10-19 6:38 ` [PATCH v3 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step Stefan Hajnoczi
2019-10-21 12:23 ` Thomas Huth
2019-10-22 15:53 ` Stefan Hajnoczi
2019-10-19 6:38 ` [PATCH v3 09/16] libqos: access VIRTIO 1.0 vring in little-endian Stefan Hajnoczi
2019-10-21 12:48 ` Thomas Huth
2019-10-22 15:54 ` Stefan Hajnoczi
2019-10-22 16:51 ` Christophe de Dinechin
2019-10-23 8:37 ` Stefan Hajnoczi
2019-10-19 6:38 ` [PATCH v3 10/16] libqos: add iteration support to qpci_find_capability() Stefan Hajnoczi
2019-10-21 12:49 ` Thomas Huth
2019-10-19 6:38 ` [PATCH v3 11/16] libqos: pass full QVirtQueue to set_queue_address() Stefan Hajnoczi
2019-10-21 12:59 ` Philippe Mathieu-Daudé
2019-10-19 6:38 ` [PATCH v3 12/16] libqos: add MSI-X callbacks to QVirtioPCIDevice Stefan Hajnoczi
2019-10-19 6:38 ` [PATCH v3 13/16] libqos: expose common virtqueue setup/cleanup functions Stefan Hajnoczi
2019-10-19 6:38 ` [PATCH v3 14/16] libqos: make the virtio-pci BAR index configurable Stefan Hajnoczi
2019-10-21 12:50 ` Thomas Huth
2019-10-21 13:02 ` Philippe Mathieu-Daudé
2019-10-19 6:38 ` [PATCH v3 15/16] libqos: extract Legacy virtio-pci.c code Stefan Hajnoczi
2019-10-21 13:03 ` Philippe Mathieu-Daudé
2019-10-19 6:38 ` [PATCH v3 16/16] libqos: add VIRTIO PCI 1.0 support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191019063810.6944-7-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=fam@euphon.net \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=slp@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).