From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Fam Zheng <fam@euphon.net>, Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, slp@redhat.com,
"Michael S. Tsirkin" <mst@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Christophe de Dinechin <dinechin@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: [PATCH v4 00/16] libqos: add VIRTIO PCI 1.0 support
Date: Wed, 23 Oct 2019 11:04:09 +0100 [thread overview]
Message-ID: <20191023100425.12168-1-stefanha@redhat.com> (raw)
v4:
* Introduce bool d->features_negotiated so that tests can negotiate a
0 feature bit set in Legacy mode [Thomas]
* Make the FEATURES_OK code change in qvirtio_set_driver_ok() clearer and
mention it in the commit description [Thomas]
* Fix indentation in qvring_init() [Thomas]
v3:
* Now implements VIRTIO 1.0 fully (vring, device initialization).
This required several new patches to address the following issues:
1. Tests that do not negotiate features (non-compliant!)
2. Tests that access configuration space before feature negotiation
(non-compliant!)
3. Tests that set up virtqueues before feature negotiation (non-compliant!)
4. vring accesses require byte-swapping when VIRTIO 1.0 is used with a
big-endian guest because the qtest_readX/writeX() API automatically
converts to guest-endian
5. VIRTIO 1.0 has an additional FEATURES_OK step during Device
Initialization
* Change uint8_t bar_idx to int [Thomas]
* Document qpci_find_capability() [Thomas]
* Every commit tested with arm, ppc64, and x86_64 targets using:
git rebase -i origin/master -x 'make tests/qos-test &&
QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 tests/qos-test &&
QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 tests/qos-test'
QTEST_QEMU_BINARY=arm-softmmu/qemu-system-arm tests/qos-test'
v2:
* Fix checkpatch.pl issues, except MAINTAINERS file warning. libqos already
has maintainers and the new virtio-pci-modern.[ch] files don't need extra
entries since they are already covered by the existing libqos/ entry.
New VIRTIO devices are Non-Transitional. This means they only expose the
VIRTIO 1.0 interface, not the Legacy interface.
The libqos only supports Legacy and Transitional devices (in Legacy mode).
This patch series adds VIRTIO 1.0 support so that tests can run against
Non-Transitional devices too.
The virtio-fs device is Non-Transitional, so this is a prerequisite for
virtio-fs qos tests.
Stefan Hajnoczi (16):
tests/virtio-blk-test: read config space after feature negotiation
libqos: read QVIRTIO_MMIO_VERSION register
libqos: extend feature bits to 64-bit
virtio-scsi-test: add missing feature negotiation
tests/virtio-blk-test: set up virtqueue after feature negotiation
libqos: add missing virtio-9p feature negotiation
libqos: enforce Device Initialization order
libqos: implement VIRTIO 1.0 FEATURES_OK step
libqos: access VIRTIO 1.0 vring in little-endian
libqos: add iteration support to qpci_find_capability()
libqos: pass full QVirtQueue to set_queue_address()
libqos: add MSI-X callbacks to QVirtioPCIDevice
libqos: expose common virtqueue setup/cleanup functions
libqos: make the virtio-pci BAR index configurable
libqos: extract Legacy virtio-pci.c code
libqos: add VIRTIO PCI 1.0 support
tests/Makefile.include | 1 +
tests/libqos/pci.h | 2 +-
tests/libqos/virtio-mmio.h | 1 +
tests/libqos/virtio-pci-modern.h | 17 ++
tests/libqos/virtio-pci.h | 34 ++-
tests/libqos/virtio.h | 19 +-
tests/libqos/pci.c | 30 ++-
tests/libqos/virtio-9p.c | 6 +
tests/libqos/virtio-mmio.c | 38 ++-
tests/libqos/virtio-net.c | 6 +-
tests/libqos/virtio-pci-modern.c | 443 +++++++++++++++++++++++++++++++
tests/libqos/virtio-pci.c | 105 +++++---
tests/libqos/virtio.c | 160 ++++++++---
tests/virtio-blk-test.c | 66 +++--
tests/virtio-scsi-test.c | 8 +
15 files changed, 802 insertions(+), 134 deletions(-)
create mode 100644 tests/libqos/virtio-pci-modern.h
create mode 100644 tests/libqos/virtio-pci-modern.c
--
2.21.0
next reply other threads:[~2019-10-23 10:11 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 10:04 Stefan Hajnoczi [this message]
2019-10-23 10:04 ` [PATCH v4 01/16] tests/virtio-blk-test: read config space after feature negotiation Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 02/16] libqos: read QVIRTIO_MMIO_VERSION register Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 03/16] libqos: extend feature bits to 64-bit Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 04/16] virtio-scsi-test: add missing feature negotiation Stefan Hajnoczi
2019-10-23 10:19 ` Thomas Huth
2019-10-23 10:04 ` [PATCH v4 05/16] tests/virtio-blk-test: set up virtqueue after " Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 06/16] libqos: add missing virtio-9p " Stefan Hajnoczi
2019-10-23 10:20 ` Thomas Huth
2019-10-23 10:04 ` [PATCH v4 07/16] libqos: enforce Device Initialization order Stefan Hajnoczi
2019-10-23 11:23 ` Thomas Huth
2019-10-23 10:04 ` [PATCH v4 08/16] libqos: implement VIRTIO 1.0 FEATURES_OK step Stefan Hajnoczi
2019-10-23 11:04 ` Thomas Huth
2019-10-23 10:04 ` [PATCH v4 09/16] libqos: access VIRTIO 1.0 vring in little-endian Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 10/16] libqos: add iteration support to qpci_find_capability() Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 11/16] libqos: pass full QVirtQueue to set_queue_address() Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 12/16] libqos: add MSI-X callbacks to QVirtioPCIDevice Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 13/16] libqos: expose common virtqueue setup/cleanup functions Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 14/16] libqos: make the virtio-pci BAR index configurable Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 15/16] libqos: extract Legacy virtio-pci.c code Stefan Hajnoczi
2019-10-23 10:04 ` [PATCH v4 16/16] libqos: add VIRTIO PCI 1.0 support Stefan Hajnoczi
2019-10-23 11:22 ` Thomas Huth
2019-10-25 11:32 ` [PATCH v4 00/16] " Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023100425.12168-1-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=cohuck@redhat.com \
--cc=dinechin@redhat.com \
--cc=fam@euphon.net \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=slp@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).