From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>
Cc: pkrempa@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
mst@redhat.com, aadam@redhat.com, qemu-devel@nongnu.org,
alex.williamson@redhat.com, laine@redhat.com, ailan@redhat.com,
parav@mellanox.com
Subject: Re: [PATCH v5 02/11] pci: add option for net failover
Date: Thu, 24 Oct 2019 18:22:27 +0100 [thread overview]
Message-ID: <20191024172227.GO2877@work-vm> (raw)
In-Reply-To: <20191023082711.16694-3-jfreimann@redhat.com>
* Jens Freimann (jfreimann@redhat.com) wrote:
> This patch adds a net_failover_pair_id property to PCIDev which is
> used to link the primary device in a failover pair (the PCI dev) to
> a standby (a virtio-net-pci) device.
>
> It only supports ethernet devices. Also currently it only supports
> PCIe devices. QEMU will exit with an error message otherwise.
>
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
> hw/pci/pci.c | 17 +++++++++++++++++
> include/hw/pci/pci.h | 3 +++
> 2 files changed, 20 insertions(+)
>
> diff --git a/hw/pci/pci.c b/hw/pci/pci.c
> index aa05c2b9b2..fa9b5219f8 100644
> --- a/hw/pci/pci.c
> +++ b/hw/pci/pci.c
> @@ -75,6 +75,8 @@ static Property pci_props[] = {
> QEMU_PCIE_LNKSTA_DLLLA_BITNR, true),
> DEFINE_PROP_BIT("x-pcie-extcap-init", PCIDevice, cap_present,
> QEMU_PCIE_EXTCAP_INIT_BITNR, true),
> + DEFINE_PROP_STRING("net_failover_pair_id", PCIDevice,
> + net_failover_pair_id),
Should we just make this 'failover_pair_id' - then when someone in the
future figures out how to make it work for something else (e.g.
multipath block devices) then it's all good?
Dave
> DEFINE_PROP_END_OF_LIST()
> };
>
> @@ -2077,6 +2079,7 @@ static void pci_qdev_realize(DeviceState *qdev, Error **errp)
> ObjectClass *klass = OBJECT_CLASS(pc);
> Error *local_err = NULL;
> bool is_default_rom;
> + uint16_t class_id;
>
> /* initialize cap_present for pci_is_express() and pci_config_size(),
> * Note that hybrid PCIs are not set automatically and need to manage
> @@ -2101,6 +2104,20 @@ static void pci_qdev_realize(DeviceState *qdev, Error **errp)
> }
> }
>
> + if (pci_dev->net_failover_pair_id) {
> + if (!pci_is_express(pci_dev)) {
> + error_setg(errp, "failover device is not a PCIExpress device");
> + error_propagate(errp, local_err);
> + return;
> + }
> + class_id = pci_get_word(pci_dev->config + PCI_CLASS_DEVICE);
> + if (class_id != PCI_CLASS_NETWORK_ETHERNET) {
> + error_setg(errp, "failover device is not an Ethernet device");
> + error_propagate(errp, local_err);
> + return;
> + }
> + }
> +
> /* rom loading */
> is_default_rom = false;
> if (pci_dev->romfile == NULL && pc->romfile != NULL) {
> diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
> index f3f0ffd5fb..def5435685 100644
> --- a/include/hw/pci/pci.h
> +++ b/include/hw/pci/pci.h
> @@ -352,6 +352,9 @@ struct PCIDevice {
> MSIVectorUseNotifier msix_vector_use_notifier;
> MSIVectorReleaseNotifier msix_vector_release_notifier;
> MSIVectorPollNotifier msix_vector_poll_notifier;
> +
> + /* ID of standby device in net_failover pair */
> + char *net_failover_pair_id;
> };
>
> void pci_register_bar(PCIDevice *pci_dev, int region_num,
> --
> 2.21.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-10-24 18:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 8:27 [PATCH v5 0/11] add failover feature for assigned network devices Jens Freimann
2019-10-23 8:27 ` [PATCH v5 01/11] qdev/qbus: add hidden device support Jens Freimann
2019-10-23 8:27 ` [PATCH v5 02/11] pci: add option for net failover Jens Freimann
2019-10-23 18:06 ` Alex Williamson
2019-10-23 19:30 ` Jens Freimann
2019-10-23 20:02 ` Alex Williamson
2019-10-23 20:31 ` Jens Freimann
2019-10-23 21:15 ` Alex Williamson
2019-10-24 17:57 ` Laine Stump
2019-10-25 10:52 ` Jens Freimann
2019-10-25 14:56 ` Alex Williamson
2019-10-24 5:03 ` Parav Pandit
2019-10-24 9:37 ` Jens Freimann
2019-10-24 16:34 ` Parav Pandit
2019-10-24 17:06 ` Alex Williamson
2019-10-24 16:52 ` Alex Williamson
2019-10-24 20:08 ` Jens Freimann
2019-10-24 17:22 ` Dr. David Alan Gilbert [this message]
2019-10-24 19:56 ` Jens Freimann
2019-10-23 8:27 ` [PATCH v5 03/11] pci: mark devices partially unplugged Jens Freimann
2019-10-23 8:27 ` [PATCH v5 04/11] pci: mark device having guest unplug request pending Jens Freimann
2019-10-23 8:27 ` [PATCH v5 05/11] qapi: add unplug primary event Jens Freimann
2019-10-23 11:32 ` Eric Blake
2019-10-23 8:27 ` [PATCH v5 06/11] qapi: add failover negotiated event Jens Freimann
2019-10-24 17:32 ` Dr. David Alan Gilbert
2019-10-24 20:03 ` Jens Freimann
2019-10-25 5:35 ` Markus Armbruster
2019-10-25 7:51 ` Jens Freimann
2019-10-23 8:27 ` [PATCH v5 07/11] migration: allow unplug during migration for failover devices Jens Freimann
2019-10-23 8:27 ` [PATCH v5 08/11] migration: add new migration state wait-unplug Jens Freimann
2019-10-23 8:27 ` [PATCH v5 09/11] libqos: tolerate wait-unplug migration state Jens Freimann
2019-10-23 8:27 ` [PATCH v5 10/11] net/virtio: add failover support Jens Freimann
2019-10-23 8:27 ` [PATCH v5 11/11] vfio: unplug failover primary device before migration Jens Freimann
2019-10-23 18:28 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191024172227.GO2877@work-vm \
--to=dgilbert@redhat.com \
--cc=aadam@redhat.com \
--cc=ailan@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jfreimann@redhat.com \
--cc=laine@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).