qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jens Freimann <jfreimann@redhat.com>
To: qemu-devel@nongnu.org
Cc: pkrempa@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
	mst@redhat.com, aadam@redhat.com, jasowang@redhat.com,
	dgilbert@redhat.com, armbru@redhat.com,
	alex.williamson@redhat.com, laine@redhat.com, ailan@redhat.com,
	parav@mellanox.com
Subject: [PATCH v6 03/11] pci: mark devices partially unplugged
Date: Fri, 25 Oct 2019 14:19:22 +0200	[thread overview]
Message-ID: <20191025121930.6855-4-jfreimann@redhat.com> (raw)
In-Reply-To: <20191025121930.6855-1-jfreimann@redhat.com>

Only the guest unplug request was triggered. This is needed for
the failover feature. In case of a failed migration we need to
plug the device back to the guest.

Signed-off-by: Jens Freimann <jfreimann@redhat.com>
Acked-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/pci/pcie.c        | 3 +++
 include/hw/pci/pci.h | 1 +
 2 files changed, 4 insertions(+)

diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index a6beb567bd..19363ff8ce 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -456,6 +456,9 @@ static void pcie_unplug_device(PCIBus *bus, PCIDevice *dev, void *opaque)
 {
     HotplugHandler *hotplug_ctrl = qdev_get_hotplug_handler(DEVICE(dev));
 
+    if (dev->partially_hotplugged) {
+        return;
+    }
     hotplug_handler_unplug(hotplug_ctrl, DEVICE(dev), &error_abort);
     object_unparent(OBJECT(dev));
 }
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 69d1f0228b..db75c6dfd0 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -265,6 +265,7 @@ typedef struct PCIReqIDCache PCIReqIDCache;
 
 struct PCIDevice {
     DeviceState qdev;
+    bool partially_hotplugged;
 
     /* PCI config space */
     uint8_t *config;
-- 
2.21.0



  parent reply	other threads:[~2019-10-25 12:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 12:19 [PATCH v6 0/11] add failover feature for assigned network devices Jens Freimann
2019-10-25 12:19 ` [PATCH v6 01/11] qdev/qbus: add hidden device support Jens Freimann
2019-10-25 17:34   ` Dr. David Alan Gilbert
2019-10-25 12:19 ` [PATCH v6 02/11] pci: add option for net failover Jens Freimann
2019-10-25 12:19 ` Jens Freimann [this message]
2019-10-25 12:19 ` [PATCH v6 04/11] pci: mark device having guest unplug request pending Jens Freimann
2019-10-25 12:19 ` [PATCH v6 05/11] qapi: add unplug primary event Jens Freimann
2019-10-25 12:19 ` [PATCH v6 06/11] qapi: add failover negotiated event Jens Freimann
2019-10-25 14:03   ` Markus Armbruster
2019-10-25 17:39     ` Jens Freimann
2019-10-29 12:13       ` Markus Armbruster
2019-10-29 22:41       ` Michael S. Tsirkin
2019-10-30 10:09         ` Jens Freimann
2019-10-25 12:19 ` [PATCH v6 07/11] migration: allow unplug during migration for failover devices Jens Freimann
2019-10-25 12:19 ` [PATCH v6 08/11] migration: add new migration state wait-unplug Jens Freimann
2019-10-29  2:56   ` Dr. David Alan Gilbert
2019-10-29  5:51     ` Jens Freimann
2019-10-29  7:09       ` Dr. David Alan Gilbert
2019-10-25 12:19 ` [PATCH v6 09/11] libqos: tolerate wait-unplug migration state Jens Freimann
2019-10-25 12:19 ` [PATCH v6 10/11] net/virtio: add failover support Jens Freimann
2019-10-25 12:19 ` [PATCH v6 11/11] vfio: unplug failover primary device before migration Jens Freimann
2019-10-25 15:23 ` [PATCH v6 0/11] add failover feature for assigned network devices Roman Kagan
2019-10-28 10:27 ` Jens Freimann
2019-10-28 15:58   ` Michael S. Tsirkin
2019-10-29 11:18     ` Jens Freimann
2019-10-29 22:49 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025121930.6855-4-jfreimann@redhat.com \
    --to=jfreimann@redhat.com \
    --cc=aadam@redhat.com \
    --cc=ailan@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=laine@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@mellanox.com \
    --cc=pkrempa@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).