From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1354CA9EAE for ; Tue, 29 Oct 2019 22:52:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8126D20659 for ; Tue, 29 Oct 2019 22:52:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8126D20659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34762 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPaLV-0002KL-Nh for qemu-devel@archiver.kernel.org; Tue, 29 Oct 2019 18:52:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35319) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iPaKN-0001Oy-BL for qemu-devel@nongnu.org; Tue, 29 Oct 2019 18:51:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iPaKL-0000rn-Oy for qemu-devel@nongnu.org; Tue, 29 Oct 2019 18:51:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35724) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iPaKL-0000qQ-FY for qemu-devel@nongnu.org; Tue, 29 Oct 2019 18:51:01 -0400 Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 96B434E83E for ; Tue, 29 Oct 2019 22:51:00 +0000 (UTC) Received: by mail-qk1-f200.google.com with SMTP id s3so256025qkd.6 for ; Tue, 29 Oct 2019 15:51:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=B8o4LFJI48b2pjbfqwmaPWKdaM/t4+vXamLT51/abdQ=; b=gtc/f43Z8bw9izeQmhDK0X0c1c5xCCblDGlTv7lbH/W/jI7revLXwW1lddwNfriCDu EsYoP7fp7/+qzFRteWSMUAOgiHySnajg+8FA4L2KSLOAsgSrsoKwRCCxF5RKTuXsgCHA rWofzLq20bWiA+nKuFCltpHWqfOtSgrN6q/JLEAjKtBlDSkT97162ltj+p/Z1TiG78IU W8jna1YsMfxs51TBMVUBjWSqhAVHuqIiDcmON79NJwWb9klAla44Q6e2XH1us0H2vTl3 YvWxBKXuxaipxwB3nqP1qnuEgEChXyA0CnhwYJktdrWxIGl6zn44Jti2oCb0hEDy5zVW URUA== X-Gm-Message-State: APjAAAU1FlElWzYvk6ZiZ3nse0mobxnfX+YglQi3UdZlJtXZV+h9W6Wb rxlCsA5JNHTZRVQGK+urbkJiyV4jOwvUHxyOAgiNEf/IndG3LmKCBDRdGb9DrvOE9lPjpVZAl8d q2MG7stzjXmqWAzY= X-Received: by 2002:ac8:18af:: with SMTP id s44mr1864875qtj.78.1572389459825; Tue, 29 Oct 2019 15:50:59 -0700 (PDT) X-Google-Smtp-Source: APXvYqxecgwaDu/UMuAluxiv9XPXfYgUY2slHkh02G7e+Wfq+oMNMNd+103geV+K8KIGO8lGp+Lytw== X-Received: by 2002:ac8:18af:: with SMTP id s44mr1864851qtj.78.1572389459544; Tue, 29 Oct 2019 15:50:59 -0700 (PDT) Received: from redhat.com (94.222.26.109.rev.sfr.net. [109.26.222.94]) by smtp.gmail.com with ESMTPSA id e17sm92461qtk.65.2019.10.29.15.50.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Oct 2019 15:50:58 -0700 (PDT) Date: Tue, 29 Oct 2019 18:50:55 -0400 From: "Michael S. Tsirkin" To: "Dr. David Alan Gilbert (git)" Subject: Re: [PATCH 00/30] virtiofs daemon (base) Message-ID: <20191029185004-mutt-send-email-mst@kernel.org> References: <20191021105832.36574-1-dgilbert@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021105832.36574-1-dgilbert@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 209.132.183.28 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, piaojun@huawei.com, stefanha@redhat.com, marcandre.lureau@redhat.com, eguan@linux.alibaba.com, vgoyal@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Oct 21, 2019 at 11:58:02AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is the 1st set for the virtiofsd - a daemon > that implements the user space side of virtiofs. > > The kernel and qemu device parts recently went in, > so the daemon is the only thing missing to have a working > set. So I went back and forth on this but this is huge and there's not a lot of time for review. So I parked it + the security patches on a next branch in my tree. I will rebase once after rc1 is out, and then stop. > This set is the absolute minimal base set of patches; > it's not yet safe to use (from security or correctness); > > I'll follow up with ~3 more series in the next few days > with: > > a) Security patches that add sandboxing and checking > compared with normal fuse - that makes it safe. > b) Performance improvements including threading > c) Other fixes, including correctness. > > but, this is a good start and gets things rolling. > > The set pulls in a big chunk of the upstream libfuse library > (unmodified so that it's easy to check it really is upstream), > chops all the stuff out we don't need and then adds the > new transport we need. > > For new files I've formatted the code according to qemu > standards; for files that are from upstream libfuse > I've kept with their standards for ease of future updating. > > We can't just link with libfuse, since we have to make ABI incompatible > changes for the new transport. > > Running this daemon is typically done with: > > ./virtiofsd -o vhost_user_socket=/path/socket -o source=/path/to/fs > > connected to a qemu that's then started with: > -chardev socket,id=char0,path=/path/socket -device vhost-user-fs-pci,queue-size=1024,chardev=char0,tag=myfs > > and then in the guest mount with: > mount -t virtiofs myfs /mnt > > Our development branch is: https://gitlab.com/virtio-fs/qemu/tree/virtio-fs-dev > > Dave > > > Dr. David Alan Gilbert (22): > virtiofsd: Pull in upstream headers > virtiofsd: Pull in kernel's fuse.h > virtiofsd: Add auxiliary .c's > virtiofsd: Add fuse_lowlevel.c > virtiofsd: Add passthrough_ll > virtiofsd: Trim down imported files > virtiofsd: Fix fuse_daemonize ignored return values > virtiofsd: Fix common header and define for QEMU builds > virtiofsd: fuse: Make iov_length usable outside fuse_lowlevel.c > virtiofsd: Add options for virtio > virtiofsd: Open vhost connection instead of mounting > virtiofsd: Start wiring up vhost-user > virtiofsd: Add main virtio loop > virtiofsd: get/set features callbacks > virtiofsd: Start queue threads > virtiofsd: Poll kick_fd for queue > virtiofsd: Start reading commands from queue > virtiofsd: Send replies to messages > virtiofsd: Keep track of replies > virtiofsd: Add Makefile wiring for virtiofsd contrib > virtiofsd: Fast path for virtio read > virtiofs: Add maintainers entry > > Stefan Hajnoczi (7): > virtiofsd: remove mountpoint dummy argument > virtiofsd: remove unused notify reply support > virtiofsd: add -o source=PATH to help output > virtiofsd: add --fd=FDNUM fd passing option > virtiofsd: make -f (foreground) the default > virtiofsd: add vhost-user.json file > virtiofsd: add --print-capabilities option > > Vivek Goyal (1): > virtiofsd: Make fsync work even if only inode is passed in > > .gitignore | 1 + > MAINTAINERS | 8 + > Makefile | 9 + > Makefile.objs | 1 + > contrib/virtiofsd/50-qemu-virtiofsd.json.in | 5 + > contrib/virtiofsd/Makefile.objs | 10 + > contrib/virtiofsd/buffer.c | 318 +++ > contrib/virtiofsd/fuse.h | 1268 ++++++++++ > contrib/virtiofsd/fuse_common.h | 823 +++++++ > contrib/virtiofsd/fuse_i.h | 131 ++ > contrib/virtiofsd/fuse_kernel.h | 858 +++++++ > contrib/virtiofsd/fuse_log.c | 40 + > contrib/virtiofsd/fuse_log.h | 82 + > contrib/virtiofsd/fuse_loop_mt.c | 54 + > contrib/virtiofsd/fuse_lowlevel.c | 2302 +++++++++++++++++++ > contrib/virtiofsd/fuse_lowlevel.h | 2024 ++++++++++++++++ > contrib/virtiofsd/fuse_misc.h | 59 + > contrib/virtiofsd/fuse_opt.c | 422 ++++ > contrib/virtiofsd/fuse_opt.h | 271 +++ > contrib/virtiofsd/fuse_signals.c | 90 + > contrib/virtiofsd/fuse_virtio.c | 717 ++++++ > contrib/virtiofsd/fuse_virtio.h | 33 + > contrib/virtiofsd/helper.c | 300 +++ > contrib/virtiofsd/passthrough_helpers.h | 76 + > contrib/virtiofsd/passthrough_ll.c | 1341 +++++++++++ > docs/interop/vhost-user.json | 4 +- > 26 files changed, 11246 insertions(+), 1 deletion(-) > create mode 100644 contrib/virtiofsd/50-qemu-virtiofsd.json.in > create mode 100644 contrib/virtiofsd/Makefile.objs > create mode 100644 contrib/virtiofsd/buffer.c > create mode 100644 contrib/virtiofsd/fuse.h > create mode 100644 contrib/virtiofsd/fuse_common.h > create mode 100644 contrib/virtiofsd/fuse_i.h > create mode 100644 contrib/virtiofsd/fuse_kernel.h > create mode 100644 contrib/virtiofsd/fuse_log.c > create mode 100644 contrib/virtiofsd/fuse_log.h > create mode 100644 contrib/virtiofsd/fuse_loop_mt.c > create mode 100644 contrib/virtiofsd/fuse_lowlevel.c > create mode 100644 contrib/virtiofsd/fuse_lowlevel.h > create mode 100644 contrib/virtiofsd/fuse_misc.h > create mode 100644 contrib/virtiofsd/fuse_opt.c > create mode 100644 contrib/virtiofsd/fuse_opt.h > create mode 100644 contrib/virtiofsd/fuse_signals.c > create mode 100644 contrib/virtiofsd/fuse_virtio.c > create mode 100644 contrib/virtiofsd/fuse_virtio.h > create mode 100644 contrib/virtiofsd/helper.c > create mode 100644 contrib/virtiofsd/passthrough_helpers.h > create mode 100644 contrib/virtiofsd/passthrough_ll.c > > -- > 2.23.0