From: Eduardo Habkost <ehabkost@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
John Snow <jsnow@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: git-publish, --pull-request and --signoff (was: Re: [PULL 0/9] Ide patches)
Date: Tue, 5 Nov 2019 17:22:42 -0300 [thread overview]
Message-ID: <20191105202242.GI3812@habkost.net> (raw)
In-Reply-To: <CAJSP0QVmL_JTZOo=opN6Z6kgpwJaY780YocSteC1z48kpCac5Q@mail.gmail.com>
On Tue, Nov 05, 2019 at 09:17:42PM +0100, Stefan Hajnoczi wrote:
> On Thu, Oct 31, 2019 at 5:07 PM John Snow <jsnow@redhat.com> wrote:
> > On 10/31/19 11:02 AM, Peter Maydell wrote:
> > > On Thu, 31 Oct 2019 at 10:59, John Snow <jsnow@redhat.com> wrote:
> > >>
> > >> The following changes since commit 68d8ef4ec540682c3538d4963e836e43a211dd17:
> > >>
> > >> Merge remote-tracking branch 'remotes/stsquad/tags/pull-tcg-plugins-281019-4' into staging (2019-10-30 14:10:32 +0000)
> > >>
> > >> are available in the Git repository at:
> > >>
> > >> https://github.com/jnsnow/qemu.git tags/ide-pull-request
> > >>
> > >> for you to fetch changes up to c35564caf20e8d3431786dddf0fa513daa7d7f3c:
> > >>
> > >> hd-geo-test: Add tests for lchs override (2019-10-31 06:11:34 -0400)
> > >>
> > >> ----------------------------------------------------------------
> > >> Pull request
> > >>
> > >
> > > Hi -- this passed the merge tests but it looks like you forgot
> > > to add your signed-off by line as the submaintainer to Sam's
> > > patches. Could you fix that up and resend, please?
> > >
> > > thanks
> > > -- PMM
> > >
> >
> > I bit myself twice with this now: adding --signoff to a pull request
> > signs the messages that get sent to list, but not the ones that get staged.
> >
> > Could always be a bug in my local copy, but I'm documenting it on the
> > list, in case I don't get time to look at this in the next 24h.
>
> Do you mean Signed-off-by is only added to emails that are sent and
> not to the actual commits in your repo?
>
> This is how git-format-patch(1) --signoff works. git-publish does not
> modify local commits either.
>
> Some people would probably be surprised if git-publish modified their
> commit history.
>
> I'm not sure what the best solution here is, aside from introducing a
> separate signoff option called --apply-signoff or similar so there is
> no confusion.
I would make git-publish error out if --signoff and
--pull-request are used simultaneously. I can't think of a
justification for having the email contents not match the git tag
contents in a pull request.
--
Eduardo
next prev parent reply other threads:[~2019-11-05 20:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 10:58 [PULL 0/9] Ide patches John Snow
2019-10-31 10:58 ` [PULL 1/9] IDE: deprecate ide-drive John Snow
2019-10-31 22:02 ` Paolo Bonzini
2019-11-01 5:40 ` Markus Armbruster
2019-11-01 7:12 ` Paolo Bonzini
2019-11-01 10:11 ` [libvirt] " Peter Krempa
2019-10-31 10:58 ` [PULL 2/9] block: Refactor macros - fix tabbing John Snow
2019-10-31 10:58 ` [PULL 3/9] block: Support providing LCHS from user John Snow
2019-10-31 10:58 ` [PULL 4/9] bootdevice: Add interface to gather LCHS John Snow
2019-10-31 10:59 ` [PULL 5/9] scsi: Propagate unrealize() callback to scsi-hd John Snow
2019-10-31 10:59 ` [PULL 6/9] bootdevice: Gather LCHS from all relevant devices John Snow
2019-10-31 10:59 ` [PULL 7/9] bootdevice: Refactor get_boot_devices_list John Snow
2019-10-31 10:59 ` [PULL 8/9] bootdevice: FW_CFG interface for LCHS values John Snow
2019-10-31 10:59 ` [PULL 9/9] hd-geo-test: Add tests for lchs override John Snow
2019-10-31 14:04 ` [libvirt] [PULL 0/9] Ide patches no-reply
2019-10-31 15:02 ` Peter Maydell
2019-10-31 15:45 ` John Snow
2019-10-31 15:54 ` git-publish, --pull-request and --signoff (was: Re: [PULL 0/9] Ide patches) John Snow
2019-11-05 19:38 ` Eduardo Habkost
2019-11-05 20:17 ` Stefan Hajnoczi
2019-11-05 20:22 ` Eduardo Habkost [this message]
2019-11-06 6:16 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105202242.GI3812@habkost.net \
--to=ehabkost@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).