From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 774E1C5DF62 for ; Wed, 6 Nov 2019 12:56:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 438F521848 for ; Wed, 6 Nov 2019 12:56:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 438F521848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57298 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSKrK-0007FD-G0 for qemu-devel@archiver.kernel.org; Wed, 06 Nov 2019 07:56:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34492) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSKqX-0006g4-W5 for qemu-devel@nongnu.org; Wed, 06 Nov 2019 07:55:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSKqW-0004D3-30 for qemu-devel@nongnu.org; Wed, 06 Nov 2019 07:55:37 -0500 Received: from 2.mo3.mail-out.ovh.net ([46.105.75.36]:38825) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSKqS-000471-Pl for qemu-devel@nongnu.org; Wed, 06 Nov 2019 07:55:34 -0500 Received: from player158.ha.ovh.net (unknown [10.108.54.52]) by mo3.mail-out.ovh.net (Postfix) with ESMTP id B59D022A3B3 for ; Wed, 6 Nov 2019 13:55:29 +0100 (CET) Received: from kaod.org (lns-bzn-46-82-253-208-248.adsl.proxad.net [82.253.208.248]) (Authenticated sender: groug@kaod.org) by player158.ha.ovh.net (Postfix) with ESMTPSA id C257ABB5AB5D; Wed, 6 Nov 2019 12:55:25 +0000 (UTC) Date: Wed, 6 Nov 2019 13:55:24 +0100 From: Greg Kurz To: Eduardo Habkost Subject: Re: [PATCH] numa: Add missing \n to error message Message-ID: <20191106135524.10147af8@bahia.lan> In-Reply-To: <157304440026.351774.14607704217028190097.stgit@bahia.lan> References: <157304440026.351774.14607704217028190097.stgit@bahia.lan> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 14033497917966489942 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedruddujedggeejucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdqfffguegfifdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthejredtredtvdenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdekvddrvdehfedrvddtkedrvdegkeenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrudehkedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.75.36 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Oops I hadn't realized that Marcel had a new e-mail address... since last year :-\ Sorry for the noise. On Wed, 06 Nov 2019 13:46:40 +0100 Greg Kurz wrote: > If memory allocation fails when using -mem-path, QEMU is supposed to print > out a message to indicate that fallback to anonymous RAM is deprecated. This > is done with error_printf() which does output buffering. As a consequence, > the message is only printed at the next flush, eg. when quiting QEMU, and > it also lacks a trailing newline: > > qemu-system-ppc64: unable to map backing store for guest RAM: Cannot allocate memory > qemu-system-ppc64: warning: falling back to regular RAM allocation > QEMU 4.1.50 monitor - type 'help' for more information > (qemu) q > This is deprecated. Make sure that -mem-path specified path has sufficient resources to allocate -m specified RAM amountgreg@boss02:~/Work/qemu/qemu-spapr$ > > Add the missing \n to fix both issues. > > Fixes: cb79224b7e4b "deprecate -mem-path fallback to anonymous RAM" > Signed-off-by: Greg Kurz > --- > hw/core/numa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/core/numa.c b/hw/core/numa.c > index 038c96d4abc6..e3332a984f7c 100644 > --- a/hw/core/numa.c > +++ b/hw/core/numa.c > @@ -503,7 +503,7 @@ static void allocate_system_memory_nonnuma(MemoryRegion *mr, Object *owner, > warn_report("falling back to regular RAM allocation"); > error_printf("This is deprecated. Make sure that -mem-path " > " specified path has sufficient resources to allocate" > - " -m specified RAM amount"); > + " -m specified RAM amount\n"); > /* Legacy behavior: if allocation failed, fall back to > * regular RAM allocation. > */ > >