From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FC8EC5DF63 for ; Wed, 6 Nov 2019 14:13:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6033C20663 for ; Wed, 6 Nov 2019 14:13:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6033C20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSM4C-0005CB-HX for qemu-devel@archiver.kernel.org; Wed, 06 Nov 2019 09:13:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:55278) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iSM3Q-0004fX-RK for qemu-devel@nongnu.org; Wed, 06 Nov 2019 09:13:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iSM3P-0000BL-Jm for qemu-devel@nongnu.org; Wed, 06 Nov 2019 09:13:00 -0500 Received: from 9.mo173.mail-out.ovh.net ([46.105.72.44]:51315) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iSM3P-00009q-DB for qemu-devel@nongnu.org; Wed, 06 Nov 2019 09:12:59 -0500 Received: from player714.ha.ovh.net (unknown [10.109.159.68]) by mo173.mail-out.ovh.net (Postfix) with ESMTP id BC4AD11CBD8 for ; Wed, 6 Nov 2019 15:12:56 +0100 (CET) Received: from kaod.org (deibp9eh1--blueice1n4.emea.ibm.com [195.212.29.166]) (Authenticated sender: groug@kaod.org) by player714.ha.ovh.net (Postfix) with ESMTPSA id 720D9BC12524; Wed, 6 Nov 2019 14:12:48 +0000 (UTC) Date: Wed, 6 Nov 2019 15:12:46 +0100 From: Greg Kurz To: Laurent Vivier Subject: Re: [PATCH] numa: Add missing \n to error message Message-ID: <20191106151246.2bf44314@bahia.lan> In-Reply-To: References: <157304440026.351774.14607704217028190097.stgit@bahia.lan> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Ovh-Tracer-Id: 15341512132197063128 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedufedruddujedgiedvucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdqfffguegfifdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfesthhqredtredtjeenucfhrhhomhepifhrvghgucfmuhhriicuoehgrhhouhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdduleehrddvuddvrddvledrudeiieenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjedugedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 46.105.72.44 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , qemu-trivial@nongnu.org, Markus Armbruster , qemu-devel@nongnu.org, Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 6 Nov 2019 14:01:01 +0100 Laurent Vivier wrote: > Le 06/11/2019 =C3=A0 13:46, Greg Kurz a =C3=A9crit=C2=A0: > > If memory allocation fails when using -mem-path, QEMU is supposed to pr= int > > out a message to indicate that fallback to anonymous RAM is deprecated.= This > > is done with error_printf() which does output buffering. As a consequen= ce, > > the message is only printed at the next flush, eg. when quiting QEMU, a= nd > > it also lacks a trailing newline: > >=20 > > qemu-system-ppc64: unable to map backing store for guest RAM: Cannot al= locate memory > > qemu-system-ppc64: warning: falling back to regular RAM allocation > > QEMU 4.1.50 monitor - type 'help' for more information > > (qemu) q > > This is deprecated. Make sure that -mem-path specified path has suffic= ient resources to allocate -m specified RAM amountgreg@boss02:~/Work/qemu/q= emu-spapr$ > >=20 > > Add the missing \n to fix both issues. > >=20 > > Fixes: cb79224b7e4b "deprecate -mem-path fallback to anonymous RAM" > > Signed-off-by: Greg Kurz > > --- > > hw/core/numa.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/hw/core/numa.c b/hw/core/numa.c > > index 038c96d4abc6..e3332a984f7c 100644 > > --- a/hw/core/numa.c > > +++ b/hw/core/numa.c > > @@ -503,7 +503,7 @@ static void allocate_system_memory_nonnuma(MemoryRe= gion *mr, Object *owner, > > warn_report("falling back to regular RAM allocation"); > > error_printf("This is deprecated. Make sure that -mem-path= " > > " specified path has sufficient resources to = allocate" > > - " -m specified RAM amount"); > > + " -m specified RAM amount\n"); > > /* Legacy behavior: if allocation failed, fall back to > > * regular RAM allocation. > > */ > >=20 > >=20 >=20 > Why is this an error_printf() and not an error_report()? >=20 Because CODING_STYLE suggests to do so I guess: Reporting errors to the human user ---------------------------------- Do not use printf(), fprintf() or monitor_printf(). Instead, use error_report() or error_vreport() from error-report.h. This ensures the error is reported in the right place (current monitor or stderr), and in a uniform format. Use error_printf() & friends to print additional information. <=3D=3D=3D error_report() prints the current location. In certain common cases like command line parsing, the current location is tracked automatically. To manipulate it manually, use the loc_``*``() from error-report.h. > Thanks, > Laurent >=20