From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB8C6FA372C for ; Fri, 8 Nov 2019 10:32:58 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A88F821848 for ; Fri, 8 Nov 2019 10:32:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AVVs3aWX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A88F821848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT1ZZ-0003NW-PM for qemu-devel@archiver.kernel.org; Fri, 08 Nov 2019 05:32:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50191) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT1Yi-0002ra-Hf for qemu-devel@nongnu.org; Fri, 08 Nov 2019 05:32:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iT1Yh-0006y2-FL for qemu-devel@nongnu.org; Fri, 08 Nov 2019 05:32:04 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:30892 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iT1Yh-0006xs-CF for qemu-devel@nongnu.org; Fri, 08 Nov 2019 05:32:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573209123; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GFHSXNJC5NT0kZ6nMuiwYQt36iFgQnx1dgvcXbrxwBA=; b=AVVs3aWX6cOOjeOFkGoNd/0Zf/UraPvK6qv5Z8ZMTTJcpWhX5VZz85s8Ths/PomAbSCMVq aauVXaIkSPE0yhW847kw+KcjKVU3EFpiGWBzW0+jfMpb0VGa4gYKdwtzWqr+31u1Cp8LBU wc0XyrOlOduSNQprSNC7hffIdtz7tL8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-287-SbahawIxOk229rDabHf5Dw-1; Fri, 08 Nov 2019 05:31:59 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 241BB800C72; Fri, 8 Nov 2019 10:31:58 +0000 (UTC) Received: from redhat.com (ovpn-112-63.ams2.redhat.com [10.36.112.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7420D6084E; Fri, 8 Nov 2019 10:31:50 +0000 (UTC) Date: Fri, 8 Nov 2019 10:31:47 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH] configure: Check bzip2 is available Message-ID: <20191108103147.GC182396@redhat.com> References: <20191108102805.8258-1-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191108102805.8258-1-philmd@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: SbahawIxOk229rDabHf5Dw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-trivial@nongnu.org, Thomas Huth , Laszlo Ersek , qemu-devel@nongnu.org, Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Nov 08, 2019 at 11:28:05AM +0100, Philippe Mathieu-Daud=C3=A9 wrote= : > The bzip2 tool is not included in default installations. > On freshly installed systems, ./configure succeeds but 'make' > might fail later: >=20 > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > /bin/sh: bzip2: command not found > make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 > make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd' > make: *** Waiting for unfinished jobs.... >=20 > Add a check in ./configure to warn the user if bzip2 is missing. >=20 > Fixes: 536d2173b2b > Reported-by: Thomas Huth > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > --- > configure | 7 +++++++ > 1 file changed, 7 insertions(+) >=20 > diff --git a/configure b/configure > index efe165edf9..9957e913e8 100755 > --- a/configure > +++ b/configure > @@ -1851,6 +1851,13 @@ python_version=3D$($python -c 'import sys; print("= %d.%d.%d" % (sys.version_info[0] > # Suppress writing compiled files > python=3D"$python -B" > =20 > +# Some firmware binaries are compressed with bzip2 > +if has bzip2; then > + : > +else > + error_exit "bzip2 program not found. Please install it" > +fi Nitpick, I'd phrase this as "The bzip2 program is required for building QEMU" Either way though Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|