From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67DA0FA372C for ; Fri, 8 Nov 2019 11:06:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 31661206BA for ; Fri, 8 Nov 2019 11:06:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="CWDHleYS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 31661206BA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:52416 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT26I-0000hY-Dv for qemu-devel@archiver.kernel.org; Fri, 08 Nov 2019 06:06:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57594) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iT25B-0008OS-U2 for qemu-devel@nongnu.org; Fri, 08 Nov 2019 06:05:39 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iT256-00066b-M5 for qemu-devel@nongnu.org; Fri, 08 Nov 2019 06:05:37 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:44155 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iT256-00065w-DF for qemu-devel@nongnu.org; Fri, 08 Nov 2019 06:05:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573211132; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8QKCahovK7Kq4ddTNQvVxg9K2BLVVX/HgM3FMJOLUTM=; b=CWDHleYSngvGuEb6Js7LGs6ZdvrVtNNgQ/HpodJoxYj9Xp1st3adFH/UCwrvq5yATb2Wi8 Ydbl7VynmXKTk+Fhtfd9gezC2GmCckvz9cM3TGe+/S9ZDdr0I/aRhEHyOWAehLKqVss2cE 5uhQcmPbLdcpEYeXsZSFSvh8eb2Yk4M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-344-ra0git6rOjmKpPaQkqThXw-1; Fri, 08 Nov 2019 06:05:30 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A1ED8107ACC3; Fri, 8 Nov 2019 11:05:29 +0000 (UTC) Received: from redhat.com (ovpn-112-63.ams2.redhat.com [10.36.112.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA6115D6B7; Fri, 8 Nov 2019 11:05:22 +0000 (UTC) Date: Fri, 8 Nov 2019 11:05:20 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Laszlo Ersek Subject: Re: [PATCH] configure: Check bzip2 is available Message-ID: <20191108110520.GG182396@redhat.com> References: <20191108102805.8258-1-philmd@redhat.com> <862eb773-609d-4250-b46b-d922fc5a86a7@redhat.com> MIME-Version: 1.0 In-Reply-To: <862eb773-609d-4250-b46b-d922fc5a86a7@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-MC-Unique: ra0git6rOjmKpPaQkqThXw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: qemu-trivial@nongnu.org, Thomas Huth , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Nov 08, 2019 at 12:01:16PM +0100, Laszlo Ersek wrote: > On 11/08/19 11:28, Philippe Mathieu-Daud=C3=A9 wrote: > > The bzip2 tool is not included in default installations. > > On freshly installed systems, ./configure succeeds but 'make' > > might fail later: > >=20 > > BUNZIP2 pc-bios/edk2-i386-secure-code.fd.bz2 > > /bin/sh: bzip2: command not found > > make: *** [Makefile:305: pc-bios/edk2-i386-secure-code.fd] Error 127 > > make: *** Deleting file 'pc-bios/edk2-i386-secure-code.fd' > > make: *** Waiting for unfinished jobs.... > >=20 > > Add a check in ./configure to warn the user if bzip2 is missing. >=20 > We've come full circle. Let me explain: >=20 > >=20 > > Fixes: 536d2173b2b >=20 > So this makes me kinda grumpy. If you look at the v3 posting of the patch= that would later become commit 536d2173b2b: >=20 > http://mid.mail-archive.com/20190321113408.19929-8-lersek@redhat.com >=20 > you see the following note in the changelog: >=20 > - compress FD files with bzip2 rather than xz, so that decompression = at > "make install" time succeed on older build OSes too [Peter] >=20 > So I couldn't use xz because that was "too new" for some build OSes, but = now we also can't take bzip2 for granted because that's "too old" for some = other build OSes? This is ridiculous. We're not saying bzip2 is too old / missing from the OS. Every OS we care about has bzip2. The problem is that a minimal installation migt not have installed it. This kind of problem is increasingly common with use of minimal container images for example. So we're just ensuring we validate that what we want is actuall present. Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|