From: Peter Krempa <firstname.lastname@example.org> To: Vladimir Sementsov-Ogievskiy <email@example.com> Cc: "firstname.lastname@example.org" <email@example.com>, "firstname.lastname@example.org" <email@example.com>, Denis Lunev <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org>, "email@example.com" <firstname.lastname@example.org> Subject: Re: [PATCH v2 2/2] qapi: deprecate implicit filters Date: Fri, 8 Nov 2019 15:18:57 +0100 Message-ID: <20191108141857.GJ9577@angien.pipo.sk> (raw) In-Reply-To: <email@example.com> On Fri, Nov 08, 2019 at 13:56:03 +0000, Vladimir Sementsov-Ogievskiy wrote: > 08.11.2019 16:27, Peter Krempa wrote: > > On Fri, Nov 08, 2019 at 13:16:55 +0300, Vladimir Sementsov-Ogievskiy wrote: [...] > > Note that 'block-commit' and 'drive-mirror' commands are used by libvirt > > in the pre-blockdev era. In those instances we gather statistics of > > block devices by nesting in the output of query-blockstats and > > query-block rather than selecting the appropriate info by any other > > means (e.g. by node name). > > > > This means that the output MUST stay consistend when block jobs are used > > and the hack this patch is deprcating will break those. > > > > Note that in libvirt we don't plan to invest time to add workarounds for > > non-blockdev cases since blockdev by itself is complex enough and I'd > > strongly prefer not having a third code path to care about. > > > > Given that -blockdev can't be used in all cases (e.g. for sd-cards) > > which also blocks deprecation of -drive I don't think that hiding of > > implicit filter nodes can be deprecated until -drive is deprecated. > > > > > OK, so, we can't deprecate anything around it now. > > What is the problem with sd-cards? So the problem was that it was impossible to instantiate it via -device, but looking at the qemu code base this doesn't seem to be true any more. I'll have a look whether we can rework the instantiation of sd card frontends in libvirt somehow or whether it actually ever worked. Unfortunately the documentation seems to be rather sparse.
next prev parent reply index Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-08 10:16 [PATCH v2 0/2] Deprecate " Vladimir Sementsov-Ogievskiy 2019-11-08 10:16 ` [PATCH v2 1/2] qapi: add filter-node-name option to drive-mirror Vladimir Sementsov-Ogievskiy 2019-11-08 13:30 ` Peter Krempa 2019-11-08 10:16 ` [PATCH v2 2/2] qapi: deprecate implicit filters Vladimir Sementsov-Ogievskiy 2019-11-08 13:27 ` Peter Krempa 2019-11-08 13:56 ` Vladimir Sementsov-Ogievskiy 2019-11-08 14:18 ` Peter Krempa [this message] 2019-11-08 12:00 ` [PATCH v2 0/2] Deprecate " no-reply 2019-11-08 12:17 ` Vladimir Sementsov-Ogievskiy 2019-11-08 13:06 ` Maxim Levitsky
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191108141857.GJ9577@angien.pipo.sk \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
QEMU-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/qemu-devel/0 qemu-devel/git/0.git git clone --mirror https://lore.kernel.org/qemu-devel/1 qemu-devel/git/1.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 qemu-devel qemu-devel/ https://lore.kernel.org/qemu-devel \ email@example.com public-inbox-index qemu-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.nongnu.qemu-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git