From: Stefan Hajnoczi <stefanha@redhat.com>
To: Denis Plotnikov <dplotnikov@virtuozzo.com>
Cc: den@virtuozzo.com, qemu-devel@nongnu.org, qemu-block@nongnu.org,
mst@redhat.com
Subject: Re: [PATCH v2 1/1] virtio: make seg_max virtqueue size dependent
Date: Mon, 11 Nov 2019 11:19:03 +0000 [thread overview]
Message-ID: <20191111111903.GD442334@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191108134249.19004-2-dplotnikov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Fri, Nov 08, 2019 at 04:42:49PM +0300, Denis Plotnikov wrote:
> + virtio_stl_p(vdev, &blkcfg.seg_max, s->conf.queue_size - 2);
[...]
> + virtio_stl_p(vdev, &scsiconf->seg_max, s->conf.virtqueue_size - 2);
Please extend the queue_size checks to report an error when queue_size
<= 2.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-11-11 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 13:42 [PATCH v2 0/1] virtio: fix IO request length in virtio SCSI/block Denis Plotnikov
2019-11-08 13:42 ` [PATCH v2 1/1] virtio: make seg_max virtqueue size dependent Denis Plotnikov
2019-11-08 14:26 ` Michael S. Tsirkin
2019-11-11 11:19 ` Stefan Hajnoczi [this message]
2019-11-11 11:20 ` Denis Plotnikov
2019-11-08 19:43 ` [PATCH v2 0/1] virtio: fix IO request length in virtio SCSI/block no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111111903.GD442334@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=den@virtuozzo.com \
--cc=dplotnikov@virtuozzo.com \
--cc=mst@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).