qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: peter.maydell@linaro.org
Cc: "Corey Minyard" <cminyard@mvista.com>,
	"Kamil Rytarowski" <kamil@netbsd.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org
Subject: [PULL 5/8] tests: only run ipmi-bt-test if CONFIG_LINUX
Date: Tue, 12 Nov 2019 14:50:25 +0000	[thread overview]
Message-ID: <20191112145028.26386-6-alex.bennee@linaro.org> (raw)
In-Reply-To: <20191112145028.26386-1-alex.bennee@linaro.org>

This test has been unstable on NetBSD for awhile. It seems the
mechanism used to listen to a random port is a Linux-ism (although a
received wisdom Linux-ism rather than a well documented one). As
working around would add more hard to test complexity to the test I've
gone for the easier option of making it CONFIG_LINUX only.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Corey Minyard <cminyard@mvista.com>
Cc: Kamil Rytarowski <kamil@netbsd.org>

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 534ee487436..8566f5f119d 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -177,7 +177,9 @@ check-qtest-i386-$(CONFIG_SGA) += tests/boot-serial-test$(EXESUF)
 check-qtest-i386-$(CONFIG_SLIRP) += tests/pxe-test$(EXESUF)
 check-qtest-i386-y += tests/rtc-test$(EXESUF)
 check-qtest-i386-$(CONFIG_ISA_IPMI_KCS) += tests/ipmi-kcs-test$(EXESUF)
+ifdef CONFIG_LINUX
 check-qtest-i386-$(CONFIG_ISA_IPMI_BT) += tests/ipmi-bt-test$(EXESUF)
+endif
 check-qtest-i386-y += tests/i440fx-test$(EXESUF)
 check-qtest-i386-y += tests/fw_cfg-test$(EXESUF)
 check-qtest-i386-y += tests/device-plug-test$(EXESUF)
-- 
2.20.1



  parent reply	other threads:[~2019-11-12 14:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 14:50 [PULL 0/8] testing and tcg plugin api ver Alex Bennée
2019-11-12 14:50 ` [PULL 1/8] tests/vm: netbsd autoinstall, using serial console Alex Bennée
2019-11-12 14:50 ` [PULL 2/8] tests/vm: add console_consume helper Alex Bennée
2019-11-12 14:50 ` [PULL 3/8] tests/vm: use console_consume for netbsd Alex Bennée
2019-11-12 14:50 ` [PULL 4/8] tests/vm: update netbsd to version 8.1 Alex Bennée
2019-11-12 14:50 ` Alex Bennée [this message]
2019-11-12 14:50 ` [PULL 6/8] tests/vm: support sites with sha512 checksums Alex Bennée
2019-11-12 14:50 ` [PULL 7/8] .travis.yml: don't run make check with multiple jobs Alex Bennée
2019-11-12 14:50 ` [PULL 8/8] tcg plugins: expose an API version concept Alex Bennée
2019-11-12 16:01 ` [PULL 0/8] testing and tcg plugin api ver Peter Maydell
2019-11-12 16:22   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112145028.26386-6-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=cminyard@mvista.com \
    --cc=kamil@netbsd.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).