From: Alex Williamson <alex.williamson@redhat.com>
To: Jens Freimann <jfreimann@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] vfio: don't ignore return value of migrate_add_blocker
Date: Tue, 19 Nov 2019 16:19:45 -0700 [thread overview]
Message-ID: <20191119161945.729e45d9@x1.home> (raw)
In-Reply-To: <20191114133449.11536-1-jfreimann@redhat.com>
On Thu, 14 Nov 2019 14:34:49 +0100
Jens Freimann <jfreimann@redhat.com> wrote:
> When an error occurs in migrate_add_blocker() it sets a
> negative return value and uses error pointer we pass in.
> Instead of just looking at the error pointer check for a negative return
> value and avoid a coverity error because the return value is
> set but never used. This fixes CID 1407219.
>
> Fixes: f045a0104c8c ("vfio: unplug failover primary device before
> migration")
> Signed-off-by: Jens Freimann <jfreimann@redhat.com>
> ---
> hw/vfio/pci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index e6569a7968..ed01774673 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -2737,7 +2737,7 @@ static void vfio_realize(PCIDevice *pdev, Error **errp)
> error_setg(&vdev->migration_blocker,
> "VFIO device doesn't support migration");
> ret = migrate_add_blocker(vdev->migration_blocker, &err);
> - if (err) {
> + if (ret) {
> error_propagate(errp, err);
> error_free(vdev->migration_blocker);
> return;
Slightly late notice, but I did include this in my last pull request
and it's included in v4.2.0-rc2 with Stefano and Philippe's R-b.
Thanks,
Alex
prev parent reply other threads:[~2019-11-19 23:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 13:34 [PATCH] vfio: don't ignore return value of migrate_add_blocker Jens Freimann
2019-11-14 13:39 ` Philippe Mathieu-Daudé
2019-11-15 8:59 ` Stefano Garzarella
2019-11-19 23:19 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119161945.729e45d9@x1.home \
--to=alex.williamson@redhat.com \
--cc=jfreimann@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).