On Wed, Nov 20, 2019 at 09:00:32AM +1100, David Gibson wrote: > On Wed, Nov 20, 2019 at 08:56:18AM +1100, David Gibson wrote: > > On Tue, Nov 19, 2019 at 11:20:53PM +0530, Balamuruhan S wrote: > > > homer/occ sizes are calculated in skiboot with `(mask | 0xfffff) + 1`, > > > and from xscom access should return correct mask values instead of actual > > > sizes. > > > > > > Signed-off-by: Cédric Le Goater > > > Signed-off-by: Balamuruhan S > > > --- > > > hw/ppc/pnv_xscom.c | 10 ++++++---- > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > diff --git a/hw/ppc/pnv_xscom.c b/hw/ppc/pnv_xscom.c > > > index f01d788a65..cdd5fa356e 100644 > > > --- a/hw/ppc/pnv_xscom.c > > > +++ b/hw/ppc/pnv_xscom.c > > > @@ -46,6 +46,10 @@ > > > #define P9_PBA_BARMASK0 0x5012b04 > > > #define P9_PBA_BARMASK2 0x5012b06 > > > > > > +/* Mask to calculate Homer/Occ size */ > > > +#define HOMER_SIZE_MASK 0x0000000000300000ull > > > +#define OCC_SIZE_MASK 0x0000000000700000ull > > > > Uuuhhhhh... AFAICT these defines have identical values to > > PNV_HOMER_SIZE and PNV_OCC_COMMON_AREA_SIZE, so I don't see what this > > patch is actually changing. > > Oh, sorry, missed that the values were changed in 1/5. Would have > been easier to follow if the two patches were folded together, but > never mind. Applied. Ugh.. or not. The first patch doesn't apply for me, looks like it needs a rebase (or you have something else in your tree I don't know about). -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson