From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 257CCC432C0 for ; Wed, 20 Nov 2019 18:30:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4CF8206DA for ; Wed, 20 Nov 2019 18:29:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="aKjB1SVU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4CF8206DA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:33374 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXUjm-0000CP-S8 for qemu-devel@archiver.kernel.org; Wed, 20 Nov 2019 13:29:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXUfx-0003EH-Kj for qemu-devel@nongnu.org; Wed, 20 Nov 2019 13:26:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXUfw-00084T-A2 for qemu-devel@nongnu.org; Wed, 20 Nov 2019 13:26:01 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:28614 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iXUfw-00084B-67 for qemu-devel@nongnu.org; Wed, 20 Nov 2019 13:26:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574274359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=csxZhkE8TSH+AtiiFrlqHAX5AroQH9R55yp+19w0ntw=; b=aKjB1SVUI1ntXcWRekvXxWkAYgjTyJvXbLDdBezG6+4qIlOqmsiIwgK34MP8pWlkSbIhK5 FkRC4SHoasUnlA708YksbuG/grgPBqITUhVnxKkwRbjzdcaGpELVRqRL7FpzJYxrB8OKA0 SpjluACIr5ptlCIT63k9bjNSmewd3T4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-193-0HAL1KOyMs6GI7GCGt9waw-1; Wed, 20 Nov 2019 13:25:54 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 481D9801E6A; Wed, 20 Nov 2019 18:25:53 +0000 (UTC) Received: from blackfin.pond.sub.org (unknown [10.36.118.163]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7B485ED36; Wed, 20 Nov 2019 18:25:52 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 5525A1138606; Wed, 20 Nov 2019 19:25:51 +0100 (CET) From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH 0/6] qapi: Module fixes and cleanups Date: Wed, 20 Nov 2019 19:25:45 +0100 Message-Id: <20191120182551.23795-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 0HAL1KOyMs6GI7GCGt9waw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, kwolf@pond.sub.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Kevin recently posted a minimally invasive fix for empty QAPI modules[*]. This is my attempt at a fix that also addresses the design weakness that led to the bug. Markus Armbruster (6): qapi: Tweak "command returns a nice type" check for clarity tests/Makefile.include: Fix missing test-qapi-emit-events.[ch] qapi: Generate command registration stuff into separate files qapi: Proper intermediate representation for modules qapi: Fix code generation for empty modules qapi: Simplify QAPISchemaModularCVisitor docs/devel/qapi-code-gen.txt | 19 ++++- Makefile | 4 +- monitor/misc.c | 7 +- qga/main.c | 2 +- tests/test-qmp-cmds.c | 1 + .gitignore | 1 + qapi/Makefile.objs | 1 + qga/Makefile.objs | 1 + scripts/qapi/commands.py | 17 +++-- scripts/qapi/events.py | 2 +- scripts/qapi/gen.py | 28 ++++---- scripts/qapi/schema.py | 92 +++++++++++++++--------- scripts/qapi/types.py | 5 +- scripts/qapi/visit.py | 8 +-- tests/.gitignore | 1 + tests/Makefile.include | 9 ++- tests/qapi-schema/empty.out | 1 + tests/qapi-schema/include-repetition.out | 6 +- tests/qapi-schema/qapi-schema-test.out | 24 +++---- 19 files changed, 144 insertions(+), 85 deletions(-) --=20 2.21.0