From: Kevin Wolf <kwolf@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: "Peter Krempa" <pkrempa@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
qemu-devel@nongnu.org, "John Ferlan" <jferlan@redhat.com>,
"Maxim Levitsky" <mlevitsk@redhat.com>,
"John Snow" <jsnow@redhat.com>
Subject: Re: API definition for LUKS key management [V2]
Date: Tue, 26 Nov 2019 15:24:25 +0100 [thread overview]
Message-ID: <20191126142425.GB5889@linux.fritz.box> (raw)
In-Reply-To: <0b5fec2a-1d93-7e31-55d2-1a80bde89f0b@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]
Am 25.11.2019 um 19:45 hat Max Reitz geschrieben:
> On 22.11.19 15:22, Maxim Levitsky wrote:
> > Hi!
> >
> > This is the second version of the proposed QMP API for key management,
> > after discussion with Keven and Max.
> >
> > Will this work?
> >
> > Adding Peter Krempa to CC, to hear his opinion from the
> > libvirt side.
> >
> > Best regards,
> > Maxim Levitsky
>
> Looks good to me overall. I don’t think we need to overly push having
> the same interface for create and amend, because I don’t see much to be
> gained from it.
>
> [...]
>
> > diff --git a/qapi/crypto.json b/qapi/crypto.json
> > index b2a4cff683..019db682cd 100644
> > --- a/qapi/crypto.json
> > +++ b/qapi/crypto.json
> > @@ -309,3 +309,56 @@
> > 'base': 'QCryptoBlockInfoBase',
> > 'discriminator': 'format',
> > 'data': { 'luks': 'QCryptoBlockInfoLUKS' } }
> > +
> > +
> > +##
> > +# @LUKSKeyslotUpdate:
> > +#
> > +# @keyslot: If specified, will update only keyslot with this index
> > +#
> > +# @old-secret: If specified, will only update keyslots that
> > +# can be opened with password which is contained in
> > +# QCryptoSecret with @old-secret ID
> > +#
> > +# If neither @keyslot nor @old-secret is specified,
> > +# first empty keyslot is selected for the update
> > +#
> > +# @new-secret: The ID of a QCryptoSecret object providing a new decryption
> > +# key to place in all matching keyslots. Empty string erases the
> > +# keyslot.
>
> Hm... Can’t we make this some string-or-null alternate type so that
> null will erase the keyslot? That would make more sense to me.
The only problem is that it doesn't map nicely to the command line.
Kevin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2019-11-26 14:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 15:58 API definition for LUKS key management Maxim Levitsky
2019-11-11 18:34 ` Daniel P. Berrangé
2019-11-12 9:12 ` Kevin Wolf
2019-11-12 10:47 ` Max Reitz
2019-11-12 11:02 ` Daniel P. Berrangé
2019-11-14 10:54 ` Maxim Levitsky
2019-11-14 10:58 ` Maxim Levitsky
2019-11-14 10:37 ` Maxim Levitsky
2019-11-12 10:02 ` Daniel P. Berrangé
2019-11-22 14:22 ` API definition for LUKS key management [V2] Maxim Levitsky
2019-11-25 18:45 ` Max Reitz
2019-11-26 9:28 ` Maxim Levitsky
2019-11-26 14:24 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191126142425.GB5889@linux.fritz.box \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=jferlan@redhat.com \
--cc=jsnow@redhat.com \
--cc=mlevitsk@redhat.com \
--cc=mreitz@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).