From: Greg Kurz <groug@kaod.org>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v6] 9pfs: well form error hint helpers
Date: Wed, 27 Nov 2019 23:37:42 +0100 [thread overview]
Message-ID: <20191127233742.198e00f7@bahia.w3ibm.bluemix.net> (raw)
In-Reply-To: <20191127191549.21216-1-vsementsov@virtuozzo.com>
On Wed, 27 Nov 2019 22:15:49 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> Make error_append_security_model_hint and
> error_append_socket_sockfd_hint hint append helpers well formed:
> rename errp to errp_in, as it is IN-parameter here (which is unusual
> for errp).
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> Acked-by: Greg Kurz <groug@kaod.org>
> ---
>
> v6: add Greg's a-b
>
I've already pushed that to my 9p-next branch:
https://github.com/gkurz/qemu/commits/9p-next
> hw/9pfs/9p-local.c | 4 ++--
> hw/9pfs/9p-proxy.c | 5 +++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
> index 4708c0bd89..76fa1858b7 100644
> --- a/hw/9pfs/9p-local.c
> +++ b/hw/9pfs/9p-local.c
> @@ -1473,9 +1473,9 @@ static void local_cleanup(FsContext *ctx)
> g_free(data);
> }
>
> -static void error_append_security_model_hint(Error **errp)
> +static void error_append_security_model_hint(Error **errp_in)
> {
> - error_append_hint(errp, "Valid options are: security_model="
> + error_append_hint(errp_in, "Valid options are: security_model="
> "[passthrough|mapped-xattr|mapped-file|none]\n");
> }
>
> diff --git a/hw/9pfs/9p-proxy.c b/hw/9pfs/9p-proxy.c
> index 97ab9c58a5..9e29abc3ef 100644
> --- a/hw/9pfs/9p-proxy.c
> +++ b/hw/9pfs/9p-proxy.c
> @@ -1114,9 +1114,10 @@ static int connect_namedsocket(const char *path, Error **errp)
> return sockfd;
> }
>
> -static void error_append_socket_sockfd_hint(Error **errp)
> +static void error_append_socket_sockfd_hint(Error **errp_in)
> {
> - error_append_hint(errp, "Either specify socket=/some/path where /some/path"
> + error_append_hint(errp_in,
> + "Either specify socket=/some/path where /some/path"
> " points to a listening AF_UNIX socket or sock_fd=fd"
> " where fd is a file descriptor to a connected AF_UNIX"
> " socket\n");
next prev parent reply other threads:[~2019-11-27 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 19:15 [PATCH v6] 9pfs: well form error hint helpers Vladimir Sementsov-Ogievskiy
2019-11-27 22:37 ` Greg Kurz [this message]
2019-12-02 9:36 ` Vladimir Sementsov-Ogievskiy
2019-12-03 9:49 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127233742.198e00f7@bahia.w3ibm.bluemix.net \
--to=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).