From: Cornelia Huck <cohuck@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: frankja@linux.ibm.com, david@redhat.com, qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, Claudio Imbrenda <imbrenda@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii
Date: Thu, 28 Nov 2019 14:16:03 +0100 [thread overview]
Message-ID: <20191128141603.7286e288.cohuck@redhat.com> (raw)
In-Reply-To: <5f3f505a-7bcd-d8ee-a4df-c9bf658955af@redhat.com>
On Thu, 28 Nov 2019 14:11:38 +0100
Thomas Huth <thuth@redhat.com> wrote:
> On 28/11/2019 13.35, Christian Borntraeger wrote:
> > Ack.
> >
> > Conny, I think this would be really nice to have for 4.2 (together with a bios rebuild)
> > as this fixes a regression. Opinions?
>
> If we do another rc of 4.2, I think we definitely want this to be
> included, otherwise quite a bunch of things don't work anymore as
> expected, e.g. "-boot menu=on"...
I do agree we want this if possible; the question is really the
"possible" part...
>
> >> diff --git a/pc-bios/s390-ccw/sclp.c b/pc-bios/s390-ccw/sclp.c
> >> index c0223fa..7251f9a 100644
> >> --- a/pc-bios/s390-ccw/sclp.c
> >> +++ b/pc-bios/s390-ccw/sclp.c
> >> @@ -112,7 +112,7 @@ void sclp_get_loadparm_ascii(char *loadparm)
> >> ReadInfo *sccb = (void *)_sccb;
> >>
> >> memset((char *)_sccb, 0, sizeof(ReadInfo));
> >> - sccb->h.length = sizeof(ReadInfo);
> >> + sccb->h.length = SCCB_SIZE;
> >> if (!sclp_service_call(SCLP_CMDW_READ_SCP_INFO, sccb)) {
> >> ebcdic_to_ascii((char *) sccb->loadparm, loadparm, LOADPARM_LEN);
> >> }
>
> I gave it a quick try, and this fixes "-boot menu=on" for me, so:
>
> Tested-by: Thomas Huth <thuth@redhat.com>
Thanks.
FWIW, I'm currently working to put this + the rebuild on my s390-fixes
branch.
next prev parent reply other threads:[~2019-11-28 13:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 12:33 [PATCH v1 1/1] pc-bios/s390-ccw: fix sclp_get_loadparm_ascii Claudio Imbrenda
2019-11-28 12:35 ` Christian Borntraeger
2019-11-28 12:45 ` Cornelia Huck
2019-11-28 12:48 ` Christian Borntraeger
2019-11-28 15:05 ` Peter Maydell
2019-11-29 7:38 ` Christian Borntraeger
2019-11-29 8:10 ` Thomas Huth
2019-11-28 13:11 ` Thomas Huth
2019-11-28 13:16 ` Cornelia Huck [this message]
2019-11-28 14:45 ` Christian Borntraeger
2019-11-28 12:37 ` Janosch Frank
2019-11-28 12:44 ` Marc Hartmayer
2019-11-28 12:44 ` Claudio Imbrenda
2019-11-28 13:32 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128141603.7286e288.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=imbrenda@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).