From: Felipe Franciosi <felipe@nutanix.com>
To: Marc-Andre Lureau <marcandre.lureau@gmail.com>,
Philippe Mathieu-Daude <philmd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Felipe Franciosi <felipe@nutanix.com>
Subject: [PATCH v2 2/4] ich9: fix getter type for sci_int property
Date: Thu, 28 Nov 2019 16:48:29 +0000 [thread overview]
Message-ID: <20191128164810.54279-3-felipe@nutanix.com> (raw)
In-Reply-To: <20191128164810.54279-1-felipe@nutanix.com>
When QOM APIs were added to ich9 in 6f1426ab, the getter for sci_int was
written using uint32_t. However, the object property is uint8_t. This
fixes the getter for correctness.
Signed-off-by: Felipe Franciosi <felipe@nutanix.com>
---
hw/isa/lpc_ich9.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
index f5526f9c3b..3a9c4f0503 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
@@ -631,9 +631,7 @@ static void ich9_lpc_get_sci_int(Object *obj, Visitor *v, const char *name,
void *opaque, Error **errp)
{
ICH9LPCState *lpc = ICH9_LPC_DEVICE(obj);
- uint32_t value = lpc->sci_gsi;
-
- visit_type_uint32(v, name, &value, errp);
+ visit_type_uint8(v, name, &lpc->sci_gsi, errp);
}
static void ich9_lpc_add_properties(ICH9LPCState *lpc)
@@ -641,7 +639,7 @@ static void ich9_lpc_add_properties(ICH9LPCState *lpc)
static const uint8_t acpi_enable_cmd = ICH9_APM_ACPI_ENABLE;
static const uint8_t acpi_disable_cmd = ICH9_APM_ACPI_DISABLE;
- object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint32",
+ object_property_add(OBJECT(lpc), ACPI_PM_PROP_SCI_INT, "uint8",
ich9_lpc_get_sci_int,
NULL, NULL, NULL, NULL);
object_property_add_uint8_ptr(OBJECT(lpc), ACPI_PM_PROP_ACPI_ENABLE_CMD,
--
2.20.1
next prev parent reply other threads:[~2019-11-28 19:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 16:48 [PATCH v2 0/4] Improve default object property_add uint helpers Felipe Franciosi
2019-11-28 16:48 ` [PATCH v2 1/4] qom/object: enable setter for uint types Felipe Franciosi
2019-11-28 20:35 ` Marc-André Lureau
2019-11-29 15:14 ` Felipe Franciosi
2019-11-29 15:35 ` Marc-André Lureau
2019-11-29 16:25 ` Felipe Franciosi
2019-11-29 16:29 ` Marc-André Lureau
2019-11-28 16:48 ` Felipe Franciosi [this message]
2019-11-29 8:05 ` [PATCH v2 2/4] ich9: fix getter type for sci_int property Marc-André Lureau
2019-11-28 16:48 ` [PATCH v2 3/4] ich9: Simplify ich9_lpc_initfn Felipe Franciosi
2019-11-28 16:48 ` [PATCH v2 4/4] qom/object: Use common get/set uint helpers Felipe Franciosi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191128164810.54279-3-felipe@nutanix.com \
--to=felipe@nutanix.com \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).