From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC16BC432C0 for ; Fri, 29 Nov 2019 09:47:52 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6F5F215F1 for ; Fri, 29 Nov 2019 09:47:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cyI4Q21Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B6F5F215F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:56468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iacsR-0001WE-TW for qemu-devel@archiver.kernel.org; Fri, 29 Nov 2019 04:47:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56772) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iacgk-000248-NS for qemu-devel@nongnu.org; Fri, 29 Nov 2019 04:35:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iacgg-00018y-7i for qemu-devel@nongnu.org; Fri, 29 Nov 2019 04:35:43 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:51521 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iacgg-00013x-2K for qemu-devel@nongnu.org; Fri, 29 Nov 2019 04:35:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575020136; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DMsZARe2XDdIVriaT1Gq502tc7sHsm5MBzXp838lYsU=; b=cyI4Q21YuIniR2qFQuoGcfMU9hw6DrsJ2mP3ucoGox/FcaTBM085usOOkynCESZPvn3L8L 5Qz+WWMZfzCARFui6wZfY86GkL0MMn+Jg6zThB2iQeJtD+NK+yxozclRtlj1Wbhz4339jY TBq6gZMRpoCVen35V1gw/nJWI1xULHA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-395-B510O55nOeCYx6q8vYYNlQ-1; Fri, 29 Nov 2019 04:35:33 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD50C80183C; Fri, 29 Nov 2019 09:35:31 +0000 (UTC) Received: from redhat.com (ovpn-112-31.ams2.redhat.com [10.36.112.31]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 135C110013A7; Fri, 29 Nov 2019 09:35:29 +0000 (UTC) Date: Fri, 29 Nov 2019 09:35:26 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Cornelia Huck Subject: Re: [PATCH v2] qga: fence guest-set-time if hwclock not available Message-ID: <20191129093526.GC2260471@redhat.com> References: <20191128181100.23187-1-cohuck@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191128181100.23187-1-cohuck@redhat.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-MC-Unique: B510O55nOeCYx6q8vYYNlQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Laszlo Ersek , Michael Roth , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Nov 28, 2019 at 07:11:00PM +0100, Cornelia Huck wrote: > The Posix implementation of guest-set-time invokes hwclock to > set/retrieve the time to/from the hardware clock. If hwclock > is not available, the user is currently informed that "hwclock > failed to set hardware clock to system time", which is quite > misleading. This may happen e.g. on s390x, which has a different > timekeeping concept anyway. >=20 > Let's check for the availability of the hwclock command and > return QERR_UNSUPPORTED for guest-set-time if it is not available. >=20 > Signed-off-by: Cornelia Huck > --- >=20 > v1 (RFC) -> v2: > - use hwclock_path[] > - use access() instead of stat() >=20 > --- > qga/commands-posix.c | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrang=C3=A9 Regards, Daniel --=20 |: https://berrange.com -o- https://www.flickr.com/photos/dberrange= :| |: https://libvirt.org -o- https://fstop138.berrange.com= :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange= :|