From: Stefan Hajnoczi <stefanha@redhat.com>
To: Felipe Franciosi <felipe@nutanix.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Marc-Andre Lureau <marcandre.lureau@gmail.com>,
Philippe Mathieu-Daude <philmd@redhat.com>
Subject: Re: [PATCH v3 0/4] Improve default object property_add uint helpers
Date: Mon, 2 Dec 2019 15:00:01 +0000 [thread overview]
Message-ID: <20191202150001.GD131786@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191129174630.6922-1-felipe@nutanix.com>
[-- Attachment #1: Type: text/plain, Size: 2597 bytes --]
On Fri, Nov 29, 2019 at 05:46:47PM +0000, Felipe Franciosi wrote:
> This improves the family of object_property_add_uintXX_ptr helpers by enabling
> a default getter/setter only when desired. To prevent an API behavioural change
> (from clients that already used these helpers and did not want a setter), we
> add a OBJ_PROP_FLAG_READ flag that allow clients to only have a getter. Patch 1
> enhances the API and modify current users.
>
> While modifying the clients of the API, a couple of improvement opportunities
> were observed in ich9. These were added in separate patches (2 and 3).
>
> Patch 3 cleans up a lot of existing code by moving various objects to the
> enhanced API. Previously, those objects had their own getters/setters that only
> updated the values without further checks. Some of them actually lacked a check
> for setting overflows, which could have resulted in undesired values being set.
> The new default setters include a check for that, not updating the values in
> case of errors (and propagating them). If they did not provide an error
> pointer, then that behaviour was maintained.
>
>
> Felipe Franciosi (4):
> qom/object: enable setter for uint types
> ich9: fix getter type for sci_int property
> ich9: Simplify ich9_lpc_initfn
> qom/object: Use common get/set uint helpers
>
> hw/acpi/ich9.c | 99 ++------------------
> hw/acpi/pcihp.c | 7 +-
> hw/acpi/piix4.c | 12 +--
> hw/isa/lpc_ich9.c | 27 ++----
> hw/misc/edu.c | 13 +--
> hw/pci-host/q35.c | 14 +--
> hw/ppc/spapr.c | 18 +---
> hw/ppc/spapr_drc.c | 3 +-
> hw/vfio/pci-quirks.c | 20 ++--
> include/qom/object.h | 44 +++++++--
> memory.c | 15 +--
> qom/object.c | 216 ++++++++++++++++++++++++++++++++++++++-----
> target/arm/cpu.c | 22 +----
> target/i386/sev.c | 106 ++-------------------
> ui/console.c | 4 +-
> 15 files changed, 288 insertions(+), 332 deletions(-)
>
> --
> 2.20.1
>
> Changelog:
> v1->v2:
> - Update sci_int directly instead of using stack variable
> - Defining an enhanced ObjectPropertyFlags instead of just 'readonly'
> - Erroring out directly (instead of using gotos) on default setters
> - Retaining lack of errp passing when it wasn't there
> v2->v3:
> - Rename flags _RD to _READ and _WR to _WRITE
> - Add a convenience _READWRITE flag
> - Drop the usage of UL in the bit flag definitions
Modulo the review comments that have already been raised:
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-12-02 15:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 17:46 [PATCH v3 0/4] Improve default object property_add uint helpers Felipe Franciosi
2019-11-29 17:46 ` [PATCH v3 1/4] qom/object: enable setter for uint types Felipe Franciosi
2019-11-30 7:50 ` Marc-André Lureau
2019-12-02 15:06 ` Felipe Franciosi
2019-11-29 17:46 ` [PATCH v3 2/4] ich9: fix getter type for sci_int property Felipe Franciosi
2019-11-30 7:51 ` Marc-André Lureau
2019-11-29 17:46 ` [PATCH v3 3/4] ich9: Simplify ich9_lpc_initfn Felipe Franciosi
2019-11-30 7:52 ` Marc-André Lureau
2019-11-29 17:46 ` [PATCH v3 4/4] qom/object: Use common get/set uint helpers Felipe Franciosi
2019-11-30 7:55 ` Marc-André Lureau
2019-12-02 6:31 ` Alexey Kardashevskiy
2019-12-10 12:04 ` Felipe Franciosi
2019-12-12 1:05 ` Alexey Kardashevskiy
2019-12-17 22:19 ` Felipe Franciosi
2019-12-18 0:19 ` Alexey Kardashevskiy
2019-12-02 15:00 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202150001.GD131786@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=aik@ozlabs.ru \
--cc=armbru@redhat.com \
--cc=ehabkost@redhat.com \
--cc=felipe@nutanix.com \
--cc=marcandre.lureau@gmail.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).