From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: mszeredi@redhat.com, berrange@redhat.com, qemu-devel@nongnu.org,
stefanha@redhat.com, marcandre.lureau@redhat.com,
vgoyal@redhat.com
Subject: Re: virtiofsd: Where should it live?
Date: Mon, 2 Dec 2019 16:44:23 +0000 [thread overview]
Message-ID: <20191202164423.GE2904@work-vm> (raw)
In-Reply-To: <20191202043040-mutt-send-email-mst@kernel.org>
* Michael S. Tsirkin (mst@redhat.com) wrote:
> On Mon, Nov 25, 2019 at 06:50:21PM +0000, Dr. David Alan Gilbert wrote:
> > Hi,
> > There's been quite a bit of discussion about where virtiofsd, our
> > implemenation of a virtiofs daemon, should live. I'd like to get
> > this settled now, because I'd like to tidy it up for the next
> > qemu cycle.
> >
> > For reference it's based on qemu's livhost-user+chunks of libfuse.
> > It can't live in libfuse because we change enough of the library
> > to break their ABI.
>
> Generally there could be some ifdefs that allow one to
> build libfuse-host or whatever from the same source.
> I am guessing the big reason this doesn't fly is that
> libfuse is not actively developed anymore.
libfuse is certainly taking patches; so it's not dead.
However, the changes for the transport are quite invasive,
and it doesn't feel right to impose them on it.
We've pushed up small fixes/changes etc - but not things
that are big intrusive lumps for our use.
> Given that, the main remaining part is libvhost-user,
> and it's less work to use than to duplicate that.
> That kind of dictates being in qemu.
>
> > It's C, and we've got ~100 patches - which
> > we can split into about 3 chunks.
> >
> > Some suggestions so far:
> > a) In contrib
> > This is my current working assumption; the main objection is it's
> > a bit big and pulls in a chunk of libfuse.
> > b) In a submodule
> >
> > c) Just separate
> >
> > Your suggestions/ideas please. My preference is (a).
> >
> > Dave
>
>
> My preference is close to a, and maybe to avoid confusion we should have
> a new top-level directory for "separate daemons qemu invokes, and need
> to be built together with qemu". libvhost-user would have to move there,
> too. "modules"?
"modules" feels too close to "plugins" to my mind.
Dave
>
> >
> > --
> > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
> >
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-12-02 16:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-25 18:50 virtiofsd: Where should it live? Dr. David Alan Gilbert
2019-11-26 9:02 ` Marc-André Lureau
2019-11-26 11:42 ` Dr. David Alan Gilbert
2019-11-26 10:26 ` Daniel P. Berrangé
2019-11-26 12:14 ` Dr. David Alan Gilbert
2019-12-02 10:12 ` Peter Maydell
2019-12-02 12:56 ` Markus Armbruster
2019-12-02 13:32 ` Thomas Huth
2019-12-02 15:39 ` Markus Armbruster
2019-12-02 15:55 ` Dr. David Alan Gilbert
2019-12-03 10:53 ` Dr. David Alan Gilbert
2019-12-03 11:06 ` Peter Maydell
2019-12-03 11:17 ` Dr. David Alan Gilbert
2019-12-03 11:19 ` Daniel P. Berrangé
2019-12-03 13:06 ` Dr. David Alan Gilbert
2019-12-04 7:43 ` Markus Armbruster
2019-12-04 8:17 ` Gerd Hoffmann
2019-12-04 13:28 ` Kevin Wolf
2019-12-04 13:29 ` Thomas Huth
2019-12-04 14:36 ` Eric Blake
2019-12-04 16:33 ` Dr. David Alan Gilbert
2019-12-04 12:04 ` Dr. David Alan Gilbert
2019-12-04 13:10 ` Markus Armbruster
2019-12-04 14:34 ` Eric Blake
2019-12-03 12:59 ` Paolo Bonzini
2019-12-03 13:02 ` Dr. David Alan Gilbert
2019-12-03 13:07 ` Paolo Bonzini
2019-12-03 13:10 ` Dr. David Alan Gilbert
2019-12-03 16:08 ` Greg Kurz
2019-12-02 9:37 ` Michael S. Tsirkin
2019-12-02 16:44 ` Dr. David Alan Gilbert [this message]
2019-12-02 16:52 ` Michael S. Tsirkin
2019-12-02 17:01 ` Dr. David Alan Gilbert
2019-12-02 17:16 ` Christophe de Dinechin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191202164423.GE2904@work-vm \
--to=dgilbert@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=mszeredi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).