From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DB01C432C0 for ; Mon, 2 Dec 2019 21:19:45 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 207D520675 for ; Mon, 2 Dec 2019 21:19:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 207D520675 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=de.adit-jv.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:44678 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibt6e-0005xM-2D for qemu-devel@archiver.kernel.org; Mon, 02 Dec 2019 16:19:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47190) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibt4t-0004ya-JA for qemu-devel@nongnu.org; Mon, 02 Dec 2019 16:17:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibt4p-00075C-06 for qemu-devel@nongnu.org; Mon, 02 Dec 2019 16:17:54 -0500 Received: from smtp1.de.adit-jv.com ([93.241.18.167]:60596) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibt4o-00071F-Nr for qemu-devel@nongnu.org; Mon, 02 Dec 2019 16:17:50 -0500 Received: from localhost (smtp1.de.adit-jv.com [127.0.0.1]) by smtp1.de.adit-jv.com (Postfix) with ESMTP id EA9133C0579; Mon, 2 Dec 2019 22:17:46 +0100 (CET) Received: from smtp1.de.adit-jv.com ([127.0.0.1]) by localhost (smtp1.de.adit-jv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0ASiIrofYquI; Mon, 2 Dec 2019 22:17:40 +0100 (CET) Received: from HI2EXCH01.adit-jv.com (hi2exch01.adit-jv.com [10.72.92.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp1.de.adit-jv.com (Postfix) with ESMTPS id 540063C003B; Mon, 2 Dec 2019 22:17:40 +0100 (CET) Received: from vmlxhi-102.adit-jv.com (10.72.93.184) by HI2EXCH01.adit-jv.com (10.72.92.24) with Microsoft SMTP Server (TLS) id 14.3.468.0; Mon, 2 Dec 2019 22:17:39 +0100 Date: Mon, 2 Dec 2019 22:17:37 +0100 From: Eugeniu Rosca To: Geert Uytterhoeven Subject: Re: [PATCH v3 1/7] gpiolib: Add GPIOCHIP_NAME definition Message-ID: <20191202211737.GA27915@vmlxhi-102.adit-jv.com> References: <20191127084253.16356-1-geert+renesas@glider.be> <20191127084253.16356-2-geert+renesas@glider.be> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20191127084253.16356-2-geert+renesas@glider.be> User-Agent: Mutt/1.12.1+40 (7f8642d4ee82) (2019-06-28) X-Originating-IP: [10.72.93.184] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 93.241.18.167 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Peter Maydell , qemu-devel@nongnu.org, Phil Reid , Eugeniu Rosca , Jonathan Corbet , Marc Zyngier , Linus Walleij , linux-doc@vger.kernel.org, Magnus Damm , Christoffer Dall , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Bartosz Golaszewski , devicetree@vger.kernel.org, Rob Herring , Harish Jenny K N , linux-gpio@vger.kernel.org, Paolo Bonzini , Alexander Graf , Eugeniu Rosca Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi Geert, On Wed, Nov 27, 2019 at 09:42:47AM +0100, Geert Uytterhoeven wrote: > The string literal "gpiochip" is used in several places. > Add a definition for it, and use it everywhere, to make sure everything > stays in sync. > > Signed-off-by: Geert Uytterhoeven > --- > v3: > - New. > --- > drivers/gpio/gpiolib-sysfs.c | 7 +++---- > drivers/gpio/gpiolib.c | 4 ++-- > drivers/gpio/gpiolib.h | 2 ++ > 3 files changed, 7 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpio/gpiolib.h b/drivers/gpio/gpiolib.h > index ca9bc1e4803c2979..a4a759920faa48ab 100644 > --- a/drivers/gpio/gpiolib.h > +++ b/drivers/gpio/gpiolib.h > @@ -16,6 +16,8 @@ > #include > #include > > +#define GPIOCHIP_NAME "gpiochip" [.02$/nit] I wonder if GPIOCHIP_NAME is actually an essential part of kernel-user contract [1-2], in which case it could probably be moved to include/uapi/linux/gpio.h ? Regardless: Reviewed-by: Eugeniu Rosca [1] linux (v5.4) git grep '"gpiochip' -- tools/ tools/gpio/lsgpio.c: if (check_prefix(ent->d_name, "gpiochip")) { tools/testing/selftests/gpio/gpio-mockup-chardev.c: if (check_prefix(ent->d_name, "gpiochip")) { [2] libgpiod (v1.4-76-g00418dfdfc8b) git grep '"gpiochip' lib/iter.c: return !strncmp(dir->d_name, "gpiochip", 8); tests/mockup/gpio-mockup.c: rv = sscanf(sysname, "gpiochip%u", &chip->num); tools/gpioget.c: die("gpiochip must be specified"); tools/gpiomon.c: die("gpiochip must be specified"); tools/gpioset.c: die("gpiochip must be specified"); -- Best Regards, Eugeniu