From: Greg Kurz <groug@kaod.org>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>,
berrange@redhat.com, qemu-devel@nongnu.org, dgilbert@redhat.com
Subject: Re: [PATCH] virtfs-proxy-helper: switch from libcap to libcap-ng
Date: Tue, 3 Dec 2019 11:34:49 +0100 [thread overview]
Message-ID: <20191203113449.4b2e129e@bahia.w3ibm.bluemix.net> (raw)
In-Reply-To: <20191129135937.74a9b264@bahia.w3ibm.bluemix.net>
On Fri, 29 Nov 2019 13:59:37 +0100
Greg Kurz <groug@kaod.org> wrote:
> On Fri, 29 Nov 2019 13:49:20 +0100
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
> > On 29/11/19 13:32, Greg Kurz wrote:
> > > Nice. :)
> > >
> > > Reviewed-by: Greg Kurz <groug@kaod.org>
> > >
> > > Paolo,
> > >
> > > I can take this through my 9p tree if you want. Otherwise,
> > >
> > > Acked-by: Greg Kurz <groug@kaod.org>
> >
> > Yes, please do it since it's self-contained. You'd probably also test
> > it better than me. :)
> >
> > Paolo
> >
>
> Ok I'll just do that then.
>
And it happens to be missing an extra-change in Makefile :)
-fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap
+fsdev/virtfs-proxy-helper$(EXESUF): LIBS += -lcap-ng
I've fixed this up in my tree.
> Cheers,
>
> --
> Greg
next prev parent reply other threads:[~2019-12-03 10:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 11:16 [PATCH] virtfs-proxy-helper: switch from libcap to libcap-ng Paolo Bonzini
2019-11-29 12:09 ` Daniel P. Berrangé
2019-11-29 12:32 ` Greg Kurz
2019-11-29 12:49 ` Paolo Bonzini
2019-11-29 12:59 ` Greg Kurz
2019-12-03 10:34 ` Greg Kurz [this message]
2019-12-03 11:51 ` Paolo Bonzini
2019-11-29 14:55 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203113449.4b2e129e@bahia.w3ibm.bluemix.net \
--to=groug@kaod.org \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).