From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C433EC432C0 for ; Tue, 3 Dec 2019 21:22:31 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5045C207DD for ; Tue, 3 Dec 2019 21:22:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5045C207DD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58780 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icFcr-0003V3-5i for qemu-devel@archiver.kernel.org; Tue, 03 Dec 2019 16:22:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36057) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icEOk-0002rR-GZ for qemu-devel@nongnu.org; Tue, 03 Dec 2019 15:03:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icEOi-0000UG-BQ for qemu-devel@nongnu.org; Tue, 03 Dec 2019 15:03:49 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49210 helo=mx0a-001b2d01.pphosted.com) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icEOi-0000RV-4B for qemu-devel@nongnu.org; Tue, 03 Dec 2019 15:03:48 -0500 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB3JbGU9148747 for ; Tue, 3 Dec 2019 15:03:47 -0500 Received: from e06smtp03.uk.ibm.com (e06smtp03.uk.ibm.com [195.75.94.99]) by mx0b-001b2d01.pphosted.com with ESMTP id 2wnsd460mj-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Dec 2019 15:03:47 -0500 Received: from localhost by e06smtp03.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Dec 2019 20:03:45 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp03.uk.ibm.com (192.168.101.133) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Dec 2019 20:03:42 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xB3K3gQl45613102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Dec 2019 20:03:42 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F2383A4060; Tue, 3 Dec 2019 20:03:41 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BCD77A4054; Tue, 3 Dec 2019 20:03:41 +0000 (GMT) Received: from oc2783563651 (unknown [9.152.224.151]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTP; Tue, 3 Dec 2019 20:03:41 +0000 (GMT) Date: Tue, 3 Dec 2019 21:03:40 +0100 From: Halil Pasic To: Cornelia Huck Subject: Re: [PATCH 20/21] hw/intc/s390: Simplify error handling in kvm_s390_flic_realize() In-Reply-To: <20191202174007.0f7ad8bc.cohuck@redhat.com> References: <20191130194240.10517-1-armbru@redhat.com> <20191130194240.10517-21-armbru@redhat.com> <20191202174007.0f7ad8bc.cohuck@redhat.com> Organization: IBM X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 x-cbid: 19120320-0012-0000-0000-000003708DA0 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19120320-0013-0000-0000-000021AC4B95 Message-Id: <20191203210340.66cbb5ed.pasic@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-03_06:2019-12-02,2019-12-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 phishscore=0 spamscore=0 priorityscore=1501 mlxscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 impostorscore=0 suspectscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912030144 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 148.163.158.5 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Christian Borntraeger , vsementsov@virtuozzo.com, Markus Armbruster , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, 2 Dec 2019 17:40:07 +0100 Cornelia Huck wrote: > On Sat, 30 Nov 2019 20:42:39 +0100 > Markus Armbruster wrote: > > > Cc: Halil Pasic > > Cc: Cornelia Huck > > Cc: Christian Borntraeger > > Signed-off-by: Markus Armbruster > > --- > > hw/intc/s390_flic_kvm.c | 10 ++++------ > > 1 file changed, 4 insertions(+), 6 deletions(-) > > Reviewed-by: Cornelia Huck > > ...someone else wants to take a look before I queue this? > I guess it is a matter of taste. Acked-by: Halil Pasic The only difference I can see is if the **errp argument where to already contain an error (*errp). I guess the old code would just keep the first error, and discard the next one, while error_setv() does an assert(*errp == NULL). I assume calling with *errp != NULL is not a valid scenario. But then, I can't say I understand the use-case behind this discard the newer error behavior of error_propagate(). Regards, Halil