From: Cornelia Huck <cohuck@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: borntraeger@de.ibm.com, qemu-s390x@nongnu.org,
mihajlov@linux.ibm.com, Janosch Frank <frankja@linux.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v3 2/4] s390x: Add missing vcpu reset functions
Date: Wed, 4 Dec 2019 16:33:09 +0100 [thread overview]
Message-ID: <20191204163309.7af0582f.cohuck@redhat.com> (raw)
In-Reply-To: <026a1b83-6a1f-3e09-e516-13fe0f13dee0@redhat.com>
On Wed, 4 Dec 2019 16:08:48 +0100
David Hildenbrand <david@redhat.com> wrote:
> On 04.12.19 16:07, David Hildenbrand wrote:
> > On 04.12.19 15:59, Cornelia Huck wrote:
> >> On Tue, 3 Dec 2019 08:28:11 -0500
> >> Janosch Frank <frankja@linux.ibm.com> wrote:
> >>
> >>> Up to now we only had an ioctl to reset vcpu data QEMU couldn't reach
> >>> for the initial reset, and that was also called for the clear
> >>> reset. To be architecture compliant, we also need to clear local
> >>> interrupts on a normal reset.
> >>
> >> Do we also need to do something like that for tcg? David?
> >>
> >
> > So, we have
> >
> > /* Fields up to this point are not cleared by initial CPU reset */
> > struct {} start_initial_reset_fields;
> > [...]
> > int pending_int
> > uint16_t external_call_addr;
> > DECLARE_BITMAP(emergency_signals, S390_MAX_CPUS);
> > [...]
> > /* Fields up to this point are cleared by a CPU reset */
> > struct {} end_reset_fields;
> >
> > This means, local interrupts will be cleared by everything that zeroes
> > "start_initial_reset_fields->end_reset_fields"
> >
> > So, they will get cleared by S390_CPU_RESET_INITIAL only if I am not
> > wrong. In order to clear them on S390_CPU_RESET_NORMAL, we have to
> > manually set them to zero.
>
> Sorry, by S390_CPU_RESET_INITIAL and S390_CPU_RESET_CLEAR.
Ok. Will you cook up a patch, or should I do it?
>
> >
> > (we really should wrap TCG-only fields by ifdefs)
They probably do not get into the way, but making it obvious that they
a tcg-only is something we really should do.
> >
>
>
next prev parent reply other threads:[~2019-12-04 15:36 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 13:28 [PATCH v3 0/4] s390x: Increase architectural compliance Janosch Frank
2019-12-03 13:28 ` [PATCH v3 1/4] Header sync Janosch Frank
2019-12-03 13:28 ` [PATCH v3 2/4] s390x: Add missing vcpu reset functions Janosch Frank
2019-12-03 17:44 ` Cornelia Huck
2019-12-04 9:00 ` Janosch Frank
2019-12-04 9:15 ` Cornelia Huck
2019-12-04 14:59 ` Cornelia Huck
2019-12-04 15:07 ` David Hildenbrand
2019-12-04 15:08 ` David Hildenbrand
2019-12-04 15:33 ` Cornelia Huck [this message]
2019-12-04 15:35 ` David Hildenbrand
2019-12-03 13:28 ` [PATCH v3 3/4] s390x: Fix cpu normal reset ri clearing Janosch Frank
2019-12-05 13:32 ` Cornelia Huck
2019-12-03 13:28 ` [PATCH v3 4/4] pc-bios/s390x: Fix reset psw mask Janosch Frank
2019-12-03 13:33 ` Christian Borntraeger
2019-12-03 17:18 ` Cornelia Huck
2019-12-03 17:22 ` Cornelia Huck
2019-12-03 18:32 ` Christian Borntraeger
2019-12-05 10:12 ` Cornelia Huck
2019-12-13 12:06 ` Cornelia Huck
2019-12-13 12:37 ` Janosch Frank
2019-12-17 12:36 ` Thomas Huth
2019-12-17 15:09 ` Thomas Huth
2019-12-18 12:15 ` Janosch Frank
2019-12-18 12:28 ` Cornelia Huck
2019-12-18 16:54 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191204163309.7af0582f.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=mihajlov@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).