From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_SBL,URIBL_SBL_A,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70090C43603 for ; Thu, 5 Dec 2019 21:28:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3797224671 for ; Thu, 5 Dec 2019 21:28:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DqQIuhTW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3797224671 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:32820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icyg4-0004A1-BI for qemu-devel@archiver.kernel.org; Thu, 05 Dec 2019 16:28:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40043) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icyf0-0003fo-Cq for qemu-devel@nongnu.org; Thu, 05 Dec 2019 16:27:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icyex-0002wb-Cv for qemu-devel@nongnu.org; Thu, 05 Dec 2019 16:27:40 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:57294 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icyew-0002rn-UX for qemu-devel@nongnu.org; Thu, 05 Dec 2019 16:27:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575581258; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vdy+aaKHpOMhc0i3HwGp04b6CmS7M0gc+VaVx1Y9Jw4=; b=DqQIuhTWZ1uu3KHjgT+AhygKgPhS0F5jyTHVI/t+w8eTs3UogQ4Mh6h9pupwtJJDVzkTNT qWkqTRNjP92c6qSgF7jZ0oeC2JChLGeMNXhC+zx3Ao5ml6taPWB12H1IxQ51tghcmJV76g wPZX99Wg2bsCH0rqFawUsauMe7iD6O0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-HczGruJsMsOJs6jGGCCzPg-1; Thu, 05 Dec 2019 16:27:35 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6F8ED800D54; Thu, 5 Dec 2019 21:27:33 +0000 (UTC) Received: from localhost.localdomain (ovpn-125-37.rdu2.redhat.com [10.10.125.37]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C036F5DA60; Thu, 5 Dec 2019 21:27:31 +0000 (UTC) Date: Thu, 5 Dec 2019 16:27:29 -0500 From: Cleber Rosa To: Eduardo Habkost Subject: Re: [PATCH 2/5] mips: malta: Renovate coding style Message-ID: <20191205212729.GA1797@localhost.localdomain> References: <1574687098-26689-1-git-send-email-Filip.Bozuta@rt-rk.com> <1574687098-26689-3-git-send-email-Filip.Bozuta@rt-rk.com> <20191202204958.GP14595@habkost.net> MIME-Version: 1.0 In-Reply-To: <20191202204958.GP14595@habkost.net> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: HczGruJsMsOJs6jGGCCzPg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "pburton@wavecomp.com" , "qemu-devel@nongnu.org" , Filip Bozuta , "hpoussin@reactos.org" , "aurelien@aurel32.net" , "amarkovic@wavecomp.com" , "aleksandar.rikalo@rt-rk.com" , Aleksandar Markovic Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Dec 02, 2019 at 05:49:58PM -0300, Eduardo Habkost wrote: > On Sun, Dec 01, 2019 at 12:46:12AM +0100, Aleksandar Markovic wrote: > > On Monday, November 25, 2019, Filip Bozuta wro= te: > >=20 > > > The script checkpatch.pl located in scripts folder was > > > used to detect all errors and warrnings in files: > > > hw/mips/mips_malta.c > > > hw/mips/gt64xxx_pci.c > > > tests/acceptance/linux_ssh_mips_malta.py > > > > > > All these mips malta machine files were edited and > > > all the errors and warrings generated by the checkpatch.pl > > > script were corrected and then the script was > > > ran again to make sure there are no more errors and warnings. > > > > > > Signed-off-by: Filip Bozuta > > > --- > > > hw/mips/mips_malta.c | 139 > > > ++++++++++++++++--------------- > > > tests/acceptance/linux_ssh_mips_malta.py | 6 +- > > > 2 files changed, 75 insertions(+), 70 deletions(-) > > > > > > > > Very good cleanup! > >=20 > > Reviewed-by: Aleksandar Markovic > >=20 > > I think this snippet is good, but I am just in case cc-ing Cleber and > > Eduardo to check if it is in accordance with any applicable guidelines = of > > our test framework: >=20 > Thanks for CCing us. >=20 > >=20 > >=20 > > > diff --git a/tests/acceptance/linux_ssh_mips_malta.py > > > b/tests/acceptance/linux_ssh_mips_malta.py > > > index fc13f9e..44e1118 100644 > > > --- a/tests/acceptance/linux_ssh_mips_malta.py > > > +++ b/tests/acceptance/linux_ssh_mips_malta.py > > > @@ -99,10 +99,12 @@ class LinuxSSH(Test): > > > def ssh_command(self, command, is_root=3DTrue): > > > self.ssh_logger.info(command) > > > result =3D self.ssh_session.cmd(command) > > > - stdout_lines =3D [line.rstrip() for line in > > > result.stdout_text.splitlines()] > > > + stdout_lines =3D [line.rstrip() for line > > > + in result.stdout_text.splitlines()] > > > for line in stdout_lines: > > > self.ssh_logger.info(line) > > > - stderr_lines =3D [line.rstrip() for line in > > > result.stderr_text.splitlines()] > > > + stderr_lines =3D [line.rstrip() for line > > > + in result.stderr_text.splitlines()] >=20 > If you really want to split those lines, please indent them > properly. e.g.: >=20 > stdout_lines =3D [line.rstrip() for line > in result.stdout_text.splitlines()] >=20 > See PEP 8 [1] for additional examples. >=20 > Personally, I would just keep the existing > linux_ssh_mips_malta.py code as is. I don't think splitting > those lines improves readability. > > [1] https://www.python.org/dev/peps/pep-0008/#indentation >=20 > --=20 > Eduardo Right. It only helps when running terminal or editor settings are limited to ~80 cols. And even in those cases, sometimes such code split across lines needs a lot of gymnastics to not degrade in readability when compared to a longer line. We're not (yet?) enforcing PEP 8, so either as Eduardo suggested, or with no changes LGTM. Cheers, - Cleber.