From: Cornelia Huck <cohuck@redhat.com>
To: Richard Henderson <rth@twiddle.net>,
David Hildenbrand <david@redhat.com>
Cc: qemu-s390x@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org
Subject: [PATCH v2] s390x/tcg: clear local interrupts on reset normal
Date: Fri, 6 Dec 2019 14:54:04 +0100 [thread overview]
Message-ID: <20191206135404.16051-1-cohuck@redhat.com> (raw)
We neglected to clean up pending interrupts and emergency signals;
fix that.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
v1->v2:
- rebased on top of my s390-next branch; we can now move the fields
to be reset instead of clearing them manually
Further cleanup possible in a follow-up patch.
---
target/s390x/cpu.h | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 7f5fa1d35b73..e195e5c7c8bb 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -98,10 +98,6 @@ struct CPUS390XState {
uint64_t cregs[16]; /* control registers */
- int pending_int;
- uint16_t external_call_addr;
- DECLARE_BITMAP(emergency_signals, S390_MAX_CPUS);
-
uint64_t ckc;
uint64_t cputm;
uint32_t todpr;
@@ -117,6 +113,10 @@ struct CPUS390XState {
struct {} start_normal_reset_fields;
uint8_t riccb[64]; /* runtime instrumentation control */
+ int pending_int;
+ uint16_t external_call_addr;
+ DECLARE_BITMAP(emergency_signals, S390_MAX_CPUS);
+
/* Fields up to this point are cleared by a CPU reset */
struct {} end_reset_fields;
--
2.21.0
next reply other threads:[~2019-12-06 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 13:54 Cornelia Huck [this message]
2019-12-06 14:26 ` [PATCH v2] s390x/tcg: clear local interrupts on reset normal Philippe Mathieu-Daudé
2019-12-06 14:27 ` David Hildenbrand
2019-12-10 10:11 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206135404.16051-1-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).