From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBBA3C43603 for ; Mon, 9 Dec 2019 20:59:37 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83218205C9 for ; Mon, 9 Dec 2019 20:59:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GqPmpYA3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83218205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47244 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieQ80-0004QE-M4 for qemu-devel@archiver.kernel.org; Mon, 09 Dec 2019 15:59:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40836) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieQ7M-0003yN-LR for qemu-devel@nongnu.org; Mon, 09 Dec 2019 15:58:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieQ7K-0007m6-Dt for qemu-devel@nongnu.org; Mon, 09 Dec 2019 15:58:56 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:24556 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ieQ7J-0007iZ-05 for qemu-devel@nongnu.org; Mon, 09 Dec 2019 15:58:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575925130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XPprieyWJlgl2zqonvfpvmj/ea8LaCsECl8Y76piJaI=; b=GqPmpYA3moc7bBuWYmVT0NdQ6Tj/c3RcFU8MWGrR99YNfzt/D1S3HVOwIYANbGB/1xAPTO HovIRkwQQMWppAC5Nh1xuizsdhTRXMOfvZkNX/tuJougF+iSMJ5YPEcvPi/ASMnCzddXwK iSWdywChk0mvpJPPZtXgj24cJo8OanU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-413-5f_RQHNAO8-vFcVC2JRyqg-1; Mon, 09 Dec 2019 15:58:48 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8FA22593A3; Mon, 9 Dec 2019 20:58:47 +0000 (UTC) Received: from localhost (ovpn-116-90.gru2.redhat.com [10.97.116.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E8AF5D9D6; Mon, 9 Dec 2019 20:58:42 +0000 (UTC) Date: Mon, 9 Dec 2019 17:58:40 -0300 From: Eduardo Habkost To: Igor Mammedov Subject: Re: [PATCH 2/2] Add -mem-shared option Message-ID: <20191209205840.GJ498046@habkost.net> References: <20191128172807.788e6aeb@redhat.com> <20191129110703.2b15c541@redhat.com> <04dadf85-cd35-fd37-9642-8087cba625bd@redhat.com> <20191129131652.6683b769@redhat.com> <528bb183-3d44-e541-8765-9c0e01f23157@redhat.com> <20191202083948.3e8bb134@redhat.com> <20191202210057.GQ14595@habkost.net> <1ff4cc6a-0ec8-96ff-1e39-e682429852e4@redhat.com> <20191203154303.035c33b3@redhat.com> MIME-Version: 1.0 In-Reply-To: <20191203154303.035c33b3@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 5f_RQHNAO8-vFcVC2JRyqg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-Disposition: inline X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Huth , libvir-list@redhat.com, QEMU , Markus Armbruster , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Stefan Hajnoczi , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" +Markus On Tue, Dec 03, 2019 at 03:43:03PM +0100, Igor Mammedov wrote: > On Tue, 3 Dec 2019 09:56:15 +0100 > Thomas Huth wrote: >=20 > > On 02/12/2019 22.00, Eduardo Habkost wrote: > > > On Mon, Dec 02, 2019 at 08:39:48AM +0100, Igor Mammedov wrote: =20 > > >> On Fri, 29 Nov 2019 18:46:12 +0100 > > >> Paolo Bonzini wrote: > > >> =20 > > >>> On 29/11/19 13:16, Igor Mammedov wrote: =20 > > >>>> As for "-m", I'd make it just an alias that translates > > >>>> -m/mem-path/mem-prealloc =20 > > >>> > > >>> I think we should just deprecate -mem-path/-mem-prealloc in 5.0. C= Cing > > >>> Thomas as mister deprecation. :) =20 > > >> > > >> I'll add that to my series =20 > > >=20 > > > Considering that the plan is to eventually reimplement those > > > options as syntactic sugar for memory backend options (hopefully > > > in less than 2 QEMU releases), what's the point of deprecating > > > them? =20 > >=20 > > Well, it depends on the "classification" [1] of the parameter... > >=20 > > Let's ask: What's the main purpose of the option? > >=20 > > Is it easier to use than the "full" option, and thus likely to be used > > by a lot of people who run QEMU directly from the CLI? In that case it > > should stay as "convenience option" and not be deprecated. > >=20 > > Or is the option merely there to give the upper layers like libvirt or > > some few users and their scripts some more grace period to adapt their > > code, but we all agree that the options are rather ugly and should > > finally go away? Then it's rather a "legacy option" and the deprecation > > process is the right way to go. Our QEMU interface is still way=20 > > overcrowded, we should try to keep it as clean as possible. >=20 > After switching to memdev for main RAM, users could use relatively > short global options > -global memory-backend.prealloc|share=3Don > and > -global memory-backend-file.mem-path=3DX|prealloc|share=3Don >=20 > instead of us adding and maintaining slightly shorter > -mem-shared/-mem-path/-mem-prealloc Global properties are a convenient way to expose knobs through the command line with little effort, but we have no documentation on which QOM properties are really supposed to be touched by users using -global. Unless we fix the lack of documentation, I'd prefer to have syntactic sugar translated to -global instead of recommending direct usage of -global. --=20 Eduardo