* [PULL 0/2] Block patches
@ 2019-12-13 14:33 Stefan Hajnoczi
2019-12-13 14:33 ` [PULL 1/2] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 31+ messages in thread
From: Stefan Hajnoczi @ 2019-12-13 14:33 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Stefan Hajnoczi, Eduardo Habkost, qemu-block
The following changes since commit b0ca999a43a22b38158a222233d3f5881648bb4f:
Update version for v4.2.0 release (2019-12-12 16:45:57 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 86d2a49b41832355ab50cf60cec0cd50680fc0e5:
iothread: document -object iothread on man page (2019-12-13 11:24:07 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Evgeny Yakovlev (1):
virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised
Stefan Hajnoczi (1):
iothread: document -object iothread on man page
hw/arm/virt.c | 1 +
hw/block/virtio-blk.c | 6 +++++-
hw/core/machine.c | 5 +++++
hw/i386/pc_piix.c | 1 +
hw/i386/pc_q35.c | 1 +
hw/ppc/spapr.c | 2 +-
hw/s390x/s390-virtio-ccw.c | 1 +
include/hw/boards.h | 3 +++
include/hw/virtio/virtio-blk.h | 1 +
qemu-options.hx | 38 ++++++++++++++++++++++++++++++++++
10 files changed, 57 insertions(+), 2 deletions(-)
--
2.23.0
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 1/2] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised
2019-12-13 14:33 [PULL 0/2] Block patches Stefan Hajnoczi
@ 2019-12-13 14:33 ` Stefan Hajnoczi
2019-12-13 14:33 ` [PULL 2/2] iothread: document -object iothread on man page Stefan Hajnoczi
2019-12-13 21:10 ` [PULL 0/2] Block patches Peter Maydell
2 siblings, 0 replies; 31+ messages in thread
From: Stefan Hajnoczi @ 2019-12-13 14:33 UTC (permalink / raw)
To: qemu-devel
Cc: Evgeny Yakovlev, Peter Maydell, Stefan Hajnoczi, Eduardo Habkost,
qemu-block
From: Evgeny Yakovlev <wrfsh@yandex-team.ru>
Virtio spec 1.1 (and earlier), 5.2.5.2 Driver Requirements: Device
Initialization:
"Devices SHOULD always offer VIRTIO_BLK_F_FLUSH, and MUST offer it if
they offer VIRTIO_BLK_F_CONFIG_WCE"
Currently F_CONFIG_WCE and F_WCE are not connected to each other.
Qemu will advertise F_CONFIG_WCE if config-wce argument is
set for virtio-blk device. And F_WCE is advertised only if
underlying block backend actually has it's caching enabled.
Fix this by advertising F_WCE if F_CONFIG_WCE is also advertised.
To preserve backwards compatibility with newer machine types make this
behaviour governed by "x-enable-wce-if-config-wce" virtio-blk-device
property and introduce hw_compat_4_2 with new property being off by
default for all machine types <= 4.2 (but don't introduce 4.3
machine type itself yet).
Signed-off-by: Evgeny Yakovlev <wrfsh@yandex-team.ru>
Message-Id: <1572978137-189218-1-git-send-email-wrfsh@yandex-team.ru>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/arm/virt.c | 1 +
hw/block/virtio-blk.c | 6 +++++-
hw/core/machine.c | 5 +++++
hw/i386/pc_piix.c | 1 +
hw/i386/pc_q35.c | 1 +
hw/ppc/spapr.c | 2 +-
hw/s390x/s390-virtio-ccw.c | 1 +
include/hw/boards.h | 3 +++
include/hw/virtio/virtio-blk.h | 1 +
9 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index d4bedc2607..bf4b1cbfb8 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -2149,6 +2149,7 @@ type_init(machvirt_machine_init);
static void virt_machine_4_2_options(MachineClass *mc)
{
+ compat_props_add(mc->compat_props, hw_compat_4_2, hw_compat_4_2_len);
}
DEFINE_VIRT_MACHINE_AS_LATEST(4, 2)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index 4c357d2928..d62e6377c2 100644
--- a/hw/block/virtio-blk.c
+++ b/hw/block/virtio-blk.c
@@ -991,7 +991,9 @@ static uint64_t virtio_blk_get_features(VirtIODevice *vdev, uint64_t features,
virtio_add_feature(&features, VIRTIO_BLK_F_SCSI);
}
- if (blk_enable_write_cache(s->blk)) {
+ if (blk_enable_write_cache(s->blk) ||
+ (s->conf.x_enable_wce_if_config_wce &&
+ virtio_has_feature(features, VIRTIO_BLK_F_CONFIG_WCE))) {
virtio_add_feature(&features, VIRTIO_BLK_F_WCE);
}
if (blk_is_read_only(s->blk)) {
@@ -1270,6 +1272,8 @@ static Property virtio_blk_properties[] = {
conf.max_discard_sectors, BDRV_REQUEST_MAX_SECTORS),
DEFINE_PROP_UINT32("max-write-zeroes-sectors", VirtIOBlock,
conf.max_write_zeroes_sectors, BDRV_REQUEST_MAX_SECTORS),
+ DEFINE_PROP_BOOL("x-enable-wce-if-config-wce", VirtIOBlock,
+ conf.x_enable_wce_if_config_wce, true),
DEFINE_PROP_END_OF_LIST(),
};
diff --git a/hw/core/machine.c b/hw/core/machine.c
index 1689ad3bf8..023548b4f3 100644
--- a/hw/core/machine.c
+++ b/hw/core/machine.c
@@ -27,6 +27,11 @@
#include "hw/pci/pci.h"
#include "hw/mem/nvdimm.h"
+GlobalProperty hw_compat_4_2[] = {
+ { "virtio-blk-device", "x-enable-wce-if-config-wce", "off" },
+};
+const size_t hw_compat_4_2_len = G_N_ELEMENTS(hw_compat_4_2);
+
GlobalProperty hw_compat_4_1[] = {
{ "virtio-pci", "x-pcie-flr-init", "off" },
};
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index 1bd70d1abb..87aced0742 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -431,6 +431,7 @@ static void pc_i440fx_4_2_machine_options(MachineClass *m)
m->alias = "pc";
m->is_default = 1;
pcmc->default_cpu_version = 1;
+ compat_props_add(m->compat_props, hw_compat_4_2, hw_compat_4_2_len);
}
DEFINE_I440FX_MACHINE(v4_2, "pc-i440fx-4.2", NULL,
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 385e5cffb1..2608cd0062 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -354,6 +354,7 @@ static void pc_q35_4_2_machine_options(MachineClass *m)
pc_q35_machine_options(m);
m->alias = "q35";
pcmc->default_cpu_version = 1;
+ compat_props_add(m->compat_props, hw_compat_4_2, hw_compat_4_2_len);
}
DEFINE_Q35_MACHINE(v4_2, "pc-q35-4.2", NULL,
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index e076f6023c..2ca92f2148 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -4496,7 +4496,7 @@ static const TypeInfo spapr_machine_info = {
*/
static void spapr_machine_4_2_class_options(MachineClass *mc)
{
- /* Defaults for the latest behaviour inherited from the base class */
+ compat_props_add(mc->compat_props, hw_compat_4_2, hw_compat_4_2_len);
}
DEFINE_SPAPR_MACHINE(4_2, "4.2", true);
diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
index d3edeef0ad..cb5fe4c84d 100644
--- a/hw/s390x/s390-virtio-ccw.c
+++ b/hw/s390x/s390-virtio-ccw.c
@@ -645,6 +645,7 @@ static void ccw_machine_4_2_instance_options(MachineState *machine)
static void ccw_machine_4_2_class_options(MachineClass *mc)
{
+ compat_props_add(mc->compat_props, hw_compat_4_2, hw_compat_4_2_len);
}
DEFINE_CCW_MACHINE(4_2, "4.2", true);
diff --git a/include/hw/boards.h b/include/hw/boards.h
index de45087f34..24cbeecbae 100644
--- a/include/hw/boards.h
+++ b/include/hw/boards.h
@@ -329,6 +329,9 @@ struct MachineState {
} \
type_init(machine_initfn##_register_types)
+extern GlobalProperty hw_compat_4_2[];
+extern const size_t hw_compat_4_2_len;
+
extern GlobalProperty hw_compat_4_1[];
extern const size_t hw_compat_4_1_len;
diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h
index cddcfbebe9..9c19f5b634 100644
--- a/include/hw/virtio/virtio-blk.h
+++ b/include/hw/virtio/virtio-blk.h
@@ -40,6 +40,7 @@ struct VirtIOBlkConf
uint16_t queue_size;
uint32_t max_discard_sectors;
uint32_t max_write_zeroes_sectors;
+ bool x_enable_wce_if_config_wce;
};
struct VirtIOBlockDataPlane;
--
2.23.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* [PULL 2/2] iothread: document -object iothread on man page
2019-12-13 14:33 [PULL 0/2] Block patches Stefan Hajnoczi
2019-12-13 14:33 ` [PULL 1/2] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised Stefan Hajnoczi
@ 2019-12-13 14:33 ` Stefan Hajnoczi
2019-12-13 21:10 ` [PULL 0/2] Block patches Peter Maydell
2 siblings, 0 replies; 31+ messages in thread
From: Stefan Hajnoczi @ 2019-12-13 14:33 UTC (permalink / raw)
To: qemu-devel
Cc: Peter Maydell, Stefan Hajnoczi, Eduardo Habkost, qemu-block, Zhenyu Ye
Add -object iothread documentation to the man page, including references
to the query-iothread QMP command and qom-set syntax for adjusting
adaptive polling parameters at run-time.
Reported-by: Zhenyu Ye <yezhenyu2@huawei.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20191025122236.29815-1-stefanha@redhat.com
Message-Id: <20191025122236.29815-1-stefanha@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
qemu-options.hx | 38 ++++++++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)
diff --git a/qemu-options.hx b/qemu-options.hx
index 65c9473b73..68d1592ccc 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -4926,6 +4926,44 @@ access
CN=laptop.example.com,O=Example Home,L=London,ST=London,C=GB
@end example
+@item -object iothread,id=@var{id},poll-max-ns=@var{poll-max-ns},poll-grow=@var{poll-grow},poll-shrink=@var{poll-shrink}
+
+Creates a dedicated event loop thread that devices can be assigned to. This is
+known as an IOThread. By default device emulation happens in vCPU threads or
+the main event loop thread. This can become a scalability bottleneck.
+IOThreads allow device emulation and I/O to run on other host CPUs.
+
+The @option{id} parameter is a unique ID that will be used to reference this
+IOThread from @option{-device ...,iothread=@var{id}}. Multiple devices can be
+assigned to an IOThread. Note that not all devices support an
+@option{iothread} parameter.
+
+The @code{query-iothreads} QMP command lists IOThreads and reports their thread
+IDs so that the user can configure host CPU pinning/affinity.
+
+IOThreads use an adaptive polling algorithm to reduce event loop latency.
+Instead of entering a blocking system call to monitor file descriptors and then
+pay the cost of being woken up when an event occurs, the polling algorithm
+spins waiting for events for a short time. The algorithm's default parameters
+are suitable for many cases but can be adjusted based on knowledge of the
+workload and/or host device latency.
+
+The @option{poll-max-ns} parameter is the maximum number of nanoseconds to busy
+wait for events. Polling can be disabled by setting this value to 0.
+
+The @option{poll-grow} parameter is the multiplier used to increase the polling
+time when the algorithm detects it is missing events due to not polling long
+enough.
+
+The @option{poll-shrink} parameter is the divisor used to decrease the polling
+time when the algorithm detects it is spending too long polling without
+encountering events.
+
+The polling parameters can be modified at run-time using the @code{qom-set} command (where @code{iothread1} is the IOThread's @code{id}):
+
+@example
+(qemu) qom-set /objects/iothread1 poll-max-ns 100000
+@end example
@end table
--
2.23.0
^ permalink raw reply related [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2019-12-13 14:33 [PULL 0/2] Block patches Stefan Hajnoczi
2019-12-13 14:33 ` [PULL 1/2] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised Stefan Hajnoczi
2019-12-13 14:33 ` [PULL 2/2] iothread: document -object iothread on man page Stefan Hajnoczi
@ 2019-12-13 21:10 ` Peter Maydell
2 siblings, 0 replies; 31+ messages in thread
From: Peter Maydell @ 2019-12-13 21:10 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: QEMU Developers, Qemu-block, Eduardo Habkost
On Fri, 13 Dec 2019 at 14:33, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit b0ca999a43a22b38158a222233d3f5881648bb4f:
>
> Update version for v4.2.0 release (2019-12-12 16:45:57 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 86d2a49b41832355ab50cf60cec0cd50680fc0e5:
>
> iothread: document -object iothread on man page (2019-12-13 11:24:07 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2024-01-22 16:01 Stefan Hajnoczi
2024-01-25 15:11 ` Peter Maydell
2024-01-25 15:47 ` Michael Tokarev
0 siblings, 2 replies; 31+ messages in thread
From: Stefan Hajnoczi @ 2024-01-22 16:01 UTC (permalink / raw)
To: qemu-devel
Cc: Hanna Reitz, Stefan Hajnoczi, Peter Maydell, qemu-block,
Fam Zheng, Kevin Wolf
The following changes since commit 09be34717190c1620f0c6e5c8765b8da354aeb4b:
Merge tag 'pull-request-2024-01-19' of https://gitlab.com/thuth/qemu into staging (2024-01-20 17:22:16 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 8a9be7992426c8920d4178e7dca59306a18c7a3a:
block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status (2024-01-22 11:00:12 -0500)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Akihiko Odaki (1):
coroutine-ucontext: Save fake stack for pooled coroutine
Fiona Ebner (1):
block/io: clear BDRV_BLOCK_RECURSE flag after recursing in
bdrv_co_block_status
block/io.c | 10 ++++++++++
util/coroutine-ucontext.c | 35 ++++++++++++++++++++++++++---------
2 files changed, 36 insertions(+), 9 deletions(-)
--
2.43.0
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2024-01-22 16:01 Stefan Hajnoczi
@ 2024-01-25 15:11 ` Peter Maydell
2024-01-25 15:47 ` Michael Tokarev
1 sibling, 0 replies; 31+ messages in thread
From: Peter Maydell @ 2024-01-25 15:11 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: qemu-devel, Hanna Reitz, qemu-block, Fam Zheng, Kevin Wolf
On Mon, 22 Jan 2024 at 16:01, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 09be34717190c1620f0c6e5c8765b8da354aeb4b:
>
> Merge tag 'pull-request-2024-01-19' of https://gitlab.com/thuth/qemu into staging (2024-01-20 17:22:16 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 8a9be7992426c8920d4178e7dca59306a18c7a3a:
>
> block/io: clear BDRV_BLOCK_RECURSE flag after recursing in bdrv_co_block_status (2024-01-22 11:00:12 -0500)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/9.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2024-01-22 16:01 Stefan Hajnoczi
2024-01-25 15:11 ` Peter Maydell
@ 2024-01-25 15:47 ` Michael Tokarev
1 sibling, 0 replies; 31+ messages in thread
From: Michael Tokarev @ 2024-01-25 15:47 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Hanna Reitz, Peter Maydell, qemu-block, Fam Zheng, Kevin Wolf,
Akihiko Odaki
22.01.2024 19:01, Stefan Hajnoczi :
> Akihiko Odaki (1):
> coroutine-ucontext: Save fake stack for pooled coroutine
>
> Fiona Ebner (1):
> block/io: clear BDRV_BLOCK_RECURSE flag after recursing in
> bdrv_co_block_status
These too also look like -stable matherial, both of the changes.
Please let me know if it's not.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2023-04-24 17:55 Stefan Hajnoczi
2023-04-25 11:15 ` Richard Henderson
0 siblings, 1 reply; 31+ messages in thread
From: Stefan Hajnoczi @ 2023-04-24 17:55 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, qemu-block, Hanna Reitz, Stefan Hajnoczi, Richard Henderson
The following changes since commit ac5f7bf8e208cd7893dbb1a9520559e569a4677c:
Merge tag 'migration-20230424-pull-request' of https://gitlab.com/juan.quintela/qemu into staging (2023-04-24 15:00:39 +0100)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 9d672e290475001fcecdcc9dc79ad088ff89d17f:
tracetool: use relative paths for '#line' preprocessor directives (2023-04-24 13:53:44 -0400)
----------------------------------------------------------------
Pull request (v2)
I dropped the zoned storage patches that had CI failures. This pull request
only contains fixes now.
----------------------------------------------------------------
Philippe Mathieu-Daudé (1):
block/dmg: Declare a type definition for DMG uncompress function
Thomas De Schampheleire (1):
tracetool: use relative paths for '#line' preprocessor directives
block/dmg.h | 8 ++++----
block/dmg.c | 7 ++-----
scripts/tracetool/backend/ftrace.py | 4 +++-
scripts/tracetool/backend/log.py | 4 +++-
scripts/tracetool/backend/syslog.py | 4 +++-
5 files changed, 15 insertions(+), 12 deletions(-)
--
2.39.2
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2023-04-24 17:55 Stefan Hajnoczi
@ 2023-04-25 11:15 ` Richard Henderson
0 siblings, 0 replies; 31+ messages in thread
From: Richard Henderson @ 2023-04-25 11:15 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Kevin Wolf, qemu-block, Hanna Reitz, Richard Henderson
On 4/24/23 18:55, Stefan Hajnoczi wrote:
> The following changes since commit ac5f7bf8e208cd7893dbb1a9520559e569a4677c:
>
> Merge tag 'migration-20230424-pull-request' ofhttps://gitlab.com/juan.quintela/qemu into staging (2023-04-24 15:00:39 +0100)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 9d672e290475001fcecdcc9dc79ad088ff89d17f:
>
> tracetool: use relative paths for '#line' preprocessor directives (2023-04-24 13:53:44 -0400)
>
> ----------------------------------------------------------------
> Pull request (v2)
>
> I dropped the zoned storage patches that had CI failures. This pull request
> only contains fixes now.
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/8.1 as appropriate.
r~
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2022-07-07 8:12 Stefan Hajnoczi
2022-07-07 10:51 ` Richard Henderson
0 siblings, 1 reply; 31+ messages in thread
From: Stefan Hajnoczi @ 2022-07-07 8:12 UTC (permalink / raw)
To: qemu-devel
Cc: Julia Suvorova, qemu-block, Stefano Garzarella, Hanna Reitz,
Kevin Wolf, Aarushi Mehta, Stefan Hajnoczi, Richard Henderson
The following changes since commit 8e9398e3b1a860b8c29c670c1b6c36afe8d87849:
Merge tag 'pull-ppc-20220706' of https://gitlab.com/danielhb/qemu into staging (2022-07-07 06:21:05 +0530)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to be6a166fde652589761cf70471bcde623e9bd72a:
block/io_uring: clarify that short reads can happen (2022-07-07 09:04:15 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Dominique Martinet (1):
io_uring: fix short read slow path
Stefan Hajnoczi (1):
block/io_uring: clarify that short reads can happen
block/io_uring.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
--
2.36.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2022-07-07 8:12 Stefan Hajnoczi
@ 2022-07-07 10:51 ` Richard Henderson
0 siblings, 0 replies; 31+ messages in thread
From: Richard Henderson @ 2022-07-07 10:51 UTC (permalink / raw)
To: Stefan Hajnoczi, qemu-devel
Cc: Julia Suvorova, qemu-block, Stefano Garzarella, Hanna Reitz,
Kevin Wolf, Aarushi Mehta
On 7/7/22 13:42, Stefan Hajnoczi wrote:
> The following changes since commit 8e9398e3b1a860b8c29c670c1b6c36afe8d87849:
>
> Merge tag 'pull-ppc-20220706' of https://gitlab.com/danielhb/qemu into staging (2022-07-07 06:21:05 +0530)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to be6a166fde652589761cf70471bcde623e9bd72a:
>
> block/io_uring: clarify that short reads can happen (2022-07-07 09:04:15 +0100)
>
> ----------------------------------------------------------------
> Pull request
Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate.
r~
>
> ----------------------------------------------------------------
>
> Dominique Martinet (1):
> io_uring: fix short read slow path
>
> Stefan Hajnoczi (1):
> block/io_uring: clarify that short reads can happen
>
> block/io_uring.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2021-10-11 12:40 Stefan Hajnoczi
2021-10-11 18:23 ` Richard Henderson
0 siblings, 1 reply; 31+ messages in thread
From: Stefan Hajnoczi @ 2021-10-11 12:40 UTC (permalink / raw)
To: Peter Maydell, qemu-devel; +Cc: qemu-block, Stefan Hajnoczi
The following changes since commit ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def:
Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20211006' into staging (2021-10-06 12:11:14 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 1cc7eada97914f090125e588497986f6f7900514:
iothread: use IOThreadParamInfo in iothread_[set|get]_param() (2021-10-07 15:29:50 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Stefano Garzarella (2):
iothread: rename PollParamInfo to IOThreadParamInfo
iothread: use IOThreadParamInfo in iothread_[set|get]_param()
iothread.c | 28 +++++++++++++++-------------
1 file changed, 15 insertions(+), 13 deletions(-)
--
2.31.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-10-11 12:40 Stefan Hajnoczi
@ 2021-10-11 18:23 ` Richard Henderson
0 siblings, 0 replies; 31+ messages in thread
From: Richard Henderson @ 2021-10-11 18:23 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell, qemu-devel; +Cc: qemu-block
On 10/11/21 5:40 AM, Stefan Hajnoczi wrote:
> The following changes since commit ca61fa4b803e5d0abaf6f1ceb690f23bb78a4def:
>
> Merge remote-tracking branch 'remotes/quic/tags/pull-hex-20211006' into staging (2021-10-06 12:11:14 -0700)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 1cc7eada97914f090125e588497986f6f7900514:
>
> iothread: use IOThreadParamInfo in iothread_[set|get]_param() (2021-10-07 15:29:50 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Stefano Garzarella (2):
> iothread: rename PollParamInfo to IOThreadParamInfo
> iothread: use IOThreadParamInfo in iothread_[set|get]_param()
>
> iothread.c | 28 +++++++++++++++-------------
> 1 file changed, 15 insertions(+), 13 deletions(-)
Applied, thanks.
r~
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2021-03-24 14:52 Stefan Hajnoczi
2021-03-24 18:05 ` Peter Maydell
2021-03-26 10:22 ` Peter Maydell
0 siblings, 2 replies; 31+ messages in thread
From: Stefan Hajnoczi @ 2021-03-24 14:52 UTC (permalink / raw)
To: Peter Maydell, qemu-devel
Cc: Fam Zheng, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
Eduardo Habkost, qemu-block, Juan Quintela, John Snow,
Michael S. Tsirkin, Dr. David Alan Gilbert, Stefan Hajnoczi,
Max Reitz
The following changes since commit 67c1115edd98f388ca89dd38322ea3fadf034523:
Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210323-pull-request' into staging (2021-03-23 23:47:30 +0000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 3460fd7f3959d1fa7bcc255796844aa261c805a4:
migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps (2021-03-24 13:41:19 +0000)
----------------------------------------------------------------
Pull request
This dirty bitmap fix solves a crash that can be triggered in the destination
QEMU process during live migration.
----------------------------------------------------------------
Vladimir Sementsov-Ogievskiy (2):
migration/block-dirty-bitmap: make incoming disabled bitmaps busy
migrate-bitmaps-postcopy-test: check that we can't remove in-flight
bitmaps
migration/block-dirty-bitmap.c | 6 ++++++
tests/qemu-iotests/tests/migrate-bitmaps-postcopy-test | 10 ++++++++++
2 files changed, 16 insertions(+)
--
2.30.2
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-24 14:52 Stefan Hajnoczi
@ 2021-03-24 18:05 ` Peter Maydell
2021-03-24 20:18 ` Vladimir Sementsov-Ogievskiy
2021-03-26 10:22 ` Peter Maydell
1 sibling, 1 reply; 31+ messages in thread
From: Peter Maydell @ 2021-03-24 18:05 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
Eduardo Habkost, Qemu-block, Juan Quintela, John Snow,
Michael S. Tsirkin, QEMU Developers, Dr. David Alan Gilbert,
Max Reitz
On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 67c1115edd98f388ca89dd38322ea3fadf034523:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210323-pull-request' into staging (2021-03-23 23:47:30 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 3460fd7f3959d1fa7bcc255796844aa261c805a4:
>
> migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps (2021-03-24 13:41:19 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> This dirty bitmap fix solves a crash that can be triggered in the destination
> QEMU process during live migration.
>
> ----------------------------------------------------------------
>
> Vladimir Sementsov-Ogievskiy (2):
> migration/block-dirty-bitmap: make incoming disabled bitmaps busy
> migrate-bitmaps-postcopy-test: check that we can't remove in-flight
> bitmaps
This failed the 'qsd-jobs' iotest on s390x:
TEST iotest-qcow2: 309
TEST iotest-qcow2: 313
TEST iotest-qcow2: qsd-jobs [fail]
QEMU --
"/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-system-s390x"
-nodefaults -display none -accel qtest
QEMU_IMG -- "/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-img"
QEMU_IO --
"/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-io" --cache
writeback --aio threads -f qcow2
QEMU_NBD -- "/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-nbd"
IMGFMT -- qcow2
IMGPROTO -- file
PLATFORM -- Linux/s390x qemu01 4.15.0-132-generic
TEST_DIR -- /home/ubuntu/qemu/build/all/tests/qemu-iotests/scratch
SOCK_DIR -- /tmp/tmp807j_qyh
SOCKET_SCM_HELPER --
/home/ubuntu/qemu/build/all/tests/qemu-iotests/socket_scm_helper
--- /home/ubuntu/qemu/tests/qemu-iotests/tests/qsd-jobs.out
+++ qsd-jobs.out.bad
@@ -9,11 +9,11 @@
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id":
"job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id":
"job0"}}
{"return": {}}
+{"return": {}}
+{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "paused", "id":
"job0"}}
+{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id":
"job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id":
"job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "BLOCK_JOB_READY", "data": {"device": "job0", "len": 0,
"offset": 0, "speed": 0, "type": "commit"}}
-{"return": {}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "standby", "id":
"job0"}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id":
"job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id":
"job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id":
"job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
"event": "BLOCK_JOB_COMPLETED", "data": {"device": "job0", "len": 0,
"offset": 0, "speed": 0, "type": "commit"}}
Not run: 172 186 192 220 287
Failures: qsd-jobs
Failed 1 of 118 iotests
thanks
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-24 18:05 ` Peter Maydell
@ 2021-03-24 20:18 ` Vladimir Sementsov-Ogievskiy
2021-03-24 20:42 ` Peter Maydell
0 siblings, 1 reply; 31+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-03-24 20:18 UTC (permalink / raw)
To: Peter Maydell, Stefan Hajnoczi
Cc: QEMU Developers, John Snow, Juan Quintela,
Dr. David Alan Gilbert, Eric Blake, Fam Zheng,
Michael S. Tsirkin, Eduardo Habkost, Kevin Wolf,
Marcel Apfelbaum, Qemu-block, Max Reitz
24.03.2021 21:05, Peter Maydell wrote:
> On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>
>> The following changes since commit 67c1115edd98f388ca89dd38322ea3fadf034523:
>>
>> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210323-pull-request' into staging (2021-03-23 23:47:30 +0000)
>>
>> are available in the Git repository at:
>>
>> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>>
>> for you to fetch changes up to 3460fd7f3959d1fa7bcc255796844aa261c805a4:
>>
>> migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps (2021-03-24 13:41:19 +0000)
>>
>> ----------------------------------------------------------------
>> Pull request
>>
>> This dirty bitmap fix solves a crash that can be triggered in the destination
>> QEMU process during live migration.
>>
>> ----------------------------------------------------------------
>>
>> Vladimir Sementsov-Ogievskiy (2):
>> migration/block-dirty-bitmap: make incoming disabled bitmaps busy
>> migrate-bitmaps-postcopy-test: check that we can't remove in-flight
>> bitmaps
>
> This failed the 'qsd-jobs' iotest on s390x:
>
>
> TEST iotest-qcow2: 309
> TEST iotest-qcow2: 313
> TEST iotest-qcow2: qsd-jobs [fail]
> QEMU --
> "/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-system-s390x"
> -nodefaults -display none -accel qtest
> QEMU_IMG -- "/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-img"
> QEMU_IO --
> "/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-io" --cache
> writeback --aio threads -f qcow2
> QEMU_NBD -- "/home/ubuntu/qemu/build/all/tests/qemu-iotests/../../qemu-nbd"
> IMGFMT -- qcow2
> IMGPROTO -- file
> PLATFORM -- Linux/s390x qemu01 4.15.0-132-generic
> TEST_DIR -- /home/ubuntu/qemu/build/all/tests/qemu-iotests/scratch
> SOCK_DIR -- /tmp/tmp807j_qyh
> SOCKET_SCM_HELPER --
> /home/ubuntu/qemu/build/all/tests/qemu-iotests/socket_scm_helper
> --- /home/ubuntu/qemu/tests/qemu-iotests/tests/qsd-jobs.out
> +++ qsd-jobs.out.bad
> @@ -9,11 +9,11 @@
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id":
> "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id":
> "job0"}}
> {"return": {}}
> +{"return": {}}
> +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "paused", "id":
> "job0"}}
> +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id":
> "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id":
> "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "BLOCK_JOB_READY", "data": {"device": "job0", "len": 0,
> "offset": 0, "speed": 0, "type": "commit"}}
> -{"return": {}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "standby", "id":
> "job0"}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id":
> "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id":
> "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id":
> "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP},
> "event": "BLOCK_JOB_COMPLETED", "data": {"device": "job0", "len": 0,
> "offset": 0, "speed": 0, "type": "commit"}}
> Not run: 172 186 192 220 287
> Failures: qsd-jobs
> Failed 1 of 118 iotests
>
> thanks
> -- PMM
>
I can't believe it related. My commit modifies bitmap status during bitmaps migration on target vm. There is no kind of migration in qsd-jobs test.
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-24 20:18 ` Vladimir Sementsov-Ogievskiy
@ 2021-03-24 20:42 ` Peter Maydell
2021-03-25 9:56 ` Stefan Hajnoczi
0 siblings, 1 reply; 31+ messages in thread
From: Peter Maydell @ 2021-03-24 20:42 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: Fam Zheng, Kevin Wolf, Eduardo Habkost, Qemu-block,
Juan Quintela, John Snow, Michael S. Tsirkin,
Dr. David Alan Gilbert, QEMU Developers, Stefan Hajnoczi,
Max Reitz
On Wed, 24 Mar 2021 at 20:18, Vladimir Sementsov-Ogievskiy
<vsementsov@virtuozzo.com> wrote:
>
> 24.03.2021 21:05, Peter Maydell wrote:
> > On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >>
> >> Vladimir Sementsov-Ogievskiy (2):
> >> migration/block-dirty-bitmap: make incoming disabled bitmaps busy
> >> migrate-bitmaps-postcopy-test: check that we can't remove in-flight
> >> bitmaps
> >
> > This failed the 'qsd-jobs' iotest on s390x:
> I can't believe it related. My commit modifies bitmap status during bitmaps migration on target vm. There is no kind of migration in qsd-jobs test.
It's possible it's an intermittent, but it's not one I've seen
before. We still have lots of time this release cycle to figure
out the issue and get this fix in.
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-24 20:42 ` Peter Maydell
@ 2021-03-25 9:56 ` Stefan Hajnoczi
2021-03-25 10:17 ` Vladimir Sementsov-Ogievskiy
0 siblings, 1 reply; 31+ messages in thread
From: Stefan Hajnoczi @ 2021-03-25 9:56 UTC (permalink / raw)
To: Peter Maydell
Cc: Fam Zheng, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
Eduardo Habkost, Qemu-block, Juan Quintela, John Snow,
Michael S. Tsirkin, QEMU Developers, Dr. David Alan Gilbert,
Max Reitz
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On Wed, Mar 24, 2021 at 08:42:27PM +0000, Peter Maydell wrote:
> On Wed, 24 Mar 2021 at 20:18, Vladimir Sementsov-Ogievskiy
> <vsementsov@virtuozzo.com> wrote:
> >
> > 24.03.2021 21:05, Peter Maydell wrote:
> > > On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > >>
> > >> Vladimir Sementsov-Ogievskiy (2):
> > >> migration/block-dirty-bitmap: make incoming disabled bitmaps busy
> > >> migrate-bitmaps-postcopy-test: check that we can't remove in-flight
> > >> bitmaps
> > >
> > > This failed the 'qsd-jobs' iotest on s390x:
>
> > I can't believe it related. My commit modifies bitmap status during bitmaps migration on target vm. There is no kind of migration in qsd-jobs test.
>
> It's possible it's an intermittent, but it's not one I've seen
> before. We still have lots of time this release cycle to figure
> out the issue and get this fix in.
Vladimir: I'll get hold of an s390 machine and try to reproduce the
failure. I should have some news by Monday.
Let's put the pull request on hold for now.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-25 9:56 ` Stefan Hajnoczi
@ 2021-03-25 10:17 ` Vladimir Sementsov-Ogievskiy
2021-03-25 16:28 ` Stefan Hajnoczi
0 siblings, 1 reply; 31+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2021-03-25 10:17 UTC (permalink / raw)
To: Stefan Hajnoczi, Peter Maydell
Cc: QEMU Developers, John Snow, Juan Quintela,
Dr. David Alan Gilbert, Eric Blake, Fam Zheng,
Michael S. Tsirkin, Eduardo Habkost, Kevin Wolf,
Marcel Apfelbaum, Qemu-block, Max Reitz
25.03.2021 12:56, Stefan Hajnoczi wrote:
> On Wed, Mar 24, 2021 at 08:42:27PM +0000, Peter Maydell wrote:
>> On Wed, 24 Mar 2021 at 20:18, Vladimir Sementsov-Ogievskiy
>> <vsementsov@virtuozzo.com> wrote:
>>>
>>> 24.03.2021 21:05, Peter Maydell wrote:
>>>> On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>>>>>
>>>>> Vladimir Sementsov-Ogievskiy (2):
>>>>> migration/block-dirty-bitmap: make incoming disabled bitmaps busy
>>>>> migrate-bitmaps-postcopy-test: check that we can't remove in-flight
>>>>> bitmaps
>>>>
>>>> This failed the 'qsd-jobs' iotest on s390x:
>>
>>> I can't believe it related. My commit modifies bitmap status during bitmaps migration on target vm. There is no kind of migration in qsd-jobs test.
>>
>> It's possible it's an intermittent, but it's not one I've seen
>> before. We still have lots of time this release cycle to figure
>> out the issue and get this fix in.
>
> Vladimir: I'll get hold of an s390 machine and try to reproduce the
> failure. I should have some news by Monday.
Thanks! My path modifies migration/block-dirty-bitmap.c. qsd-jobs runs block-commit and block-stream jobs and don't start any kind of migration or snapshot or savevm, so it seems impossible that qsd-jobs runs the code touched by my patch..
>
> Let's put the pull request on hold for now.
>
> Stefan
>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-25 10:17 ` Vladimir Sementsov-Ogievskiy
@ 2021-03-25 16:28 ` Stefan Hajnoczi
2021-03-25 16:36 ` Peter Maydell
0 siblings, 1 reply; 31+ messages in thread
From: Stefan Hajnoczi @ 2021-03-25 16:28 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: Fam Zheng, Peter Maydell, Eduardo Habkost, Qemu-block,
Juan Quintela, John Snow, Michael S. Tsirkin, QEMU Developers,
Dr. David Alan Gilbert, Kevin Wolf, Max Reitz
[-- Attachment #1: Type: text/plain, Size: 3741 bytes --]
On Thu, Mar 25, 2021 at 01:17:50PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> 25.03.2021 12:56, Stefan Hajnoczi wrote:
> > On Wed, Mar 24, 2021 at 08:42:27PM +0000, Peter Maydell wrote:
> > > On Wed, 24 Mar 2021 at 20:18, Vladimir Sementsov-Ogievskiy
> > > <vsementsov@virtuozzo.com> wrote:
> > > >
> > > > 24.03.2021 21:05, Peter Maydell wrote:
> > > > > On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > > > > >
> > > > > > Vladimir Sementsov-Ogievskiy (2):
> > > > > > migration/block-dirty-bitmap: make incoming disabled bitmaps busy
> > > > > > migrate-bitmaps-postcopy-test: check that we can't remove in-flight
> > > > > > bitmaps
> > > > >
> > > > > This failed the 'qsd-jobs' iotest on s390x:
> > >
> > > > I can't believe it related. My commit modifies bitmap status during bitmaps migration on target vm. There is no kind of migration in qsd-jobs test.
> > >
> > > It's possible it's an intermittent, but it's not one I've seen
> > > before. We still have lots of time this release cycle to figure
> > > out the issue and get this fix in.
> >
> > Vladimir: I'll get hold of an s390 machine and try to reproduce the
> > failure. I should have some news by Monday.
>
> Thanks! My path modifies migration/block-dirty-bitmap.c. qsd-jobs runs block-commit and block-stream jobs and don't start any kind of migration or snapshot or savevm, so it seems impossible that qsd-jobs runs the code touched by my patch..
Confirmed. The failure is not related to this pull request.
I reproduced the same s390x host failure on commit
9e2e9fe3df9f539f8b6941ceb96d25355fdae47e (HEAD -> master, tag:
v6.0.0-rc0, origin/master, origin/HEAD):
qsd-jobs fail [11:04:58] [11:04:58] 0.1s output mismatch (see qsd-jobs.out.bad)
--- /root/qemu/tests/qemu-iotests/tests/qsd-jobs.out
+++ qsd-jobs.out.bad
@@ -9,11 +9,11 @@
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "job0"}}
{"return": {}}
+{"return": {}}
+{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "paused", "id": "job0"}}
+{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_READY", "data": {"device": "job0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
-{"return": {}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "standby", "id": "job0"}}
-{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "job0"}}
{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "job0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
Peter: Please merge this pull request since the failure is pre-existing.
Thanks,
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-25 16:28 ` Stefan Hajnoczi
@ 2021-03-25 16:36 ` Peter Maydell
2021-03-25 17:40 ` Stefan Hajnoczi
0 siblings, 1 reply; 31+ messages in thread
From: Peter Maydell @ 2021-03-25 16:36 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
Eduardo Habkost, Qemu-block, Juan Quintela, John Snow,
Michael S. Tsirkin, QEMU Developers, Dr. David Alan Gilbert,
Max Reitz
On Thu, 25 Mar 2021 at 16:28, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> On Thu, Mar 25, 2021 at 01:17:50PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > Thanks! My path modifies migration/block-dirty-bitmap.c. qsd-jobs runs block-commit and block-stream jobs and don't start any kind of migration or snapshot or savevm, so it seems impossible that qsd-jobs runs the code touched by my patch..
>
> Confirmed. The failure is not related to this pull request.
>
> I reproduced the same s390x host failure on commit
> 9e2e9fe3df9f539f8b6941ceb96d25355fdae47e (HEAD -> master, tag:
> v6.0.0-rc0, origin/master, origin/HEAD):
>
> qsd-jobs fail [11:04:58] [11:04:58] 0.1s output mismatch (see qsd-jobs.out.bad)
> --- /root/qemu/tests/qemu-iotests/tests/qsd-jobs.out
> +++ qsd-jobs.out.bad
> @@ -9,11 +9,11 @@
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "job0"}}
> {"return": {}}
> +{"return": {}}
> +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "paused", "id": "job0"}}
> +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_READY", "data": {"device": "job0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
> -{"return": {}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "standby", "id": "job0"}}
> -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "job0"}}
> {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "job0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
>
> Peter: Please merge this pull request since the failure is pre-existing.
OK, I'll run the pullreq through merge testing again.
Could somebody on the block team look at this s390 host intermittent ?
thanks
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-25 16:36 ` Peter Maydell
@ 2021-03-25 17:40 ` Stefan Hajnoczi
0 siblings, 0 replies; 31+ messages in thread
From: Stefan Hajnoczi @ 2021-03-25 17:40 UTC (permalink / raw)
To: Peter Maydell
Cc: Fam Zheng, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
Eduardo Habkost, Qemu-block, Juan Quintela, John Snow,
Michael S. Tsirkin, QEMU Developers, Dr. David Alan Gilbert,
Max Reitz
[-- Attachment #1: Type: text/plain, Size: 3043 bytes --]
On Thu, Mar 25, 2021 at 04:36:43PM +0000, Peter Maydell wrote:
> On Thu, 25 Mar 2021 at 16:28, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> >
> > On Thu, Mar 25, 2021 at 01:17:50PM +0300, Vladimir Sementsov-Ogievskiy wrote:
> > > Thanks! My path modifies migration/block-dirty-bitmap.c. qsd-jobs runs block-commit and block-stream jobs and don't start any kind of migration or snapshot or savevm, so it seems impossible that qsd-jobs runs the code touched by my patch..
> >
> > Confirmed. The failure is not related to this pull request.
> >
> > I reproduced the same s390x host failure on commit
> > 9e2e9fe3df9f539f8b6941ceb96d25355fdae47e (HEAD -> master, tag:
> > v6.0.0-rc0, origin/master, origin/HEAD):
> >
> > qsd-jobs fail [11:04:58] [11:04:58] 0.1s output mismatch (see qsd-jobs.out.bad)
> > --- /root/qemu/tests/qemu-iotests/tests/qsd-jobs.out
> > +++ qsd-jobs.out.bad
> > @@ -9,11 +9,11 @@
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "job0"}}
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "job0"}}
> > {"return": {}}
> > +{"return": {}}
> > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "paused", "id": "job0"}}
> > +{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "job0"}}
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "job0"}}
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_READY", "data": {"device": "job0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
> > -{"return": {}}
> > -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "standby", "id": "job0"}}
> > -{"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "job0"}}
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "job0"}}
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "job0"}}
> > {"timestamp": {"seconds": TIMESTAMP, "microseconds": TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "job0", "len": 0, "offset": 0, "speed": 0, "type": "commit"}}
> >
> > Peter: Please merge this pull request since the failure is pre-existing.
>
> OK, I'll run the pullreq through merge testing again.
>
> Could somebody on the block team look at this s390 host intermittent ?
I need to look into more s390x stuff on Monday so I'd be happy to dig
deeper then.
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2021-03-24 14:52 Stefan Hajnoczi
2021-03-24 18:05 ` Peter Maydell
@ 2021-03-26 10:22 ` Peter Maydell
1 sibling, 0 replies; 31+ messages in thread
From: Peter Maydell @ 2021-03-26 10:22 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Fam Zheng, Kevin Wolf, Vladimir Sementsov-Ogievskiy,
Eduardo Habkost, Qemu-block, Juan Quintela, John Snow,
Michael S. Tsirkin, QEMU Developers, Dr. David Alan Gilbert,
Max Reitz
On Wed, 24 Mar 2021 at 14:52, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 67c1115edd98f388ca89dd38322ea3fadf034523:
>
> Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210323-pull-request' into staging (2021-03-23 23:47:30 +0000)
>
> are available in the Git repository at:
>
> https://gitlab.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 3460fd7f3959d1fa7bcc255796844aa261c805a4:
>
> migrate-bitmaps-postcopy-test: check that we can't remove in-flight bitmaps (2021-03-24 13:41:19 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> This dirty bitmap fix solves a crash that can be triggered in the destination
> QEMU process during live migration.
>
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2020-02-10 9:23 Stefan Hajnoczi
2020-02-10 18:09 ` Peter Maydell
0 siblings, 1 reply; 31+ messages in thread
From: Stefan Hajnoczi @ 2020-02-10 9:23 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, Stefan Hajnoczi, qemu-block,
Max Reitz, Fam Zheng, Eduardo Habkost
The following changes since commit 346ed3151f1c43e72c40cb55b392a1d4cface62c:
Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20200206.0' into staging (2020-02-07 11:52:15 +0000)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to 11a18c84db4a71497d3d40769688a01b6f64b2ad:
hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX host (2020-02-07 16:49:39 +0000)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Philippe Mathieu-Daudé (1):
hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX host
Vladimir Sementsov-Ogievskiy (1):
block: fix crash on zero-length unaligned write and read
block/io.c | 28 +++++++++++++++++++++++++++-
hw/core/machine.c | 3 ++-
2 files changed, 29 insertions(+), 2 deletions(-)
--
2.24.1
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2020-02-10 9:23 Stefan Hajnoczi
@ 2020-02-10 18:09 ` Peter Maydell
0 siblings, 0 replies; 31+ messages in thread
From: Peter Maydell @ 2020-02-10 18:09 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Fam Zheng, Eduardo Habkost, Qemu-block,
QEMU Developers, Max Reitz
On Mon, 10 Feb 2020 at 09:23, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 346ed3151f1c43e72c40cb55b392a1d4cface62c:
>
> Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20200206.0' into staging (2020-02-07 11:52:15 +0000)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to 11a18c84db4a71497d3d40769688a01b6f64b2ad:
>
> hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX host (2020-02-07 16:49:39 +0000)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Philippe Mathieu-Daudé (1):
> hw/core: Allow setting 'virtio-blk-device.scsi' property on OSX host
>
> Vladimir Sementsov-Ogievskiy (1):
> block: fix crash on zero-length unaligned write and read
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2019-10-25 19:18 Stefan Hajnoczi
2019-10-26 9:13 ` Peter Maydell
0 siblings, 1 reply; 31+ messages in thread
From: Stefan Hajnoczi @ 2019-10-25 19:18 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, qemu-block, Michael S. Tsirkin,
Max Reitz, Stefan Hajnoczi, Fam Zheng
The following changes since commit 58560ad254fbda71d4daa6622d71683190070ee2:
Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20191024' into staging (2019-10-24 16:22:58 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to d154ef37ff885918fa3e512fd7a8e42870291667:
yield_until_fd_readable: make it work with any AioContect (2019-10-25 14:38:29 +0200)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Dietmar Maurer (1):
yield_until_fd_readable: make it work with any AioContect
Julia Suvorova (1):
virtio-blk: Add blk_drain() to virtio_blk_device_unrealize()
hw/block/virtio-blk.c | 1 +
util/qemu-coroutine-io.c | 7 +++++--
2 files changed, 6 insertions(+), 2 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2019-10-25 19:18 Stefan Hajnoczi
@ 2019-10-26 9:13 ` Peter Maydell
0 siblings, 0 replies; 31+ messages in thread
From: Peter Maydell @ 2019-10-26 9:13 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Fam Zheng, Qemu-block, Michael S. Tsirkin,
QEMU Developers, Max Reitz
On Fri, 25 Oct 2019 at 20:18, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 58560ad254fbda71d4daa6622d71683190070ee2:
>
> Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-4.2-20191024' into staging (2019-10-24 16:22:58 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to d154ef37ff885918fa3e512fd7a8e42870291667:
>
> yield_until_fd_readable: make it work with any AioContect (2019-10-25 14:38:29 +0200)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
>
> Dietmar Maurer (1):
> yield_until_fd_readable: make it work with any AioContect
>
> Julia Suvorova (1):
> virtio-blk: Add blk_drain() to virtio_blk_device_unrealize()
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/4.2
for any user-visible changes.
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
* [PULL 0/2] Block patches
@ 2019-09-25 17:43 Stefan Hajnoczi
2019-09-26 6:16 ` no-reply
2019-09-26 12:56 ` Peter Maydell
0 siblings, 2 replies; 31+ messages in thread
From: Stefan Hajnoczi @ 2019-09-25 17:43 UTC (permalink / raw)
To: qemu-devel
Cc: Kevin Wolf, Peter Maydell, qemu-block, Michael S. Tsirkin,
Max Reitz, Stefan Hajnoczi
The following changes since commit 240ab11fb72049d6373cbbec8d788f8e411a00bc:
Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190924' into staging (2019-09-24 15:36:31 +0100)
are available in the Git repository at:
https://github.com/stefanha/qemu.git tags/block-pull-request
for you to fetch changes up to f9a7e3698a737ee75a7b0af34203303df982550f:
virtio-blk: schedule virtio_notify_config to run on main context (2019-09-25 18:06:36 +0100)
----------------------------------------------------------------
Pull request
----------------------------------------------------------------
Sergio Lopez (1):
virtio-blk: schedule virtio_notify_config to run on main context
Vladimir Sementsov-Ogievskiy (1):
util/ioc.c: try to reassure Coverity about qemu_iovec_init_extended
hw/block/virtio-blk.c | 16 +++++++++++++++-
util/iov.c | 3 ++-
2 files changed, 17 insertions(+), 2 deletions(-)
--
2.21.0
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2019-09-25 17:43 Stefan Hajnoczi
@ 2019-09-26 6:16 ` no-reply
2019-09-26 12:06 ` Vladimir Sementsov-Ogievskiy
2019-09-26 12:56 ` Peter Maydell
1 sibling, 1 reply; 31+ messages in thread
From: no-reply @ 2019-09-26 6:16 UTC (permalink / raw)
To: stefanha
Cc: kwolf, peter.maydell, qemu-block, mst, qemu-devel, mreitz, stefanha
Patchew URL: https://patchew.org/QEMU/20190925174400.8578-1-stefanha@redhat.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===
CC authz/list.o
CC authz/listfile.o
/tmp/qemu-test/src/util/iov.c: In function 'qemu_iovec_init_extended':
/tmp/qemu-test/src/util/iov.c:451:9: error: 'mid_iov' may be used uninitialized in this function [-Werror=maybe-uninitialized]
memcpy(p, mid_iov, mid_niov * sizeof(*p));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
The full log is available at
http://patchew.org/logs/20190925174400.8578-1-stefanha@redhat.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2019-09-26 6:16 ` no-reply
@ 2019-09-26 12:06 ` Vladimir Sementsov-Ogievskiy
0 siblings, 0 replies; 31+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2019-09-26 12:06 UTC (permalink / raw)
To: qemu-devel, no-reply, stefanha
Cc: kwolf, peter.maydell, mreitz, qemu-block, mst
26.09.2019 9:16, no-reply@patchew.org wrote:
> Patchew URL: https://patchew.org/QEMU/20190925174400.8578-1-stefanha@redhat.com/
>
>
>
> Hi,
>
> This series failed the docker-mingw@fedora build test. Please find the testing commands and
> their output below. If you have Docker installed, you can probably reproduce it
> locally.
>
> === TEST SCRIPT BEGIN ===
> #! /bin/bash
> export ARCH=x86_64
> make docker-image-fedora V=1 NETWORK=1
> time make docker-test-mingw@fedora J=14 NETWORK=1
> === TEST SCRIPT END ===
>
> CC authz/list.o
> CC authz/listfile.o
> /tmp/qemu-test/src/util/iov.c: In function 'qemu_iovec_init_extended':
> /tmp/qemu-test/src/util/iov.c:451:9: error: 'mid_iov' may be used uninitialized in this function [-Werror=maybe-uninitialized]
> memcpy(p, mid_iov, mid_niov * sizeof(*p));
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
>
>
> The full log is available at
> http://patchew.org/logs/20190925174400.8578-1-stefanha@redhat.com/testing.docker-mingw@fedora/?type=message.
> ---
> Email generated automatically by Patchew [https://patchew.org/].
> Please send your feedback to patchew-devel@redhat.com
>
Actually it's obvious that it is initialized here:
We go here only if mid_niov, which may be set only in "if (mid_len)", and mid_iov is set in same "if (mid_len)".
My clang don't warn.
Still, we may just initialize mid_iov to NULL and don't care.
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 31+ messages in thread
* Re: [PULL 0/2] Block patches
2019-09-25 17:43 Stefan Hajnoczi
2019-09-26 6:16 ` no-reply
@ 2019-09-26 12:56 ` Peter Maydell
1 sibling, 0 replies; 31+ messages in thread
From: Peter Maydell @ 2019-09-26 12:56 UTC (permalink / raw)
To: Stefan Hajnoczi
Cc: Kevin Wolf, Michael S. Tsirkin, QEMU Developers, Qemu-block, Max Reitz
On Wed, 25 Sep 2019 at 18:44, Stefan Hajnoczi <stefanha@redhat.com> wrote:
>
> The following changes since commit 240ab11fb72049d6373cbbec8d788f8e411a00bc:
>
> Merge remote-tracking branch 'remotes/aperard/tags/pull-xen-20190924' into staging (2019-09-24 15:36:31 +0100)
>
> are available in the Git repository at:
>
> https://github.com/stefanha/qemu.git tags/block-pull-request
>
> for you to fetch changes up to f9a7e3698a737ee75a7b0af34203303df982550f:
>
> virtio-blk: schedule virtio_notify_config to run on main context (2019-09-25 18:06:36 +0100)
>
> ----------------------------------------------------------------
> Pull request
>
> ----------------------------------------------------------------
Hi; I'm dropping this pullreq as it makes one of the patchew build
configs fail to compile.
thanks
-- PMM
^ permalink raw reply [flat|nested] 31+ messages in thread
end of thread, other threads:[~2024-01-25 15:48 UTC | newest]
Thread overview: 31+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-13 14:33 [PULL 0/2] Block patches Stefan Hajnoczi
2019-12-13 14:33 ` [PULL 1/2] virtio-blk: advertise F_WCE (F_FLUSH) if F_CONFIG_WCE is advertised Stefan Hajnoczi
2019-12-13 14:33 ` [PULL 2/2] iothread: document -object iothread on man page Stefan Hajnoczi
2019-12-13 21:10 ` [PULL 0/2] Block patches Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2024-01-22 16:01 Stefan Hajnoczi
2024-01-25 15:11 ` Peter Maydell
2024-01-25 15:47 ` Michael Tokarev
2023-04-24 17:55 Stefan Hajnoczi
2023-04-25 11:15 ` Richard Henderson
2022-07-07 8:12 Stefan Hajnoczi
2022-07-07 10:51 ` Richard Henderson
2021-10-11 12:40 Stefan Hajnoczi
2021-10-11 18:23 ` Richard Henderson
2021-03-24 14:52 Stefan Hajnoczi
2021-03-24 18:05 ` Peter Maydell
2021-03-24 20:18 ` Vladimir Sementsov-Ogievskiy
2021-03-24 20:42 ` Peter Maydell
2021-03-25 9:56 ` Stefan Hajnoczi
2021-03-25 10:17 ` Vladimir Sementsov-Ogievskiy
2021-03-25 16:28 ` Stefan Hajnoczi
2021-03-25 16:36 ` Peter Maydell
2021-03-25 17:40 ` Stefan Hajnoczi
2021-03-26 10:22 ` Peter Maydell
2020-02-10 9:23 Stefan Hajnoczi
2020-02-10 18:09 ` Peter Maydell
2019-10-25 19:18 Stefan Hajnoczi
2019-10-26 9:13 ` Peter Maydell
2019-09-25 17:43 Stefan Hajnoczi
2019-09-26 6:16 ` no-reply
2019-09-26 12:06 ` Vladimir Sementsov-Ogievskiy
2019-09-26 12:56 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).