From: Cleber Rosa <crosa@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: fam@euphon.net, ehabkost@redhat.com, jsnow@redhat.com,
qemu-devel@nongnu.org, alex.bennee@linaro.org, philmd@redhat.com
Subject: Re: [PATCH v3 5/5] python/qemu: Remove unneeded imports in __init__
Date: Sun, 15 Dec 2019 16:19:23 -0500 [thread overview]
Message-ID: <20191215211923.GE22814@localhost.localdomain> (raw)
In-Reply-To: <20191212125831.2654-6-wainersm@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 901 bytes --]
On Thu, Dec 12, 2019 at 07:58:31AM -0500, Wainer dos Santos Moschetta wrote:
> __init_.py import some sub-modules unnecessarily. So let's
> clean it up.
>
> Signed-off-by: Wainer dos Santos Moschetta <wainersm@redhat.com>
> Suggested-by: Cleber Rosa <crosa@redhat.com>
> ---
> python/qemu/__init__.py | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/python/qemu/__init__.py b/python/qemu/__init__.py
> index eff17a306e..4ca06c34a4 100644
> --- a/python/qemu/__init__.py
> +++ b/python/qemu/__init__.py
> @@ -9,9 +9,3 @@
> # This work is licensed under the terms of the GNU GPL, version 2. See
> # the COPYING file in the top-level directory.
> #
> -# Based on qmp.py.
> -#
> -
> -from . import qmp
> -from . import machine
> -from . import accel
> --
> 2.21.0
>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-12-15 21:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 12:58 [PATCH v3 0/5] python/qemu: New accel module and improvements Wainer dos Santos Moschetta
2019-12-12 12:58 ` [PATCH v3 1/5] python/qemu: Move kvm_available() to its own module Wainer dos Santos Moschetta
2019-12-15 20:24 ` Cleber Rosa
2019-12-12 12:58 ` [PATCH v3 2/5] python/qemu: accel: Add list_accel() method Wainer dos Santos Moschetta
2019-12-15 21:04 ` Cleber Rosa
2019-12-12 12:58 ` [PATCH v3 3/5] python/qemu: accel: Strengthen kvm_available() checks Wainer dos Santos Moschetta
2019-12-12 12:58 ` [PATCH v3 4/5] python/qemu: accel: Add tcg_available() method Wainer dos Santos Moschetta
2019-12-12 12:58 ` [PATCH v3 5/5] python/qemu: Remove unneeded imports in __init__ Wainer dos Santos Moschetta
2019-12-15 21:19 ` Cleber Rosa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191215211923.GE22814@localhost.localdomain \
--to=crosa@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).