From: Stefan Hajnoczi <stefanha@gmail.com>
To: Li hangjing <lihangjing@baidu.com>
Cc: chaiwen@baidu.com, xieyongji@baidu.com, qemu-devel@nongnu.org,
stefanha@redhat.com, qemu-stable@nongnu.org
Subject: Re: [PATCH] virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh
Date: Thu, 19 Dec 2019 16:21:00 +0000 [thread overview]
Message-ID: <20191219162100.GI1624084@stefanha-x1.localdomain> (raw)
In-Reply-To: <20191216023050.48620-1-lihangjing@baidu.com>
[-- Attachment #1: Type: text/plain, Size: 752 bytes --]
On Mon, Dec 16, 2019 at 10:30:50AM +0800, Li hangjing wrote:
> From: Li Hangjing <lihangjing@baidu.com>
>
> When the number of a virtio-blk device's virtqueues is larger than
> BITS_PER_LONG, the out-of-bounds access to bitmap[ ] will occur.
>
> Fixes: e21737ab15 ("virtio-blk: multiqueue batch notify")
> Cc: qemu-stable@nongnu.org
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Li Hangjing <lihangjing@baidu.com>
> Reviewed-by: Xie Yongji <xieyongji@baidu.com>
> Reviewed-by: Chai Wen <chaiwen@baidu.com>
> ---
> hw/block/dataplane/virtio-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Ouch, thank you for the fix! Applied to my block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-12-19 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 2:30 [PATCH] virtio-blk: fix out-of-bounds access to bitmap in notify_guest_bh Li hangjing
2019-12-19 16:21 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219162100.GI1624084@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=chaiwen@baidu.com \
--cc=lihangjing@baidu.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xieyongji@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).