From: Corey Minyard <minyard@acm.org>
To: Igor Mammedov <imammedo@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Shannon Zhao <shannon.zhaosl@gmail.com>,
Corey Minyard <cminyard@mvista.com>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH] i386:acpi: Remove _HID from the SMBus ACPI entry
Date: Tue, 7 Jan 2020 14:11:06 -0600 [thread overview]
Message-ID: <20200107201106.GA2874@minyard.net> (raw)
In-Reply-To: <20200107175821.72556c39@redhat.com>
On Tue, Jan 07, 2020 at 05:58:21PM +0100, Igor Mammedov wrote:
> On Mon, 6 Jan 2020 09:27:05 -0600
> minyard@acm.org wrote:
>
> > From: Corey Minyard <cminyard@mvista.com>
> >
> > Per the ACPI spec (version 6.1, section 6.1.5 _HID) it is not required
> > on enumerated buses (like PCI in this case), _ADR is required (and is
> > already there). And the _HID value is wrong. Linux appears to ignore
> > the _HID entry, but it confuses Windows.
>
> Corey,
>
> Could you clarify as what "confuses Windows" means?
> s/confuses Windows/description of the observed problem and on what windows version/
Yeah, I should have done that. The error is not given, but the report
says" "It is detected by Windows 10 as 'Unknown Device' and there is no
driver available." Link is https://bugs.launchpad.net/qemu/+bug/1856724
I'll add that to the text, along with the link.
-corey
>
> >
> > Signed-off-by: Corey Minyard <cminyard@mvista.com>
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Igor Mammedov <imammedo@redhat.com>
> > ---
> > hw/i386/acpi-build.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index 7b8da62d41..ab73a8f4c8 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -1815,7 +1815,6 @@ static void build_smb0(Aml *table, I2CBus *smbus, int devnr, int func)
> > Aml *scope = aml_scope("_SB.PCI0");
> > Aml *dev = aml_device("SMB0");
> >
> > - aml_append(dev, aml_name_decl("_HID", aml_eisaid("APP0005")));
> > aml_append(dev, aml_name_decl("_ADR", aml_int(devnr << 16 | func)));
> > build_acpi_ipmi_devices(dev, BUS(smbus), "\\_SB.PCI0.SMB0");
> > aml_append(scope, dev);
>
next prev parent reply other threads:[~2020-01-07 20:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:27 [PATCH] i386:acpi: Remove _HID from the SMBus ACPI entry minyard
2020-01-07 15:52 ` Igor Mammedov
2020-01-07 16:58 ` Igor Mammedov
2020-01-07 20:11 ` Corey Minyard [this message]
2020-01-13 14:05 ` Michael S. Tsirkin
2020-01-13 14:42 ` minyard
2020-01-13 16:08 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200107201106.GA2874@minyard.net \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).