From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, marcandre.lureau@gmail.com, armbru@redhat.com,
qemu-block@nongnu.org
Subject: [PATCH 0/4] qmp: Optionally run handlers in coroutines
Date: Thu, 9 Jan 2020 19:35:41 +0100 [thread overview]
Message-ID: <20200109183545.27452-1-kwolf@redhat.com> (raw)
Some QMP command handlers can block the main loop for a relatively long
time, for example because they perform some I/O. This is quite nasty.
Allowing such handlers to run in a coroutine where they can yield (and
therefore release the BQL) while waiting for an event such as I/O
completion solves the problem.
This series adds the infrastructure to allow this and switches
block_resize to run in a coroutine as a first example.
This is an alternative solution to Marc-André's "monitor: add
asynchronous command type" series.
Kevin Wolf (4):
qapi: Add a 'coroutine' flag for commands
block: Mark 'block_resize' as coroutine
vl: Initialise main loop earlier
qmp: Move dispatcher to a coroutine
qapi/block-core.json | 3 +-
tests/qapi-schema/qapi-schema-test.json | 1 +
docs/devel/qapi-code-gen.txt | 4 ++
include/qapi/qmp/dispatch.h | 3 +
monitor/monitor-internal.h | 5 +-
monitor/monitor.c | 24 ++++---
monitor/qmp.c | 83 ++++++++++++++++---------
qapi/qmp-dispatch.c | 38 ++++++++++-
tests/test-qmp-cmds.c | 4 ++
vl.c | 10 +--
scripts/qapi/commands.py | 17 +++--
scripts/qapi/doc.py | 2 +-
scripts/qapi/expr.py | 4 +-
scripts/qapi/introspect.py | 2 +-
scripts/qapi/schema.py | 9 ++-
tests/qapi-schema/qapi-schema-test.out | 2 +
tests/qapi-schema/test-qapi.py | 7 ++-
17 files changed, 155 insertions(+), 63 deletions(-)
--
2.20.1
next reply other threads:[~2020-01-09 18:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-09 18:35 Kevin Wolf [this message]
2020-01-09 18:35 ` [PATCH 1/4] qapi: Add a 'coroutine' flag for commands Kevin Wolf
2020-01-10 19:00 ` Eric Blake
2020-01-13 10:46 ` Kevin Wolf
2020-01-09 18:35 ` [PATCH 2/4] block: Mark 'block_resize' as coroutine Kevin Wolf
2020-01-13 16:56 ` Stefan Hajnoczi
2020-01-13 17:10 ` Kevin Wolf
2020-01-14 16:30 ` Stefan Hajnoczi
2020-01-09 18:35 ` [PATCH 3/4] vl: Initialise main loop earlier Kevin Wolf
2020-01-09 18:35 ` [PATCH 4/4] qmp: Move dispatcher to a coroutine Kevin Wolf
2020-01-13 7:00 ` [PATCH 0/4] qmp: Optionally run handlers in coroutines Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200109183545.27452-1-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).