From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Laurent Vivier" <lvivier@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Corey Minyard" <cminyard@mvista.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Jason Wang" <jasowang@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Stefan Berger" <stefanb@linux.ibm.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <rth@twiddle.net>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: [PULL 02/30] multifd: Allocate uint64_t instead of ram_addr_t
Date: Tue, 14 Jan 2020 13:52:26 +0100 [thread overview]
Message-ID: <20200114125254.4515-3-quintela@redhat.com> (raw)
In-Reply-To: <20200114125254.4515-1-quintela@redhat.com>
We receive that value over the network, and ram_addr_t depends of
architecture. Just make enough space for 64bit.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---
migration/ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index b9147bcca3..d003538f06 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -1236,7 +1236,7 @@ int multifd_save_setup(void)
p->id = i;
p->pages = multifd_pages_init(page_count);
p->packet_len = sizeof(MultiFDPacket_t)
- + sizeof(ram_addr_t) * page_count;
+ + sizeof(uint64_t) * page_count;
p->packet = g_malloc0(p->packet_len);
p->packet->magic = cpu_to_be32(MULTIFD_MAGIC);
p->packet->version = cpu_to_be32(MULTIFD_VERSION);
--
2.24.1
next prev parent reply other threads:[~2020-01-14 13:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:52 [PULL 00/30] Migration pull patches (take 4) Juan Quintela
2020-01-14 12:52 ` [PULL 01/30] multifd: Initialize local variable Juan Quintela
2020-01-14 12:52 ` Juan Quintela [this message]
2020-01-14 12:52 ` [PULL 03/30] migration-test: Add migration multifd test Juan Quintela
2020-01-14 12:52 ` [PULL 04/30] migration: Make sure that we don't call write() in case of error Juan Quintela
2020-01-14 12:52 ` [PULL 05/30] migration-test: introduce functions to handle string parameters Juan Quintela
2020-01-14 12:52 ` [PULL 06/30] migration-test: ppc64: fix FORTH test program Juan Quintela
2020-01-14 12:52 ` [PULL 07/30] runstate: ignore finishmigrate -> prelaunch transition Juan Quintela
2020-01-14 12:52 ` [PULL 08/30] ram.c: remove unneeded labels Juan Quintela
2020-01-14 12:52 ` [PULL 09/30] migration: Rate limit inside host pages Juan Quintela
2020-01-14 12:52 ` [PULL 10/30] migration: Fix incorrect integer->float conversion caught by clang Juan Quintela
2020-01-14 12:52 ` [PULL 11/30] migration: Fix the re-run check of the migrate-incoming command Juan Quintela
2020-01-14 12:52 ` [PULL 12/30] misc: use QEMU_IS_ALIGNED Juan Quintela
2020-01-14 12:52 ` [PULL 13/30] migration: add savevm_state_handler_remove() Juan Quintela
2020-01-14 12:52 ` [PULL 14/30] migration: savevm_state_handler_insert: constant-time element insertion Juan Quintela
2020-01-14 12:52 ` [PULL 15/30] migration/ram: Yield periodically to the main loop Juan Quintela
2020-01-14 12:52 ` [PULL 16/30] migration/postcopy: reduce memset when it is zero page and matches_target_page_size Juan Quintela
2020-01-14 12:52 ` [PULL 17/30] migration/postcopy: wait for decompress thread in precopy Juan Quintela
2020-01-14 12:52 ` [PULL 18/30] migration/postcopy: count target page number to decide the place_needed Juan Quintela
2020-01-14 12:52 ` [PULL 19/30] migration/postcopy: set all_zero to true on the first target page Juan Quintela
2020-01-14 12:52 ` [PULL 20/30] migration/postcopy: enable random order target page arrival Juan Quintela
2020-01-14 12:52 ` [PULL 21/30] migration/postcopy: enable compress during postcopy Juan Quintela
2020-01-14 12:52 ` [PULL 22/30] migration/multifd: clean pages after filling packet Juan Quintela
2020-01-14 12:52 ` [PULL 23/30] migration/multifd: not use multifd during postcopy Juan Quintela
2020-01-14 12:52 ` [PULL 24/30] migration/multifd: fix nullptr access in terminating multifd threads Juan Quintela
2020-01-14 12:52 ` [PULL 25/30] migration/multifd: fix destroyed mutex " Juan Quintela
2020-01-14 12:52 ` [PULL 26/30] Bug #1829242 correction Juan Quintela
2020-01-14 12:52 ` [PULL 27/30] migration: Define VMSTATE_INSTANCE_ID_ANY Juan Quintela
2020-01-14 12:52 ` [PULL 28/30] migration: Change SaveStateEntry.instance_id into uint32_t Juan Quintela
2020-01-14 12:52 ` [PULL 29/30] apic: Use 32bit APIC ID for migration instance ID Juan Quintela
2020-01-14 12:52 ` [PULL 30/30] migration: Support QLIST migration Juan Quintela
2020-01-17 12:05 ` [PULL 00/30] Migration pull patches (take 4) Peter Maydell
2020-01-17 12:22 ` Juan Quintela
2020-01-17 12:41 ` Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114125254.4515-3-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=berrange@redhat.com \
--cc=cminyard@mvista.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=stefanb@linux.ibm.com \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).